[fix](mtmv) Fix NPE in show create materialized view after upgrade#61898
Closed
seawinde wants to merge 2 commits intoapache:masterfrom
Closed
[fix](mtmv) Fix NPE in show create materialized view after upgrade#61898seawinde wants to merge 2 commits intoapache:masterfrom
seawinde wants to merge 2 commits intoapache:masterfrom
Conversation
### What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
After upgrading from 4.0.2 to 4.0.4, executing `SHOW CREATE MATERIALIZED VIEW`
throws NullPointerException because `MTMV.getSessionVariables()` returns null for
materialized views created before the `sessionVariables` field was introduced.
The `sessionVariables` field (annotated with `@SerializedName("sv")`) was added
after 4.0.2. MTMVs created in 4.0.2 do not have this field persisted, so after
upgrade it deserializes as null. The code in `ShowCreateMTMVInfo.getShowResultSet()`
called `mtmv.getSessionVariables().toString()` without null protection.
Fix: Add null check - when sessionVariables is null, display empty map `{}`.
### Release note
Fix NPE when executing SHOW CREATE MATERIALIZED VIEW for materialized views
created before the sessionVariables feature was introduced (e.g. upgrade from
4.0.2 to 4.0.4).
### Check List (For Author)
- Test: Unit Test
- Behavior changed: No
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 26487 ms |
TPC-DS: Total hot run time: 168478 ms |
Member
Author
|
another pr fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
After upgrading from 4.0.2 to 4.0.4, executing
SHOW CREATE MATERIALIZED VIEWthrows NullPointerException becauseMTMV.getSessionVariables()returns null for materialized views created before thesessionVariablesfield was introduced.The
sessionVariablesfield (annotated with@SerializedName("sv")) was added after 4.0.2. MTMVs created in 4.0.2 do not have this field persisted, so after upgrade it deserializes as null. The code inShowCreateMTMVInfo.getShowResultSet()calledmtmv.getSessionVariables().toString()without null protection.Fix: Add null check - when sessionVariables is null, display empty map
{}.Release note
Fix NPE when executing SHOW CREATE MATERIALIZED VIEW for materialized views created before the sessionVariables feature was introduced (e.g. upgrade from 4.0.2 to 4.0.4).
Check List (For Author)
What problem does this PR solve?
Issue Number: #58031
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)