[fix](nested-type) fix cases from s3 #55896
Merged
eldenmoon merged 1 commit intoapache:masterfrom Sep 12, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
github-actions
Bot
added
the
lfs-detected!
amorynan
force-pushed
the
fix-case-nested-s3
branch
from
076c078 to
3b87588
Compare
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
Contributor
Author
|
run buildall |
hello-stephen
approved these changes
Sep 12, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
16 tasks
Mryange
added a commit
that referenced
this pull request
Apr 15, 2026
…_with_s3data (#62488) The regression test `datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data` was failing with a `CHAR result mismatch` on the `order_qt_sql_s3` tag. Root-cause analysis: 1. The S3 source files (`one_level_array.parquet`, `.orc`, `.csv`) in `oss://doris-regression-hk/regression/datalake/` have **not changed since 2024-07-27** (confirmed via `ossutil stat`). The parquet `c_bool` column is `list<bool>` (verified with pyarrow). The column type (`array<boolean>`) in the test plugin has also never changed. 2. On **2025-09-12**, commit `074d88b` (PR #55896, "fix cases from s3") added `WHERE k1 IS NOT NULL` to the query and regenerated the `.out`. At that time, Doris had a bug in reading parquet `list<bool>` values inside nested arrays, producing incorrect boolean values (e.g. `[0, 0, 1, 0, ...]` instead of the correct `[0, 0, 0, 1, 1, ...]`). 3. On **2025-12-16**, commit `0031179b1e6` (PR #58785, "fix parquet topn lazy mat complex data error result") refactored `ColumnChunkReader` to use `IN_COLLECTION`/`OFFSET_INDEX` template parameters, giving nested-array columns a distinct and correct read path. This fix incidentally corrected the boolean array reading for columns like `c_bool`. 4. After PR #58785 landed, Doris now reads parquet `list<bool>` correctly (matching pyarrow), but the `.out` file was never updated, causing the test to fail. Fix: force-regenerate `one_level_nestedtypes_with_s3data.out` using the current correct Doris behavior against the unchanged S3 data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)