Skip to content

[Ut] Fix be ut failed for topn_function_test#5449

Merged
caiconghui merged 1 commit intoapache:masterfrom
caiconghui:fix-ut
Mar 4, 2021
Merged

[Ut] Fix be ut failed for topn_function_test#5449
caiconghui merged 1 commit intoapache:masterfrom
caiconghui:fix-ut

Conversation

@caiconghui
Copy link
Copy Markdown
Contributor

@caiconghui caiconghui commented Mar 3, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have created an issue on (Fix [Ut] run topn_function_test failed in be unit test #5450) and described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If these changes need document changes, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui caiconghui changed the title [Ut] Fix ut failed for topn_function_test [Ut] Fix be ut failed for topn_function_test Mar 3, 2021
@caiconghui caiconghui added kind/fix Categorizes issue or PR as related to a bug. kind/test labels Mar 3, 2021
Copy link
Copy Markdown
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added the approved Indicates a PR has been approved by one committer. label Mar 3, 2021
@caiconghui caiconghui merged commit 47d6b1f into apache:master Mar 4, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Apr 21, 2021
Co-authored-by: caiconghui [蔡聪辉] <caiconghui@xiaomi.com>
@caiconghui caiconghui deleted the fix-ut branch August 23, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ut] run topn_function_test failed in be unit test

2 participants