[opt](load) S3 Load and TVF support access without AKSK#53592
Merged
dataroaring merged 4 commits intoapache:masterfrom Jul 24, 2025
Merged
[opt](load) S3 Load and TVF support access without AKSK#53592dataroaring merged 4 commits intoapache:masterfrom
dataroaring merged 4 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
liaoxin01
force-pushed
the
load_without_aksk
branch
2 times, most recently
from
d794ed9 to
94c1a8e
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34320 ms |
TPC-DS: Total hot run time: 189628 ms |
ClickBench: Total hot run time: 33.27 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
CalvinKirs
reviewed
Jul 21, 2025
Comment on lines
-496
to
-501
| //should add connectivity test | ||
| boolean connectivityTest = FileSystemFactory.get(brokerDesc.getStorageProperties()) | ||
| .connectivityTest(filePaths); | ||
| if (!connectivityTest) { | ||
| throw new UserException("Failed to access object storage, message=connectivity test failed"); | ||
| } |
Member
There was a problem hiding this comment.
Why skip connectivity checks? It's always better to fail fast when user credentials are invalid. public access is the least commonly used authentication method in production.
Contributor
Author
There was a problem hiding this comment.
The headBucket interface used for connectivity check requires users to have either headBucket or listBucket permissions. But actual users may not necessarily have this permission. For example, accessing only a specific file does not require granting Bucket related permissions.
CalvinKirs
reviewed
Jul 21, 2025
Comment on lines
+172
to
+175
| // For anonymous access (no credentials required) | ||
| if (StringUtils.isBlank(getAccessKey()) && StringUtils.isBlank(getSecretKey())) { | ||
| return AnonymousCredentialsProvider.create(); | ||
| } |
Member
There was a problem hiding this comment.
This setup allows COS/OBS/OSS to be accessed without credentials. Have you tested whether they actually permit this kind of access?
Contributor
Author
There was a problem hiding this comment.
I moved the code to each own implementation, and COS/OBS/OSS also support anonymous access.
Member
|
Could you please add some context and design details to the PR description? tbh, this approach feels a bit too blunt. You need to make sure the corresponding bucket/key is publicly accessible. Besides that, I really find it hard to imagine that database-related applications in a production environment would actually access public S3 data |
Contributor
For users do tests using public dataset. |
liaoxin01
force-pushed
the
load_without_aksk
branch
from
94c1a8e to
c82baa2
Compare
Contributor
Author
|
run buildall |
Gabriel39
previously approved these changes
Jul 21, 2025
Contributor
|
I tested in my environment and all is OK without AK and SK to access public-available S3 buckets. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34511 ms |
TPC-DS: Total hot run time: 191853 ms |
ClickBench: Total hot run time: 32.74 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 33722 ms |
TPC-DS: Total hot run time: 186587 ms |
ClickBench: Total hot run time: 32.13 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
CalvinKirs
approved these changes
Jul 24, 2025
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 27, 2025
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 27, 2025
morrySnow
pushed a commit
that referenced
this pull request
Jul 28, 2025
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 29, 2025
16 tasks
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 30, 2025
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Aug 4, 2025
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 8, 2025
dataroaring
pushed a commit
that referenced
this pull request
Aug 12, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
There are scenarios where publicly readable buckets are used for testing with open datasets, requiring access without AK/SK credentials. Anonymous access to data on S3 is supported here.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)