[Fix](mow) seg compaction should wait for calc delete bitmap tasks on input segments before converting delete bitmaps on them#53198
Merged
zhannngchen merged 6 commits intoapache:masterfrom Jul 17, 2025
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ce945b4 to
9899a91
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33130 ms |
TPC-DS: Total hot run time: 189655 ms |
ClickBench: Total hot run time: 29.19 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
8ae861c to
fe43e14
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33490 ms |
TPC-DS: Total hot run time: 188135 ms |
ClickBench: Total hot run time: 29.75 s |
fd5fb89 to
88211a3
Compare
TPC-DS: Total hot run time: 188496 ms |
ClickBench: Total hot run time: 32.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Dec 9, 2025
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.
yiguolei
pushed a commit
that referenced
this pull request
Dec 9, 2025
…lete bitmap tasks on input segments before converting delete bitmaps on them (#53198)" (#58855) This reverts commit 9b6115d. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Dec 16, 2025
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Dec 16, 2025
…tasks on input segments before converting delete bitmaps on them (apache#53198)" This reverts commit 9b6115d.
16 tasks
zclllyybb
pushed a commit
to zclllyybb/doris
that referenced
this pull request
Feb 28, 2026
… input segments before converting delete bitmaps on them (apache#53198) ### What problem does this PR solve? When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(apache#38369).
zclllyybb
pushed a commit
to zclllyybb/doris
that referenced
this pull request
Mar 1, 2026
… input segments before converting delete bitmaps on them (apache#53198) ### What problem does this PR solve? When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(apache#38369).
zclllyybb
pushed a commit
to zclllyybb/doris
that referenced
this pull request
Mar 1, 2026
… input segments before converting delete bitmaps on them (apache#53198) ### What problem does this PR solve? When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(apache#38369).
zclllyybb
pushed a commit
to zclllyybb/doris
that referenced
this pull request
Mar 1, 2026
… input segments before converting delete bitmaps on them (apache#53198) ### What problem does this PR solve? When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(apache#38369).
zclllyybb
pushed a commit
to zclllyybb/doris
that referenced
this pull request
Mar 1, 2026
… input segments before converting delete bitmaps on them (apache#53198) ### What problem does this PR solve? When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(apache#38369).
zclllyybb
pushed a commit
to zclllyybb/doris
that referenced
this pull request
Mar 1, 2026
… input segments before converting delete bitmaps on them (apache#53198) ### What problem does this PR solve? When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(apache#38369).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the table has sequence column, load may generate delete bitmap marks on its own rowset. Segment compaction should wait for delete bitmaps generation before converting these delete bitmaps(#38369).
Caused by #48156
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)