[Fix](mow) Fix DeleteBitmap's assignment operator and constructor#52582
Merged
dataroaring merged 4 commits intoapache:masterfrom Jul 9, 2025
Merged
[Fix](mow) Fix DeleteBitmap's assignment operator and constructor#52582dataroaring merged 4 commits intoapache:masterfrom
DeleteBitmap's assignment operator and constructor#52582dataroaring merged 4 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
3f35215 to
f2b5fd6
Compare
Contributor
Author
|
run buildall |
ad7580a to
44b81ca
Compare
DeleteBitmap's assignment operatorDeleteBitmap's assignment operator and constructor
44b81ca to
03cb0db
Compare
TPC-H: Total hot run time: 33290 ms |
98cb439 to
7e54575
Compare
TPC-DS: Total hot run time: 185012 ms |
7e54575 to
60db2a4
Compare
ClickBench: Total hot run time: 29.6 s |
60db2a4 to
54c8ec9
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35579 ms |
TPC-DS: Total hot run time: 189317 ms |
ClickBench: Total hot run time: 30.05 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
TPC-DS: Total hot run time: 185161 ms |
ClickBench: Total hot run time: 29.67 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run external |
925f1a8 to
b250027
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33149 ms |
TPC-DS: Total hot run time: 185763 ms |
ClickBench: Total hot run time: 29.31 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…52582) ### What problem does this PR solve? Currently, `DeleteBitmap`'s wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of #52440 because `origin_dbm` and `delete_bitmap` refer to the same `DeleteBitmap` object. 
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…52582) ### What problem does this PR solve? Currently, `DeleteBitmap`'s wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification in `CloudSchemaChangeJob::_process_delete_bitmap` of #52440 because `origin_dbm` and `delete_bitmap` refer to the same `DeleteBitmap` object. 
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Jul 21, 2025
…r and constructor (apache#4133) pick apache#52582 jira: http://39.106.86.136:8090/browse/CORE-5352
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently,

DeleteBitmap's wrong move assignment operator can cause correctness problem on mow table if SC's alter process produce delete bitmaps when calculating delete bitmaps for incremental rowsets after the modification inCloudSchemaChangeJob::_process_delete_bitmapof #52440 becauseorigin_dbmanddelete_bitmaprefer to the sameDeleteBitmapobject.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)