[fix](inverted index) catch IO exception to avoid coredump in inverted index string reader#51844
Merged
airborne12 merged 2 commits intoapache:masterfrom Jun 18, 2025
Merged
Conversation
…d index string reader
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling around CLucene interactions in the string inverted index reader to prevent core dumps on IO failures and introduces unit tests to verify that failures are correctly converted to error statuses.
- Wraps the search and cache logic in
StringTypeInvertedIndexReader::queryinside atry/catchforCLuceneErrorand logs the error. - Returns
INVERTED_INDEX_CLUCENE_ERRORinstead of crashing on IO exceptions. - Adds mock readers and new tests (
CacheErrorScenarios,TokenizedIndexQueryErrorScenarios) to cover both un-tokenized and tokenized index error paths.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| be/src/olap/rowset/segment_v2/inverted_index_reader.cpp | Wrapped query body in try/catch, added logging and status return on CLuceneError. |
| be/test/olap/rowset/segment_v2/inverted_index_reader_test.cpp | Added mocks to simulate CLucene IO failures and tests for both cache-enabled and tokenized queries. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34395 ms |
TPC-DS: Total hot run time: 185782 ms |
TPC-H: Total hot run time: 33825 ms |
TPC-DS: Total hot run time: 193001 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33662 ms |
TPC-DS: Total hot run time: 191581 ms |
ClickBench: Total hot run time: 29.71 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
airborne12
added a commit
to airborne12/apache-doris
that referenced
this pull request
Jul 7, 2025
…d index string reader (apache#51844) Problem Summary: This PR adds error handling around CLucene interactions in the string inverted index reader to prevent core dumps on IO failures and introduces.
airborne12
added a commit
to airborne12/apache-doris
that referenced
this pull request
Jul 7, 2025
…d index string reader (apache#51844) Problem Summary: This PR adds error handling around CLucene interactions in the string inverted index reader to prevent core dumps on IO failures and introduces.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
This PR adds error handling around CLucene interactions in the string inverted index reader to prevent core dumps on IO failures and introduces.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)