[fix](filecache) fix load_cache_info_into_memory crash#51684
Merged
dataroaring merged 1 commit intoapache:masterfrom Jun 18, 2025
Merged
[fix](filecache) fix load_cache_info_into_memory crash#51684dataroaring merged 1 commit intoapache:masterfrom
dataroaring merged 1 commit intoapache:masterfrom
Conversation
keep _storage last so it will deconstruct first otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache so join this async load thread first Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Jun 12, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33872 ms |
TPC-DS: Total hot run time: 193475 ms |
ClickBench: Total hot run time: 29.1 s |
Contributor
Author
|
run vault_p0 |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
keep _storage last so it will deconstruct first otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache so join this async load thread first Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
dataroaring
pushed a commit
that referenced
this pull request
Jun 19, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
keep _storage last so it will deconstruct first otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache so join this async load thread first Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
morrySnow
pushed a commit
that referenced
this pull request
Jun 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keep _storage last so it will deconstruct first
otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache
so join this async load thread first
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)