[fix](nereids) fix sum0 cannot pass multi distinct check by feiniaofeiafei · Pull Request #51234 · apache/doris

feiniaofeiafei · 2025-05-26T04:24:49Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #32541

Problem Summary:
Before this pr,

select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a

sql like this will report error: sum0(DISTINCT c#2) can't support multi distinct.
This pr change the check, and the sql can be executed.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-05-26T04:24:54Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

feiniaofeiafei · 2025-05-26T04:25:03Z

run buildall

doris-robot · 2025-05-26T05:05:18Z

TPC-H: Total hot run time: 34142 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9565b37482904e8836565626da94f17a80177447, data reload: false

------ Round 1 ----------------------------------
q1	26272	5382	5016	5016
q2	2075	273	185	185
q3	10420	1235	711	711
q4	10223	1002	546	546
q5	7535	2356	2335	2335
q6	178	167	131	131
q7	935	743	597	597
q8	10641	1273	1120	1120
q9	6972	5102	5078	5078
q10	6859	2328	1928	1928
q11	491	295	276	276
q12	646	360	210	210
q13	19817	3679	3078	3078
q14	229	224	212	212
q15	541	479	488	479
q16	439	443	375	375
q17	582	858	367	367
q18	7709	7359	7111	7111
q19	1814	1001	619	619
q20	369	385	247	247
q21	4232	3357	2449	2449
q22	1161	1120	1072	1072
Total cold run time: 120140 ms
Total hot run time: 34142 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5201	5064	5086	5064
q2	255	340	244	244
q3	2346	2916	2683	2683
q4	1520	1940	1525	1525
q5	4631	4518	4579	4518
q6	220	173	136	136
q7	1976	1915	1766	1766
q8	2606	2603	2500	2500
q9	7165	7013	7185	7013
q10	3001	3162	2748	2748
q11	583	501	505	501
q12	688	785	630	630
q13	3527	3859	3298	3298
q14	285	288	274	274
q15	511	477	484	477
q16	436	496	437	437
q17	1158	1500	1411	1411
q18	7746	7577	7412	7412
q19	799	892	961	892
q20	1940	1954	1839	1839
q21	4797	4490	4400	4400
q22	1100	1053	1043	1043
Total cold run time: 52491 ms
Total hot run time: 50811 ms

doris-robot · 2025-05-26T05:17:32Z

TPC-DS: Total hot run time: 192397 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9565b37482904e8836565626da94f17a80177447, data reload: false

query1	1397	1103	1071	1071
query2	6367	1763	1799	1763
query3	11031	4553	4418	4418
query4	55513	25193	23451	23451
query5	5022	510	463	463
query6	347	227	205	205
query7	4880	523	291	291
query8	325	254	233	233
query9	5561	2617	2627	2617
query10	432	329	268	268
query11	14976	15480	14758	14758
query12	168	111	104	104
query13	1070	542	410	410
query14	10148	6331	6252	6252
query15	200	201	174	174
query16	7097	638	507	507
query17	1060	733	599	599
query18	1561	412	307	307
query19	200	211	189	189
query20	131	134	119	119
query21	209	126	108	108
query22	4427	4537	4288	4288
query23	34219	33523	33336	33336
query24	6699	2451	2439	2439
query25	473	468	422	422
query26	681	278	148	148
query27	2244	515	341	341
query28	2966	2157	2139	2139
query29	593	578	449	449
query30	275	220	194	194
query31	830	845	815	815
query32	80	66	61	61
query33	446	361	326	326
query34	789	858	532	532
query35	827	848	772	772
query36	978	987	910	910
query37	117	102	77	77
query38	4254	4337	4118	4118
query39	1518	1493	1452	1452
query40	209	134	110	110
query41	57	55	57	55
query42	126	121	113	113
query43	503	498	503	498
query44	1371	852	852	852
query45	184	172	169	169
query46	852	1022	657	657
query47	1883	1830	1875	1830
query48	411	465	328	328
query49	677	538	428	428
query50	662	704	415	415
query51	4254	4277	4204	4204
query52	119	113	105	105
query53	237	270	185	185
query54	604	601	537	537
query55	89	90	87	87
query56	327	299	290	290
query57	1178	1214	1116	1116
query58	268	285	265	265
query59	2706	2798	2656	2656
query60	371	349	336	336
query61	154	147	167	147
query62	748	761	689	689
query63	228	201	203	201
query64	1741	1032	719	719
query65	4275	4223	4260	4223
query66	709	402	301	301
query67	16017	15618	15454	15454
query68	7603	885	516	516
query69	532	311	271	271
query70	1175	1135	1123	1123
query71	516	334	301	301
query72	6099	4738	4833	4738
query73	1118	640	355	355
query74	9220	9155	8824	8824
query75	3765	3190	2685	2685
query76	4062	1198	770	770
query77	623	390	287	287
query78	10160	10125	9307	9307
query79	2318	886	597	597
query80	634	554	458	458
query81	482	245	219	219
query82	420	125	101	101
query83	406	260	230	230
query84	296	103	85	85
query85	802	407	321	321
query86	385	333	279	279
query87	4371	4445	4289	4289
query88	3485	2310	2314	2310
query89	409	345	299	299
query90	1925	219	215	215
query91	157	143	113	113
query92	75	62	57	57
query93	1618	975	574	574
query94	669	421	301	301
query95	367	299	294	294
query96	502	591	285	285
query97	2713	2751	2609	2609
query98	239	202	201	201
query99	1437	1410	1287	1287
Total cold run time: 299654 ms
Total hot run time: 192397 ms

doris-robot · 2025-05-26T05:22:42Z

ClickBench: Total hot run time: 29.14 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9565b37482904e8836565626da94f17a80177447, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.13
query3	0.24	0.20	0.20
query4	1.59	0.19	0.19
query5	0.44	0.43	0.44
query6	1.18	0.65	0.66
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.53
query10	0.56	0.58	0.57
query11	0.15	0.12	0.11
query12	0.14	0.12	0.11
query13	0.62	0.61	0.61
query14	0.78	0.81	0.81
query15	0.87	0.86	0.86
query16	0.38	0.39	0.39
query17	1.06	1.04	1.02
query18	0.22	0.22	0.22
query19	1.98	1.84	1.76
query20	0.02	0.00	0.01
query21	15.39	0.89	0.54
query22	0.74	1.32	0.78
query23	14.74	1.40	0.65
query24	7.68	1.10	0.86
query25	0.49	0.26	0.09
query26	0.69	0.16	0.14
query27	0.05	0.06	0.05
query28	8.66	0.81	0.44
query29	12.54	3.87	3.27
query30	0.26	0.08	0.06
query31	2.82	0.58	0.40
query32	3.23	0.55	0.46
query33	3.00	3.02	3.13
query34	15.78	5.11	4.51
query35	4.56	4.52	4.45
query36	0.65	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.07	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 102.81 s
Total hot run time: 29.14 s

feiniaofeiafei · 2025-05-27T02:27:28Z

run buildall

doris-robot · 2025-05-27T04:25:13Z

TPC-H: Total hot run time: 33931 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0c53bcd8ae98beea32ae7a0f17f1c0cd765e1494, data reload: false

------ Round 1 ----------------------------------
q1	26287	5154	5223	5154
q2	2094	282	189	189
q3	10488	1223	681	681
q4	10227	978	520	520
q5	7647	2353	2346	2346
q6	187	165	133	133
q7	914	734	610	610
q8	9335	1276	1155	1155
q9	6740	5138	5138	5138
q10	6864	2320	1885	1885
q11	485	289	275	275
q12	342	362	218	218
q13	17791	3632	3062	3062
q14	222	225	208	208
q15	537	490	490	490
q16	414	427	383	383
q17	619	862	365	365
q18	7795	7243	7023	7023
q19	1659	960	578	578
q20	342	337	223	223
q21	3758	2536	2351	2351
q22	1050	1004	944	944
Total cold run time: 115797 ms
Total hot run time: 33931 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5179	5199	5059	5059
q2	239	323	229	229
q3	2170	2680	2317	2317
q4	1342	1791	1449	1449
q5	4446	4443	4396	4396
q6	208	172	129	129
q7	1988	1965	1720	1720
q8	2602	2565	2488	2488
q9	7219	7103	7178	7103
q10	3027	3147	2756	2756
q11	582	522	498	498
q12	674	771	611	611
q13	3561	3916	3363	3363
q14	292	291	283	283
q15	531	477	475	475
q16	440	533	455	455
q17	1180	1554	1419	1419
q18	7969	7578	7364	7364
q19	812	802	933	802
q20	2016	1969	1866	1866
q21	4899	4708	4397	4397
q22	1089	1022	1015	1015
Total cold run time: 52465 ms
Total hot run time: 50194 ms

doris-robot · 2025-05-27T04:37:27Z

TPC-DS: Total hot run time: 193499 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0c53bcd8ae98beea32ae7a0f17f1c0cd765e1494, data reload: false

query1	1399	1096	1062	1062
query2	6346	1869	1851	1851
query3	11013	4615	4426	4426
query4	54964	25471	23160	23160
query5	5260	553	462	462
query6	366	230	196	196
query7	5031	503	287	287
query8	341	257	238	238
query9	6148	2690	2667	2667
query10	454	371	278	278
query11	15147	15048	15195	15048
query12	164	115	106	106
query13	1126	519	436	436
query14	10038	6235	6233	6233
query15	222	193	188	188
query16	7089	662	509	509
query17	1097	717	583	583
query18	1541	410	323	323
query19	221	204	172	172
query20	131	127	155	127
query21	201	126	107	107
query22	4430	4484	4276	4276
query23	34401	33661	33622	33622
query24	6660	2422	2428	2422
query25	481	490	418	418
query26	677	279	154	154
query27	2156	534	344	344
query28	2976	2186	2179	2179
query29	582	573	440	440
query30	273	227	203	203
query31	850	881	815	815
query32	78	66	67	66
query33	465	389	326	326
query34	809	866	566	566
query35	826	829	762	762
query36	981	1014	891	891
query37	121	105	79	79
query38	4262	4281	4319	4281
query39	1492	1476	1477	1476
query40	215	136	119	119
query41	62	65	74	65
query42	133	118	109	109
query43	523	532	490	490
query44	1365	858	859	858
query45	190	176	168	168
query46	900	1023	667	667
query47	1847	1839	1779	1779
query48	410	464	329	329
query49	695	516	444	444
query50	689	726	428	428
query51	4260	4278	4228	4228
query52	114	108	104	104
query53	234	254	191	191
query54	611	580	524	524
query55	88	86	85	85
query56	311	306	315	306
query57	1181	1156	1114	1114
query58	276	266	287	266
query59	2869	2902	2852	2852
query60	343	339	312	312
query61	126	123	132	123
query62	733	745	670	670
query63	236	190	189	189
query64	1519	1003	693	693
query65	4284	4248	4246	4246
query66	706	404	304	304
query67	15836	15601	15456	15456
query68	7057	900	531	531
query69	544	312	284	284
query70	1195	1153	1055	1055
query71	512	320	305	305
query72	5811	4850	4957	4850
query73	1327	702	359	359
query74	8930	9105	8995	8995
query75	3832	3193	2645	2645
query76	4319	1212	788	788
query77	721	389	300	300
query78	10017	10113	9246	9246
query79	1802	797	577	577
query80	650	517	458	458
query81	477	263	221	221
query82	400	129	98	98
query83	358	267	233	233
query84	287	105	99	99
query85	869	359	309	309
query86	359	304	293	293
query87	4416	4399	4348	4348
query88	3003	2339	2342	2339
query89	416	314	310	310
query90	1963	214	216	214
query91	157	158	122	122
query92	72	65	56	56
query93	1182	973	590	590
query94	684	403	299	299
query95	377	321	291	291
query96	508	608	288	288
query97	2783	2727	2648	2648
query98	227	204	216	204
query99	1437	1401	1246	1246
Total cold run time: 298267 ms
Total hot run time: 193499 ms

doris-robot · 2025-05-27T04:42:40Z

ClickBench: Total hot run time: 29.14 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0c53bcd8ae98beea32ae7a0f17f1c0cd765e1494, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.21
query4	1.60	0.20	0.11
query5	0.45	0.42	0.45
query6	1.16	0.67	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.51	0.54
query10	0.56	0.57	0.55
query11	0.15	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	0.79	0.81	0.80
query15	0.89	0.85	0.88
query16	0.37	0.37	0.39
query17	1.02	1.08	1.06
query18	0.23	0.22	0.20
query19	1.94	1.78	1.96
query20	0.01	0.01	0.02
query21	15.39	0.92	0.55
query22	0.76	1.37	0.77
query23	14.74	1.40	0.62
query24	6.77	2.18	0.67
query25	0.48	0.24	0.07
query26	0.62	0.18	0.14
query27	0.05	0.05	0.05
query28	9.26	0.87	0.45
query29	12.56	4.08	3.43
query30	0.25	0.09	0.07
query31	2.82	0.61	0.38
query32	3.23	0.55	0.47
query33	3.08	3.15	3.13
query34	15.87	5.08	4.51
query35	4.53	4.52	4.50
query36	0.66	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.02	0.03	0.02
query40	0.17	0.15	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 102.54 s
Total hot run time: 29.14 s

morrySnow · 2025-05-27T07:07:58Z

+    (4,5,6),(4,5,7),(4,5,8),
+    (5,0,0),(5,0,0),(5,0,0); 
+    """
+    sql "select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a"


test all null case, could sum0(distinct b) get right result?

feiniaofeiafei · 2025-05-30T03:10:03Z

run buildall

doris-robot · 2025-05-30T03:29:30Z

TPC-H: Total hot run time: 33772 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cb7dd04666ed50a8d9055a32fcb61521a123643, data reload: false

------ Round 1 ----------------------------------
q1	26147	5071	5049	5049
q2	1949	271	182	182
q3	10366	1220	691	691
q4	10230	1022	530	530
q5	7641	2496	2336	2336
q6	200	173	131	131
q7	923	740	604	604
q8	9306	1466	1050	1050
q9	6778	5100	5161	5100
q10	6872	2320	1878	1878
q11	492	281	268	268
q12	340	351	211	211
q13	17769	3692	3067	3067
q14	232	234	212	212
q15	553	478	482	478
q16	432	431	367	367
q17	584	858	363	363
q18	7573	7180	7192	7180
q19	1835	980	566	566
q20	331	335	220	220
q21	3694	3139	2327	2327
q22	1055	964	962	962
Total cold run time: 115302 ms
Total hot run time: 33772 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5241	5123	5146	5123
q2	256	320	219	219
q3	2194	2616	2328	2328
q4	1334	1783	1306	1306
q5	4574	4462	4409	4409
q6	214	171	124	124
q7	2022	1915	1760	1760
q8	2598	2554	2475	2475
q9	7172	7204	7227	7204
q10	2981	3189	2779	2779
q11	579	510	491	491
q12	678	793	597	597
q13	3525	3997	3315	3315
q14	290	317	269	269
q15	517	476	478	476
q16	467	497	452	452
q17	1163	1573	1385	1385
q18	7667	7426	7475	7426
q19	786	833	913	833
q20	1977	2054	1883	1883
q21	4785	4311	4206	4206
q22	1071	1021	980	980
Total cold run time: 52091 ms
Total hot run time: 50040 ms

doris-robot · 2025-05-30T03:40:57Z

TPC-DS: Total hot run time: 186223 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cb7dd04666ed50a8d9055a32fcb61521a123643, data reload: false

query1	1006	490	508	490
query2	6566	1786	1841	1786
query3	6759	224	224	224
query4	26306	23700	23374	23374
query5	4275	635	483	483
query6	306	219	207	207
query7	4613	485	284	284
query8	262	224	214	214
query9	8618	2625	2631	2625
query10	450	338	277	277
query11	15673	15107	14914	14914
query12	155	104	110	104
query13	1661	543	394	394
query14	8676	6244	6278	6244
query15	204	196	170	170
query16	7115	633	458	458
query17	951	717	614	614
query18	1962	387	292	292
query19	190	180	172	172
query20	122	113	121	113
query21	212	118	102	102
query22	4130	4158	4114	4114
query23	34049	33149	33120	33120
query24	8462	2415	2435	2415
query25	545	448	379	379
query26	1235	274	155	155
query27	2758	530	340	340
query28	4326	2140	2109	2109
query29	778	544	427	427
query30	278	221	184	184
query31	930	847	759	759
query32	75	71	62	62
query33	549	376	329	329
query34	814	828	541	541
query35	788	798	756	756
query36	955	969	873	873
query37	114	105	82	82
query38	4204	4205	4184	4184
query39	1471	1434	1410	1410
query40	218	125	116	116
query41	74	66	68	66
query42	134	118	115	115
query43	509	507	460	460
query44	1327	846	835	835
query45	178	180	180	180
query46	862	1027	648	648
query47	1759	1788	1732	1732
query48	400	437	324	324
query49	756	506	396	396
query50	636	673	408	408
query51	4130	4219	4146	4146
query52	106	109	100	100
query53	222	259	184	184
query54	571	577	500	500
query55	83	85	83	83
query56	297	319	293	293
query57	1145	1143	1070	1070
query58	269	268	253	253
query59	2613	2566	2483	2483
query60	318	331	309	309
query61	166	129	122	122
query62	778	718	646	646
query63	228	187	186	186
query64	4407	1012	684	684
query65	4233	4172	4166	4166
query66	1141	411	324	324
query67	15748	15450	15534	15450
query68	5381	900	539	539
query69	486	314	270	270
query70	1242	1135	1135	1135
query71	393	332	297	297
query72	5628	4798	4820	4798
query73	671	713	344	344
query74	9147	9191	8676	8676
query75	3204	3198	2729	2729
query76	3171	1191	791	791
query77	467	367	307	307
query78	10082	10255	9295	9295
query79	1356	879	580	580
query80	628	573	450	450
query81	493	252	218	218
query82	220	132	103	103
query83	247	245	237	237
query84	298	112	94	94
query85	749	351	314	314
query86	338	301	288	288
query87	4282	4522	4216	4216
query88	2878	2248	2265	2248
query89	384	309	288	288
query90	1785	208	210	208
query91	136	151	115	115
query92	61	58	58	58
query93	1127	930	581	581
query94	609	390	298	298
query95	381	293	284	284
query96	493	559	288	288
query97	2682	2727	2665	2665
query98	221	217	216	216
query99	1304	1399	1234	1234
Total cold run time: 266395 ms
Total hot run time: 186223 ms

doris-robot · 2025-05-30T03:46:07Z

ClickBench: Total hot run time: 28.98 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cb7dd04666ed50a8d9055a32fcb61521a123643, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.11
query3	0.26	0.20	0.20
query4	1.59	0.20	0.11
query5	0.42	0.41	0.42
query6	1.17	0.67	0.67
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.58	0.52	0.50
query10	0.57	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.78	0.82	0.79
query15	0.87	0.85	0.84
query16	0.38	0.40	0.38
query17	1.03	1.07	1.07
query18	0.23	0.21	0.21
query19	1.92	1.79	1.80
query20	0.01	0.01	0.02
query21	15.40	0.89	0.54
query22	0.76	1.15	0.63
query23	15.00	1.38	0.60
query24	7.36	0.88	1.00
query25	0.47	0.18	0.14
query26	0.72	0.16	0.14
query27	0.05	0.05	0.05
query28	8.70	0.87	0.42
query29	12.64	3.94	3.22
query30	0.25	0.10	0.07
query31	2.83	0.58	0.39
query32	3.23	0.54	0.46
query33	3.03	3.05	3.01
query34	15.68	5.11	4.54
query35	4.52	4.57	4.52
query36	0.68	0.50	0.49
query37	0.09	0.07	0.07
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 102.76 s
Total hot run time: 28.98 s

feiniaofeiafei · 2025-05-30T07:04:50Z

run feut

feiniaofeiafei · 2025-06-03T02:31:20Z

run feut

github-actions · 2025-06-03T06:40:34Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-06-03T06:40:36Z

PR approved by anyone and no changes requested.

### What problem does this PR solve? Related PR: #32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a

### What problem does this PR solve? Related PR: apache#32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a

### What problem does this PR solve? Related PR: #32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a

…51234 (#52080) Cherry-picked from #51234 Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

### What problem does this PR solve? Related PR: apache#32541 Problem Summary: Before this pr, execute below sql will report error: sum0(DISTINCT c#2) can't support multi distinct. This pr change the check, and the sql can be executed. sql is: select sum0(distinct b),sum(distinct c) from test_sum0_multi_distinct_with_group_by group by a

…51234 (#52950) cherry-pick #51234 to branch-3.0

feiniaofeiafei marked this pull request as draft May 26, 2025 04:24

morrySnow reviewed May 27, 2025

View reviewed changes

feiniaofeiafei added 4 commits May 30, 2025 10:54

fix check

3d1fb08

add test

aaa2880

delete code

37c303a

add regression test

9cb7dd0

feiniaofeiafei force-pushed the fix_sum0_multi_distinct_check branch from 0c53bcd to 9cb7dd0 Compare May 30, 2025 03:09

feiniaofeiafei marked this pull request as ready for review June 3, 2025 06:20

924060929 approved these changes Jun 3, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 3, 2025

github-actions bot added the reviewed label Jun 3, 2025

morrySnow approved these changes Jun 3, 2025

View reviewed changes

morrySnow added the dev/2.1.x label Jun 3, 2025

morrySnow added the dev/3.0.x label Jun 3, 2025

morrySnow merged commit b7ce293 into apache:master Jun 3, 2025
29 of 30 checks passed

github-actions bot mentioned this pull request Jun 3, 2025

branch-3.0: [fix](nereids) fix sum0 cannot pass multi distinct check #51234 #51431

Closed

github-actions bot added the dev/2.1.x-conflict label Jun 3, 2025

morrySnow removed dev/2.1.x dev/2.1.x-conflict labels Jun 9, 2025

morrySnow added the dev/3.1.x label Jun 20, 2025

github-actions bot mentioned this pull request Jun 20, 2025

branch-3.1: [fix](nereids) fix sum0 cannot pass multi distinct check #51234 #52080

Merged

morrySnow pushed a commit that referenced this pull request Jun 23, 2025

branch-3.1: [fix](nereids) fix sum0 cannot pass multi distinct check #…

6c8ad0f

…51234 (#52080) Cherry-picked from #51234 Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Jun 23, 2025

feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Jul 8, 2025

[fix](nereids) fix sum0 cannot pass multi distinct check (apache#51234)

377953e

feiniaofeiafei mentioned this pull request Jul 8, 2025

branch-3.0: [fix](nereids) fix sum0 cannot pass multi distinct check #51234 #52950

Merged

feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Jul 9, 2025

[fix](nereids) fix sum0 cannot pass multi distinct check (apache#51234)

ab6b7df

morrySnow pushed a commit that referenced this pull request Jul 9, 2025

branch-3.0: [fix](nereids) fix sum0 cannot pass multi distinct check #…

916da87

…51234 (#52950) cherry-pick #51234 to branch-3.0

morrySnow added dev/3.0.7-merged and removed dev/3.0.x labels Jul 18, 2025

Conversation

feiniaofeiafei commented May 26, 2025 • edited by morrySnow Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented May 26, 2025

Uh oh!

feiniaofeiafei commented May 26, 2025

Uh oh!

doris-robot commented May 26, 2025

Uh oh!

doris-robot commented May 26, 2025

Uh oh!

doris-robot commented May 26, 2025

Uh oh!

feiniaofeiafei commented May 27, 2025

Uh oh!

doris-robot commented May 27, 2025

Uh oh!

doris-robot commented May 27, 2025

Uh oh!

doris-robot commented May 27, 2025

Uh oh!

morrySnow May 27, 2025

Choose a reason for hiding this comment

Uh oh!

feiniaofeiafei Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

feiniaofeiafei commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

Uh oh!

doris-robot commented May 30, 2025

Uh oh!

feiniaofeiafei commented May 30, 2025

Uh oh!

feiniaofeiafei commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feiniaofeiafei commented May 26, 2025 •

edited by morrySnow

Loading