[fix](nereids) fix bug of MergePercentileToArray#49773
Merged
morrySnow merged 4 commits intoapache:masterfrom May 6, 2025
Merged
[fix](nereids) fix bug of MergePercentileToArray#49773morrySnow merged 4 commits intoapache:masterfrom
morrySnow merged 4 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
feiniaofeiafei
force-pushed
the
test_grouping
branch
from
cd7b12d to
d5e3224
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36262 ms |
TPC-DS: Total hot run time: 194319 ms |
ClickBench: Total hot run time: 31.2 s |
morrySnow
previously approved these changes
Apr 3, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
seawinde
approved these changes
Apr 9, 2025
feiniaofeiafei
force-pushed
the
test_grouping
branch
2 times, most recently
from
4509a6e to
d69abdd
Compare
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33838 ms |
TPC-DS: Total hot run time: 193200 ms |
ClickBench: Total hot run time: 29.97 s |
morrySnow
reviewed
Apr 24, 2025
|
|
||
| for (Map.Entry<DistinctAndExpr, List<AggregateFunction>> entry : funcMap.entrySet()) { | ||
| List<Literal> literals = new ArrayList<>(); | ||
| List<Expression> literals = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
rename this variable to a proper name
| literals.add((Literal) literal.get(0)); | ||
| literals.add(aggFunc.child(1)); | ||
| } | ||
| ArrayLiteral arrayLiteral = new ArrayLiteral(literals); |
Contributor
There was a problem hiding this comment.
if all expression are literal, generate a array literal directly for better performance
feiniaofeiafei
force-pushed
the
test_grouping
branch
from
d69abdd to
57d13e3
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34313 ms |
TPC-DS: Total hot run time: 192685 ms |
ClickBench: Total hot run time: 29.06 s |
morrySnow
approved these changes
May 6, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
May 6, 2025
### What problem does this PR solve? Related PR: #34313 Problem Summary: When the second argument of percentile is not literal, will report error ：index out of range. This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.
github-actions bot
pushed a commit
that referenced
this pull request
May 6, 2025
### What problem does this PR solve? Related PR: #34313 Problem Summary: When the second argument of percentile is not literal, will report error ：index out of range. This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.
yiguolei
pushed a commit
that referenced
this pull request
May 6, 2025
dataroaring
pushed a commit
that referenced
this pull request
May 7, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? Related PR: apache#34313 Problem Summary: When the second argument of percentile is not literal, will report error ：index out of range. This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #34313
Problem Summary:
When the second argument of percentile is not literal, will report error ：index out of range.
This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)