[fix](microbench) Fix some file cache microbench compile bug#49269
Merged
BiteTheDDDDt merged 2 commits intoapache:masterfrom Apr 1, 2025
Merged
[fix](microbench) Fix some file cache microbench compile bug#49269BiteTheDDDDt merged 2 commits intoapache:masterfrom
BiteTheDDDDt merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
TPC-H: Total hot run time: 32365 ms |
TPC-DS: Total hot run time: 192464 ms |
ClickBench: Total hot run time: 31.41 s |
Collaborator
Author
|
run buildall |
gavinchou
approved these changes
Mar 19, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32263 ms |
TPC-DS: Total hot run time: 184614 ms |
ClickBench: Total hot run time: 30.78 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
### What problem does this PR solve? 1. fix micro BUILD_FILE_CACHE_MICROBENCH_TOOL not work in file_cache_microbench.cpp 2. fix MircobenchS3FileWriter typo error 3. ./build.sh default not compile file_cache_microbench 4. fix , exit coredump ``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f54c898a550 in __pthread_timedjoin_ex () from /lib64/libpthread.so.0 [Current thread is 1 (Thread 0x7f54cafad940 (LWP 2810860))] (gdb) bt #0 0x00007f54c898a550 in __pthread_timedjoin_ex () from /lib64/libpthread.so.0 #1 0x000055eb6a7ac513 in __gthread_join (__value_ptr=0x0, __threadid=<optimized out>) at /data/gcc-11.1.0/build/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu/bits/gthr-default.h:669 #2 std::thread::join (this=0x55eb6eda1ce0) at ../../../../../libstdc++-v3/src/c++11/thread.cc:112 #3 0x000055eb5cb548bb in ThreadPool::~ThreadPool (this=this@entry=0x7fff65768480) #4 0x000055eb5cb4aebe in JobManager::~JobManager (this=this@entry=0x7fff65768420) #5 0x000055eb5cb49a14 in main (argc=1, argv=<optimized out>) ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…49269) ### What problem does this PR solve? 1. fix micro BUILD_FILE_CACHE_MICROBENCH_TOOL not work in file_cache_microbench.cpp 2. fix MircobenchS3FileWriter typo error 3. ./build.sh default not compile file_cache_microbench 4. fix , exit coredump ``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f54c898a550 in __pthread_timedjoin_ex () from /lib64/libpthread.so.0 [Current thread is 1 (Thread 0x7f54cafad940 (LWP 2810860))] (gdb) bt #0 0x00007f54c898a550 in __pthread_timedjoin_ex () from /lib64/libpthread.so.0 apache#1 0x000055eb6a7ac513 in __gthread_join (__value_ptr=0x0, __threadid=<optimized out>) at /data/gcc-11.1.0/build/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu/bits/gthr-default.h:669 apache#2 std::thread::join (this=0x55eb6eda1ce0) at ../../../../../libstdc++-v3/src/c++11/thread.cc:112 apache#3 0x000055eb5cb548bb in ThreadPool::~ThreadPool (this=this@entry=0x7fff65768480) apache#4 0x000055eb5cb4aebe in JobManager::~JobManager (this=this@entry=0x7fff65768420) apache#5 0x000055eb5cb49a14 in main (argc=1, argv=<optimized out>) ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)