[fix](nereids) fix convert to date literal throw exception#48980
Merged
morrySnow merged 10 commits intoapache:masterfrom Mar 14, 2025
Merged
[fix](nereids) fix convert to date literal throw exception#48980morrySnow merged 10 commits intoapache:masterfrom
morrySnow merged 10 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Mar 12, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
This was referenced Mar 12, 2025
TPC-H: Total hot run time: 32406 ms |
TPC-DS: Total hot run time: 184930 ms |
ClickBench: Total hot run time: 31.27 s |
morrySnow
previously approved these changes
Mar 12, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 192457 ms |
ClickBench: Total hot run time: 30.84 s |
morrySnow
previously approved these changes
Mar 14, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
924060929
previously approved these changes
Mar 14, 2025
Contributor
Author
|
run buildall |
morrySnow
approved these changes
Mar 14, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 32327 ms |
924060929
approved these changes
Mar 14, 2025
TPC-DS: Total hot run time: 185153 ms |
ClickBench: Total hot run time: 31.17 s |
yiguolei
pushed a commit
that referenced
this pull request
Mar 15, 2025
dataroaring
pushed a commit
that referenced
this pull request
Mar 17, 2025
…#48980 (#48773) ### What problem does this PR solve? when nereids cast invalid date literal to date like type, it will throws exceptions: ``` select '' = cast('2020-10-20' as date); (1105, 'errCode = 2, detailMessage = date/datetime literal [] is invalid') ``` But old planner will not throw exceptions, so let neredis don't throw exceptions too. This PR is pick code from: #48980 ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
) ### What problem does this PR solve? when parse date literal failed, no throw DateTimeException, all throw AnalysisException. and for cast date literal met Exception, will skip parsing it, and give it to be for processing. Relate PR: apache#40202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when parse date literal failed, no throw DateTimeException, all throw AnalysisException. and for cast date literal met Exception, will skip parsing it, and give it to be for processing.
Relate PR: #40202
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)