[Fix](merge-on-write) should calculate delete bitmaps between segments before skip if tablet is in NOT_READY state in flush phase#48056
Merged
zhannngchen merged 2 commits intoapache:masterfrom Feb 19, 2025
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31769 ms |
TPC-DS: Total hot run time: 184031 ms |
ClickBench: Total hot run time: 30.25 s |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Feb 19, 2025
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Feb 19, 2025
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Feb 19, 2025
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) ### What problem does this PR solve? Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
Closed
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) ### What problem does this PR solve? Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
deardeng
pushed a commit
to deardeng/incubator-doris
that referenced
this pull request
Dec 19, 2025
…s between segmens before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) (apache#48089) (apache#334) pick apache#48056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
considering the following situation:
NOT_READYNOT_READYRUNNINGIf load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)