[fix](meta-service) Read recycle rowset key before removing when commit rowset#46657
Closed
gavinchou wants to merge 5 commits intoapache:masterfrom
Closed
[fix](meta-service) Read recycle rowset key before removing when commit rowset#46657gavinchou wants to merge 5 commits intoapache:masterfrom
gavinchou wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
w41ter
previously approved these changes
Jan 9, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
luwei16
approved these changes
Jan 10, 2025
…it rowset
Test case (hard to make it a regression)
```
mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'drop table if exists t1'
mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'CREATE TABLE t1 (id int, name text, score text) ENGINE=OLAP DUPLICATE KEY(id) DISTRIBUTED BY HASH(id) BUCKETS 1'
curl -XPOST "localhost:7211/api/update_config?disable_auto_compaction=true"
curl "localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=disable"
curl "localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=clear"
for i in $(seq 1 1 100); do
mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'insert into t1 values(1,1,1)'
done
curl "localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=apply_suite&name=sleep_before_execute_commit_rowset"
curl "localhost:6000/MetaService/http/v1/injection_point?token=greedisgood9999&op=enable"
curl -XPOST "localhost:7211/api/update_config?disable_auto_compaction=false"
sleep 60
instance_id=gavin_debug_instance_doris
tablet_id=$(mysql -h127.0.0.1 -P8952 -uroot -Ddb1 -e 'show tablets from t1;' | awk '{if (++n>1) print $1}')
curl "localhost:7211/api/compaction/show?tablet_id=${tablet_id}"
txn_id=$(curl -s "localhost:6000/MetaService/http/get_value?token=greedisgood9999&unicode&key_type=MetaRowsetKey&instance_id=${instance_id}&tablet_id=${tablet_id}&version=101" | jq ".txn_id" | tr -d '"')
curl -s "localhost:6000/MetaService/http/get_value?token=greedisgood9999&unicode&key_type=MetaRowsetTmpKey&instance_id=${instance_id}&tablet_id=${tablet_id}&txn_id=${txn_id}"
```
27c85a1 to
7dda53f
Compare
Contributor
Author
|
run buildall |
16 tasks
16 tasks
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR read recycle_rowset_key when commit_rowset, and it also fix some cloud UTs: loopaddr, recycler JVM memory, resource drop FE.
Related PR #45255 #46798
We should read the recycle_rowset_key before removing to make KV txn serializable.
Test case (hard to make it a regression)
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)