[fix](Nereids) fix cast string to date#46065
Merged
englefly merged 3 commits intoapache:masterfrom Dec 30, 2024
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
4dea898 to
8b451f1
Compare
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Dec 27, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32559 ms |
TPC-DS: Total hot run time: 196980 ms |
ClickBench: Total hot run time: 31.65 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32875 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32394 ms |
TPC-DS: Total hot run time: 197896 ms |
ClickBench: Total hot run time: 31.25 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32439 ms |
TPC-DS: Total hot run time: 190309 ms |
ClickBench: Total hot run time: 31.63 s |
Contributor
Author
|
run p0 |
yagagagaga
approved these changes
Dec 30, 2024
englefly
approved these changes
Dec 30, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
englefly
reviewed
Dec 30, 2024
| sb.append("20"); | ||
| } else if (year >= 70 && year <= 99) { | ||
| sb.append("19"); | ||
| if (s.charAt(j) == '.') { |
Contributor
There was a problem hiding this comment.
why "201.01.01" is year 2020, but "201-01-01" is year 201
Contributor
Author
There was a problem hiding this comment.
this behavior is align to mysql
englefly
approved these changes
Dec 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
### What problem does this PR solve? Issue Number: close #xxx Related PR: #35637 Problem Summary: When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01". 201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in
LiBinfeng-01
pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 7, 2025
Issue Number: close #xxx Related PR: apache#35637 Problem Summary: When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01". 201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in
16 tasks
LiBinfeng-01
pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 9, 2025
Issue Number: close #xxx Related PR: apache#35637 Problem Summary: When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01". 201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in
LiBinfeng-01
pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jan 9, 2025
Issue Number: close #xxx Related PR: apache#35637 Problem Summary: When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01". 201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in
morrySnow
pushed a commit
that referenced
this pull request
Jan 9, 2025
pick: #46065 Related PR: #35637 Problem Summary: When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01". 201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #35637
Problem Summary:
When cast("201-01-01" as datetimev2(0)), The result is "2020-01-01" but it is wrong. It should be result in "0201-01-01".
201 would be regarded as 20xy-0z as related pr show, it was a bug. But actually it should not have this trasformation and result in
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)