Skip to content

[pick](branch-3.0) pick #38185 #42059#45092

Merged
yiguolei merged 2 commits intoapache:branch-3.0from
xinyiZzz:branch-3.0_20241204_pick5
Dec 25, 2024
Merged

[pick](branch-3.0) pick #38185 #42059#45092
yiguolei merged 2 commits intoapache:branch-3.0from
xinyiZzz:branch-3.0_20241204_pick5

Conversation

@xinyiZzz
Copy link
Copy Markdown
Contributor

@xinyiZzz xinyiZzz commented Dec 6, 2024 •
edited
Loading

What problem does this PR solve?

pick
opt Modify thedefault JEMALLOC_CONF and support flush Jemalloc tcache #38185
opt Support Jemalloc heap profile start at runtime and automatically generate dot #42059

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@xinyiZzz
Copy link
Copy Markdown
Contributor Author

xinyiZzz commented Dec 6, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 6, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
[opt](memory) Support Jemalloc heap profile start at runtime and auto…
904596a 
…matically generate dot (apache#42059)
@xinyiZzz
[opt](memory) Modify thedefault JEMALLOC_CONF and support flush Jemal…
3ab28c8 
…loc tcache (apache#38185)

1. Modify thedefault JEMALLOC_CONF, reduce `muzzy_decay_ms` and
`dirty_decay_ms`, and modify the parameters of the regular dump heap
profile for better understanding.
2. support flush Jemalloc tcache, when process memory exceed limit and
tcache is larger than 1G, the limit of `tcache` is the number of pages,
not the total number of page bytes.
@xinyiZzz xinyiZzz force-pushed the branch-3.0_20241204_pick5 branch from 2bb3c1d to a3810f6 Compare December 16, 2024 03:39
@xinyiZzz xinyiZzz changed the title branch-3.0: [opt](memory) Support Jemalloc heap profile start at runtime and automatically generate dot #42059 [pick](branch-3.0) pick #38185 #42059 #45210 Dec 16, 2024
@xinyiZzz
Copy link
Copy Markdown
Contributor Author

xinyiZzz commented Dec 16, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Dec 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/src/runtime/memory/heap_profiler.cpp
@xinyiZzz xinyiZzz force-pushed the branch-3.0_20241204_pick5 branch from a3810f6 to 3ab28c8 Compare December 17, 2024 09:28
@xinyiZzz xinyiZzz changed the title [pick](branch-3.0) pick #38185 #42059 #45210 [pick](branch-3.0) pick #38185 #42059 Dec 17, 2024
@xinyiZzz
Copy link
Copy Markdown
Contributor Author

xinyiZzz commented Dec 17, 2024

run buildall

@yiguolei yiguolei merged commit 0ca6c38 into apache:branch-3.0 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinyiZzz @doris-robot @yiguolei