[fix](nereids) fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule#44725
Merged
924060929 merged 7 commits intoapache:masterfrom Nov 28, 2024
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Nov 28, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
morrySnow
previously approved these changes
Nov 28, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40027 ms |
TPC-DS: Total hot run time: 191415 ms |
ClickBench: Total hot run time: 32.72 s |
morrySnow
approved these changes
Nov 28, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Nov 30, 2024
…e wrong result because SimplifyArithmeticComparisonRule (apache#44725) fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule introduced by apache#25180 (cherry picked from commit 1ae91b8)
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Nov 30, 2024
…e wrong result because SimplifyArithmeticComparisonRule (apache#44725) fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule introduced by apache#25180 (cherry picked from commit 1ae91b8)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule
introduced by #25180
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)