Skip to content

[Opt](checker) Add checker for delete bitmaps#44154

Merged
dataroaring merged 4 commits intoapache:masterfrom
bobhan1:add-checker-for-delete-bitmaps
Dec 3, 2024
Merged

[Opt](checker) Add checker for delete bitmaps#44154
dataroaring merged 4 commits intoapache:masterfrom
bobhan1:add-checker-for-delete-bitmaps

Conversation

@bobhan1
Copy link
Copy Markdown
Contributor

@bobhan1 bobhan1 commented Nov 18, 2024 •
edited
Loading

What problem does this PR solve?

  1. check every delete bitmap in MS belongs to a visible rowset
  2. check that [improve](cloud-mow) merge and remove old version of delete bitmap when cumulative compaction is done #40204 works as expected

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from 0965abb to ff9a306 Compare November 18, 2024 05:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from ff9a306 to 88e307a Compare November 18, 2024 05:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from 88e307a to b0dde93 Compare November 18, 2024 06:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from b0dde93 to 9249d0b Compare November 18, 2024 06:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actions bot reviewed Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/src/recycler/checker.h
github-actions[bot]
github-actions bot reviewed Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/recycler_test.cpp Outdated
Comment thread cloud/test/recycler_test.cpp
@bobhan1 bobhan1 marked this pull request as ready for review November 18, 2024 11:24
github-actions[bot]
github-actions bot reviewed Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/recycler_test.cpp Outdated
Comment thread cloud/test/recycler_test.cpp
Comment thread cloud/test/recycler_test.cpp
zhannngchen
zhannngchen reviewed Nov 18, 2024
View reviewed changes
Comment thread cloud/src/recycler/checker.cpp Outdated
@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from c75596d to 9d2bf90 Compare November 19, 2024 02:28
github-actions[bot]
github-actions bot reviewed Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/recycler_test.cpp
github-actions[bot]
github-actions bot reviewed Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/recycler_test.cpp
github-actions[bot]
github-actions bot reviewed Nov 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/recycler_test.cpp
Comment thread cloud/test/recycler_test.cpp
Comment thread cloud/test/recycler_test.cpp
@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Nov 20, 2024

run buildall

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from e909939 to e7e8bbb Compare November 21, 2024 02:09
@dataroaring
Copy link
Copy Markdown
Contributor

dataroaring commented Nov 21, 2024

run buildall

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from e7e8bbb to 546799c Compare November 22, 2024 07:11
@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Nov 22, 2024

run buildall

@bobhan1 bobhan1 force-pushed the add-checker-for-delete-bitmaps branch from ead8ef3 to 47c6cb4 Compare November 25, 2024 08:24
@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Nov 25, 2024

run buildall

@dataroaring dataroaring force-pushed the add-checker-for-delete-bitmaps branch from 6c8adaa to 116a997 Compare December 3, 2024 02:51
@dataroaring
Copy link
Copy Markdown
Contributor

dataroaring commented Dec 3, 2024

run buildall

zhannngchen
zhannngchen approved these changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7a68d8f into apache:master Dec 3, 2024
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
@bobhan1
[Opt](checker) Add checker for delete bitmaps (#44154)
29c967f 
1. check every delete bitmap in MS belongs to a visible rowset
2. check that #40204 works as
expected
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 4, 2024
@github-actions @bobhan1
branch-3.0: [Opt](checker) Add checker for delete bitmaps #44154 (#44952
052b7f9 
)

Cherry-picked from #44154

Co-authored-by: bobhan1 <baohan@selectdb.com>
@mymeiyi mymeiyi mentioned this pull request Jun 12, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobhan1 @doris-robot @dataroaring @zhannngchen