Skip to content

[opt](brpc) check and remove unavailable brpc stubs (#43212)#43859

Merged
yiguolei merged 2 commits intoapache:branch-2.1from
mrhhsg:pick_43212
Nov 14, 2024
Merged

[opt](brpc) check and remove unavailable brpc stubs (#43212)#43859
yiguolei merged 2 commits intoapache:branch-2.1from
mrhhsg:pick_43212

Conversation

@mrhhsg
Copy link
Copy Markdown
Member

@mrhhsg mrhhsg commented Nov 13, 2024

What problem does this PR solve?

Pick from master: #43212

Related PR: #43212

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Nov 13, 2024

run buildall

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -19,6 +19,7 @@

#include <gen_cpp/PaloInternalService_types.h>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/PaloInternalService_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/PaloInternalService_types.h>
         ^

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Nov 13, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.32% (9480/26098)
Line Coverage: 27.88% (78076/280066)
Region Coverage: 26.52% (40029/150936)
Branch Coverage: 23.31% (20327/87210)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3adf314ca0a7b74223a5f7375183b6d3870a7dae_3adf314ca0a7b74223a5f7375183b6d3870a7dae/report/index.html

@yiguolei
Copy link
Copy Markdown
Contributor

run buildall

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Nov 14, 2024

run buildall

@yiguolei yiguolei merged commit 7fc78e3 into apache:branch-2.1 Nov 14, 2024
@mrhhsg mrhhsg deleted the pick_43212 branch December 2, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants