Skip to content

[fix](ngram bloomfilter) fix narrow conversion for ngram bf_size #43480#43654

Merged
airborne12 merged 1 commit intoapache:branch-2.1from
airborne12:pick_43480_to_origin_branch-2.1
Nov 12, 2024
Merged

[fix](ngram bloomfilter) fix narrow conversion for ngram bf_size #43480#43654
airborne12 merged 1 commit intoapache:branch-2.1from
airborne12:pick_43480_to_origin_branch-2.1

Conversation

@airborne12
Copy link
Copy Markdown
Member

@airborne12 airborne12 commented Nov 12, 2024

cherry pick from #43480

@airborne12
[fix](ngram bloomfilter) fix narrow conversion for ngram bf_size (apa…
3e71939 
…che#43480)

Problem Summary:
Fix ngram bloomfilter index coredump as below
```
*** SIGFPE integer divide by zero (@0x56294f026472) received by PID 4016941 (TID 4019213 OR 0x7f294eb4d640) from PID 1325556850; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at be/src/common/signal_handler.h:421
 1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in bin/jdk-17.0.2/lib/server/libjvm.so
 2# JVM_handle_linux_signal in bin/jdk-17.0.2/lib/server/libjvm.so
 3# 0x00007F3071042520 in /lib/x86_64-linux-gnu/libc.so.6
 4# doris::segment_v2::NGramBloomFilter::add_bytes(char const*, unsigned int) at be/src/olap/rowset/segment_v2/ngram_bloom_filter.cpp:61
 5# doris::ITokenExtractorHelper<doris::NgramTokenExtractor>::string_to_bloom_filter(char const*, unsigned long, doris::segment_v2::BloomFilter&) const at be/src/olap/itoken_extractor.h:61
 6# doris::segment_v2::NGramBloomFilterIndexWriterImpl::add_values(void const*, unsigned long) at be/src/olap/rowset/segment_v2/bloom_filter_index_writer.cpp:250
```

Co-authored-by: airborne12 <jiangkai@selectdb.com>
@airborne12
Copy link
Copy Markdown
Member Author

airborne12 commented Nov 12, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 12, 2024

TeamCity be ut coverage result:
Function Coverage: 36.33% (9476/26084)
Line Coverage: 27.88% (78032/279843)
Region Coverage: 26.54% (40017/150791)
Branch Coverage: 23.33% (20328/87144)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e7193996c2b3a50d06a2f5db6146e7df11575d5_3e7193996c2b3a50d06a2f5db6146e7df11575d5/report/index.html

@airborne12 airborne12 merged commit 3e098e1 into apache:branch-2.1 Nov 12, 2024
@airborne12 airborne12 deleted the pick_43480_to_origin_branch-2.1 branch November 12, 2024 08:54
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@airborne12 @doris-robot