[fix] (inverted index) Disallow variant columns from using inverted index format v1#43599
Merged
airborne12 merged 3 commits intoapache:masterfrom Nov 12, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 51945 ms |
eldenmoon
reviewed
Nov 11, 2024
fe/fe-core/src/main/java/org/apache/doris/analysis/IndexDef.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
eldenmoon
reviewed
Nov 12, 2024
eldenmoon
reviewed
Nov 12, 2024
fe/fe-core/src/main/java/org/apache/doris/analysis/IndexDef.java
Outdated
Show resolved
Hide resolved
eldenmoon
reviewed
Nov 12, 2024
...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/IndexDefinition.java
Outdated
Show resolved
Hide resolved
5cccd9c to
d7bd773
Compare
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Nov 13, 2024
…ndex format v1 (apache#43599) Problem Summary: 1. When the inverted index of a variant column uses storage format v1, schema changes can cause some segments to lack corresponding index files. 2. By using storage format v2 for inverted indexes, all indexes correspond to a single file, and the corresponding files will always exist regardless of whether the variant includes subcolumn indexes. When creating an inverted index for a variant column, file format v1 is not supported
py023
pushed a commit
to py023/doris
that referenced
this pull request
Nov 13, 2024
…ndex format v1 (apache#43599) ### What problem does this PR solve? Problem Summary: 1. When the inverted index of a variant column uses storage format v1, schema changes can cause some segments to lack corresponding index files. 2. By using storage format v2 for inverted indexes, all indexes correspond to a single file, and the corresponding files will always exist regardless of whether the variant includes subcolumn indexes. ### Release note When creating an inverted index for a variant column, file format v1 is not supported
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Dec 9, 2024
…ndex format v1 (apache#43599) Problem Summary: 1. When the inverted index of a variant column uses storage format v1, schema changes can cause some segments to lack corresponding index files. 2. By using storage format v2 for inverted indexes, all indexes correspond to a single file, and the corresponding files will always exist regardless of whether the variant includes subcolumn indexes. When creating an inverted index for a variant column, file format v1 is not supported
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Dec 9, 2024
…ndex format v1 (apache#43599) Problem Summary: 1. When the inverted index of a variant column uses storage format v1, schema changes can cause some segments to lack corresponding index files. 2. By using storage format v2 for inverted indexes, all indexes correspond to a single file, and the corresponding files will always exist regardless of whether the variant includes subcolumn indexes. When creating an inverted index for a variant column, file format v1 is not supported
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Dec 9, 2024
…ndex format v1 (apache#43599) Problem Summary: 1. When the inverted index of a variant column uses storage format v1, schema changes can cause some segments to lack corresponding index files. 2. By using storage format v2 for inverted indexes, all indexes correspond to a single file, and the corresponding files will always exist regardless of whether the variant includes subcolumn indexes. When creating an inverted index for a variant column, file format v1 is not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When the inverted index of a variant column uses storage format v1, schema changes can cause some segments to lack corresponding index files.
By using storage format v2 for inverted indexes, all indexes correspond to a single file, and the corresponding files will always exist regardless of whether the variant includes subcolumn indexes.
Release note
When creating an inverted index for a variant column, file format v1 is not supported
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)