Conversation
1 Fix typos in class name. 2 use correct return Status.
Support cgroup v2 for wokrload group.
## Proposed changes 1 Add a step to write pid to query path's cgroup.procs, otherwrise write thread id may failed. 2 Move some cgroup v2's public file to parent class to init init them once.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| static Status init_cgroup_v2_query_path_public_file(std::string home_path, | ||
| std::string query_path); | ||
|
|
||
| protected: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| protected: |
Additional context
be/src/agent/cgroup_cpu_ctl.h:60: previously declared here
protected:
^| inline static std::string _cgroup_v2_query_path_subtree_ctl_file = ""; | ||
| inline static std::string _doris_cg_v2_procs_file = ""; | ||
|
|
||
| protected: |
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
| protected: |
Additional context
be/src/agent/cgroup_cpu_ctl.h:60: previously declared here
protected:
^| } | ||
|
|
||
| void RuntimeQueryStatiticsMgr::report_runtime_query_statistics() { | ||
| void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() { |
There was a problem hiding this comment.
warning: function 'report_runtime_query_statistics' exceeds recommended size/complexity thresholds [readability-function-size]
void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
^Additional context
be/src/runtime/runtime_query_statistics_mgr.cpp:49: 117 lines including whitespace and comments (threshold 80)
void RuntimeQueryStatisticsMgr::report_runtime_query_statistics() {
^
|
TeamCity be ut coverage result: |
3 participants
Proposed changes
pick #39991 #39374 #36663