[improvement](mtmv) Support rewrite by materialized view when join has other join conjuncts by seawinde · Pull Request #41674 · apache/doris

seawinde · 2024-10-10T12:33:23Z

Proposed changes

Support rewrite by materialized view when join has other join conjuncts
Such as mv def is

            select l_orderkey, o_orderdate
            from
            lineitem
            inner join
            orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate
            inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

The query can be rewtritten by mv sucessfully when has not equal conjuncts in join
l_shipdate <= o_orderdate and ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

            select l_orderkey, o_orderdate
            from
            lineitem
            inner join
            orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate
            inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

doris-robot · 2024-10-10T12:33:29Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

seawinde · 2024-10-10T12:33:37Z

run buildall

seawinde · 2024-10-11T00:04:06Z

run buildall

seawinde · 2024-10-11T08:39:40Z

run buildall

seawinde · 2024-10-11T08:43:52Z

run buildall

zfr9527

Can the two "on" conditions exchange positions?
Can complex expressions be used?
If different tables have the same column names, is it still correct?
Case sensitivity of table/column names.
Can aggregate functions be used?
Does it support full build or partition build?
Combinations of different join types.

github-actions · 2024-10-14T09:50:29Z

PR approved by anyone and no changes requested.

…s other join conjuncts

seawinde · 2024-10-25T14:06:48Z

run buildall

seawinde · 2024-10-28T02:09:45Z

run buildall

github-actions · 2024-10-28T12:11:20Z

PR approved by at least one committer and no changes requested.

seawinde · 2024-10-28T13:42:02Z

run buildall

seawinde · 2024-10-29T08:55:38Z

run buildall

zfr9527

LGTM

github-actions · 2024-10-31T08:32:11Z

PR approved by at least one committer and no changes requested.

seawinde · 2024-10-31T08:43:49Z

run buildall

github-actions · 2024-11-06T04:10:33Z

PR approved by at least one committer and no changes requested.

…s other join conjuncts (#41674) Support rewrite by materialized view when join has other join conjuncts Such as mv def is select l_orderkey, o_orderdate from lineitem inner join orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty; The query can be rewtritten by mv sucessfully when has not equal conjuncts in join l_shipdate <= o_orderdate` and `ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty; select l_orderkey, o_orderdate from lineitem inner join orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

…s other join conjuncts (apache#41674) Support rewrite by materialized view when join has other join conjuncts Such as mv def is select l_orderkey, o_orderdate from lineitem inner join orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty; The query can be rewtritten by mv sucessfully when has not equal conjuncts in join l_shipdate <= o_orderdate` and `ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty; select l_orderkey, o_orderdate from lineitem inner join orders on l_orderkey = o_orderkey and l_shipdate <= o_orderdate inner join partsupp on ps_partkey = l_partkey and l_orderkey + o_orderkey != ps_availqty;

pick from master commit id 6fdc8a5 PR #41674 commit id 7c45912 PR #43095 commit id 7aec6ff PR #44164

zfr9527 approved these changes Oct 14, 2024

View reviewed changes

github-actions bot added the reviewed label Oct 14, 2024

seawinde added 5 commits October 24, 2024 17:53

add some test

0ba794d

[improvement](mtmv) Support rewrite by materialized view when join ha…

6a2a02d

…s other join conjuncts

fix test

add1f6b

add regression test

f1f1224

modify test

b9b70b3

seawinde force-pushed the support_other_conjuncts_in_join branch from 9e0b44a to b9b70b3 Compare October 24, 2024 09:55

fix regression comment

9d1b400

fix regression test

4bee7e0

morrySnow previously approved these changes Oct 28, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 28, 2024

fix random not hint

82c54a7

seawinde dismissed morrySnow’s stale review via 82c54a7 October 28, 2024 13:41

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 28, 2024

fix permutation wrong and add test

855aa83

zfr9527 approved these changes Oct 29, 2024

View reviewed changes

morrySnow previously approved these changes Oct 31, 2024

View reviewed changes

morrySnow added the dev/2.1.x label Oct 31, 2024

morrySnow added dev/3.0.x and removed dev/2.1.x labels Oct 31, 2024

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2024

fix license

1ed5bba

seawinde dismissed morrySnow’s stale review via 1ed5bba October 31, 2024 08:43

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 31, 2024

morrySnow approved these changes Nov 6, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024

morrySnow merged commit 6fdc8a5 into apache:master Nov 6, 2024

github-actions bot mentioned this pull request Nov 6, 2024

branch-3.0: [improvement](mtmv) Support rewrite by materialized view when join has other join conjuncts #43308

Closed

seawinde mentioned this pull request Nov 19, 2024

Pick some pr to branch 3.0 #41674 #43095 #44164 #44290

Merged

16 tasks

morrySnow pushed a commit that referenced this pull request Nov 22, 2024

[pick](mtmv) Pick some pr to branch 3.0 #41674 #43095 #44164 (#44290)

eeda1ce

pick from master commit id 6fdc8a5 PR #41674 commit id 7c45912 PR #43095 commit id 7aec6ff PR #44164

morrySnow added dev/3.0.3-merged and removed dev/3.0.x labels Nov 22, 2024

Conversation

seawinde commented Oct 10, 2024

Proposed changes

Uh oh!

doris-robot commented Oct 10, 2024

Uh oh!

seawinde commented Oct 10, 2024

Uh oh!

seawinde commented Oct 11, 2024

Uh oh!

seawinde commented Oct 11, 2024

Uh oh!

seawinde commented Oct 11, 2024

Uh oh!

zfr9527 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 14, 2024

Uh oh!

seawinde commented Oct 25, 2024

Uh oh!

seawinde commented Oct 28, 2024

Uh oh!

github-actions bot commented Oct 28, 2024

Uh oh!

seawinde commented Oct 28, 2024

Uh oh!

seawinde commented Oct 29, 2024

Uh oh!

zfr9527 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 31, 2024

Uh oh!

seawinde commented Oct 31, 2024

Uh oh!

github-actions bot commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants