[chore](file-cache) Enable file cache for cloud mode by force#41357
Merged
hello-stephen merged 1 commit intoapache:masterfrom Sep 29, 2024
Merged
[chore](file-cache) Enable file cache for cloud mode by force#41357hello-stephen merged 1 commit intoapache:masterfrom
hello-stephen merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Hastyshell
force-pushed
the
fix-cloud-sc-filecache
branch
from
c303196 to
5f68ebe
Compare
github-actions
bot
removed
the
approved
Collaborator
Author
|
run buildall |
TPC-H: Total hot run time: 40821 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 191680 ms |
ClickBench: Total hot run time: 33.22 s |
| // In cloud mode, this branch implies it is an intermediate rowset for external merge sort, | ||
| // we use `global_local_filesystem` to write data to `tmp_file_dir`(see `local_segment_path`). | ||
| _context.tablet_path = io::FileCacheFactory::instance()->get_cache_path(); | ||
| if (auto maybe_cache_path = io::FileCacheFactory::instance()->get_cache_path(); |
Contributor
There was a problem hiding this comment.
so cache path will be used even if enable_file_cache = false ? This will increase user's cognitive load somehow. A new path should be used in my opinion.
FYI, with more Cache Storage being added to Doris, disk file system is not the only place for cached data, e.g. system RAM for Memory-based Cache Storage. In this case, cache path will have value but not a directory.
Collaborator
Author
There was a problem hiding this comment.
We enable file cache by false after duscussion. As for the availability of cache path, currently every cache has a working disk path. If mem cache is introduced, we should modify the implementation of FileCacheFactory then.
Hastyshell
force-pushed
the
fix-cloud-sc-filecache
branch
5 times, most recently
from
6cd5504 to
4887f68
Compare
Hastyshell
changed the title
Collaborator
Author
|
run buildall |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Hastyshell
force-pushed
the
fix-cloud-sc-filecache
branch
from
4887f68 to
8f160b7
Compare
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 40906 ms |
TPC-DS: Total hot run time: 192204 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.46 s |
Hastyshell
force-pushed
the
fix-cloud-sc-filecache
branch
from
8f160b7 to
cb4840c
Compare
Collaborator
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Hastyshell
force-pushed
the
fix-cloud-sc-filecache
branch
from
cb4840c to
fda89e2
Compare
Collaborator
Author
|
run buildall |
TPC-H: Total hot run time: 40878 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192183 ms |
ClickBench: Total hot run time: 32.81 s |
Collaborator
Author
|
run external |
gavinchou
approved these changes
Sep 29, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
cjj2010
pushed a commit
to cjj2010/doris
that referenced
this pull request
Oct 12, 2024
…#41357) ## Proposed changes Temp local rowset writer for external sorting replies on file cache.
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Oct 12, 2024
…#41357) ## Proposed changes Temp local rowset writer for external sorting replies on file cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Temp local rowset writer for external sorting replies on file cache.