[bugfix](hive)Fix cache inconsistency issue#40729
Merged
morningman merged 4 commits intoapache:masterfrom Sep 18, 2024
Merged
Conversation
wuwenchi
force-pushed
the
fix-hms-cache-consist
branch
from
de5bd4e to
da56e9b
Compare
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40497 ms |
TPC-DS: Total hot run time: 194513 ms |
ClickBench: Total hot run time: 31.18 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42682 ms |
TPC-DS: Total hot run time: 199911 ms |
ClickBench: Total hot run time: 31.32 s |
morningman
reviewed
Sep 14, 2024
Contributor
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
Please add FE UT for invalidateTableCache()
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41767 ms |
TPC-DS: Total hot run time: 197751 ms |
ClickBench: Total hot run time: 31.73 s |
Contributor
Author
|
run feut |
Contributor
Author
|
run p0 |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
suxiaogang223
approved these changes
Sep 18, 2024
CalvinKirs
approved these changes
Sep 18, 2024
wuwenchi
added a commit
to wuwenchi/doris
that referenced
this pull request
Sep 20, 2024
## Proposed changes 1. Concurrency issues: a. One thread is performing a refresh catalog action. b. One thread is performing an insert table action, and after completion, it executes a refresh table action. The `partitionCache` will be refreshed only if the corresponding table exists in the `partitionValuesCache`. However, the `partitionValuesCache` may have been refreshed by the `refresh catalog`, resulting in the inability to find the corresponding table through the `partitionValuesCache`, resulting in the `partitionCache` not being refreshed. Similarly, the `fileCacheRef` may not be refreshed either. Therefore, directly search for all keys to match to prevent them from being refreshed. 2. No need to perform refreshAfterWriteSec operation on partitionCache. 3. Increase the thread pool size.
morningman
pushed a commit
that referenced
this pull request
Sep 20, 2024
dataroaring
pushed a commit
that referenced
this pull request
Sep 29, 2024
## Proposed changes 1. Concurrency issues: a. One thread is performing a refresh catalog action. b. One thread is performing an insert table action, and after completion, it executes a refresh table action. The `partitionCache` will be refreshed only if the corresponding table exists in the `partitionValuesCache`. However, the `partitionValuesCache` may have been refreshed by the `refresh catalog`, resulting in the inability to find the corresponding table through the `partitionValuesCache`, resulting in the `partitionCache` not being refreshed. Similarly, the `fileCacheRef` may not be refreshed either. Therefore, directly search for all keys to match to prevent them from being refreshed. 2. No need to perform refreshAfterWriteSec operation on partitionCache. 3. Increase the thread pool size.
dataroaring
added
dev/3.0.2-merged
dev/2.1.7-merged
and removed
dev/2.1.7-merged
dev/3.0.x
labels
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
a. One thread is performing a refresh catalog action.
b. One thread is performing an insert table action, and after completion, it executes a refresh table action.
The
partitionCachewill be refreshed only if the corresponding table exists in thepartitionValuesCache. However, thepartitionValuesCachemay have been refreshed by therefresh catalog, resulting in the inability to find the corresponding table through thepartitionValuesCache, resulting in thepartitionCachenot being refreshed.Similarly, the
fileCacheRefmay not be refreshed either.Therefore, directly search for all keys to match to prevent them from being refreshed.