[fix](cloud-mow) Add retry when calculating delete bitmap timeout when loading data#40562
Merged
dataroaring merged 10 commits intoapache:masterfrom Sep 19, 2024
Merged
[fix](cloud-mow) Add retry when calculating delete bitmap timeout when loading data#40562dataroaring merged 10 commits intoapache:masterfrom
dataroaring merged 10 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38123 ms |
TPC-DS: Total hot run time: 192142 ms |
ClickBench: Total hot run time: 31.24 s |
hust-hhb
force-pushed
the
broker-retry
branch
from
86efeaf to
a2fa675
Compare
hust-hhb
changed the title
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38292 ms |
TPC-DS: Total hot run time: 197246 ms |
ClickBench: Total hot run time: 31.82 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38366 ms |
TPC-DS: Total hot run time: 192739 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.38 s |
dataroaring
reviewed
Sep 14, 2024
| dbId, tableList, transactionId, commitInfos, getLoadJobFinalOperation()); | ||
| afterLoadingTaskCommitTransaction(tableList); | ||
| afterCommit(); | ||
| finishJob = true; |
Contributor
There was a problem hiding this comment.
just break instead of using finishJob.
Suggested change
| finishJob = true; | |
| finishJob = true; |
Contributor
Author
There was a problem hiding this comment.
use return instead of break, unlock table will do in finally code before return
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 43493 ms |
TPC-DS: Total hot run time: 195605 ms |
ClickBench: Total hot run time: 31.53 s |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
zhannngchen
reviewed
Sep 19, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41265 ms |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
dataroaring
pushed a commit
that referenced
this pull request
Sep 19, 2024
…n loading data (#40562) Add retry when calculating delete bitmap timeout on broker load , like stream load doing.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry when calculating delete bitmap timeout on broker load , like stream load doing.