[fix](funcs) map struct construct funcs #39699#40502
[fix](funcs) map struct construct funcs #39699#40502xiaokang merged 4 commits intoapache:branch-2.0from
Conversation
we should not change the column which is passed from a block when we execute a function , because this block may be used in other expression or other exec node
|
run buildall |
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | ||
| size_t result, size_t input_rows_count) override = 0; | ||
| /// Notice: We should not change the column in the block, because the column may be shared by multiple expressions or exec nodes. | ||
| virtual Status execute_impl(FunctionContext* context, Block& block, |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual Status execute_impl(FunctionContext* context, Block& block, | |
| Status execute_impl(FunctionContext* context, Block& block, |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 49109 ms |
TPC-DS: Total hot run time: 211885 ms |
ClickBench: Total hot run time: 30.22 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
TPC-H: Total hot run time: 48858 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 213090 ms |
ClickBench: Total hot run time: 31.11 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
TPC-H: Total hot run time: 49279 ms |
TPC-DS: Total hot run time: 214588 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.7 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
cherry pick from #39699