Skip to content

[fix](cloud-schema-change) Exclude merged dropped columns from projection columns#40187

Merged
dataroaring merged 2 commits intoapache:masterfrom
Hastyshell:fix-cloud-sc-proj-cols
Sep 5, 2024
Merged

[fix](cloud-schema-change) Exclude merged dropped columns from projection columns#40187
dataroaring merged 2 commits intoapache:masterfrom
Hastyshell:fix-cloud-sc-proj-cols

Conversation

@Hastyshell
Copy link
Copy Markdown
Collaborator

@Hastyshell Hastyshell commented Aug 30, 2024

Proposed changes

schema change in cloud mode used to merge dropped columns from delete predicates to projection columns when reading data from base tablet, resulted in failure when reading rowsets after columns dropped.

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Hastyshell Hastyshell force-pushed the fix-cloud-sc-proj-cols branch from 0da127b to 330837e Compare August 30, 2024 08:25
@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Aug 30, 2024

run buildall

@Hastyshell Hastyshell marked this pull request as ready for review August 30, 2024 08:25
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 30, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

TPC-H: Total hot run time: 39572 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 330837eb0925d6c2480c7565a022df6b56a59c8c, data reload: false

------ Round 1 ----------------------------------
q1	17667	5010	4641	4641
q2	2556	186	186	186
q3	12034	1004	1218	1004
q4	10520	767	765	765
q5	7710	2926	2878	2878
q6	233	139	141	139
q7	980	628	607	607
q8	10477	2127	2100	2100
q9	7498	6659	6640	6640
q10	7070	2307	2298	2298
q11	458	245	244	244
q12	402	229	232	229
q13	17848	3231	3251	3231
q14	307	239	245	239
q15	568	526	509	509
q16	640	526	516	516
q17	1006	752	736	736
q18	8793	7495	7035	7035
q19	2177	1056	1041	1041
q20	709	350	345	345
q21	4223	3342	3180	3180
q22	1091	1031	1009	1009
Total cold run time: 114967 ms
Total hot run time: 39572 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4579	4419	4324	4324
q2	385	286	269	269
q3	2935	2700	2834	2700
q4	2083	1793	1784	1784
q5	5762	5712	5617	5617
q6	239	144	138	138
q7	2253	1827	1847	1827
q8	3377	3501	3477	3477
q9	8887	8894	8980	8894
q10	3660	3336	3454	3336
q11	592	524	514	514
q12	813	636	641	636
q13	17201	3259	3223	3223
q14	320	286	289	286
q15	559	494	501	494
q16	651	576	589	576
q17	1932	1579	1548	1548
q18	8436	7989	8003	7989
q19	1775	1591	1508	1508
q20	2253	1928	1928	1928
q21	5897	5607	5257	5257
q22	1163	1079	1037	1037
Total cold run time: 75752 ms
Total hot run time: 57362 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

TPC-DS: Total hot run time: 193713 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 330837eb0925d6c2480c7565a022df6b56a59c8c, data reload: false

query1	1260	881	862	862
query2	6440	1953	1933	1933
query3	10620	4141	3965	3965
query4	59134	24818	23307	23307
query5	5365	522	497	497
query6	414	159	169	159
query7	5781	295	303	295
query8	294	204	203	203
query9	9223	2479	2467	2467
query10	495	274	262	262
query11	18271	15203	15231	15203
query12	149	103	102	102
query13	1580	389	391	389
query14	11241	7741	7844	7741
query15	301	188	175	175
query16	7567	463	428	428
query17	1293	597	609	597
query18	2017	315	317	315
query19	296	158	151	151
query20	118	115	114	114
query21	207	106	107	106
query22	4758	4389	4414	4389
query23	34453	33428	33423	33423
query24	6054	2903	2926	2903
query25	546	395	397	395
query26	693	160	162	160
query27	1778	293	281	281
query28	3907	2118	2121	2118
query29	727	435	428	428
query30	337	155	159	155
query31	954	770	765	765
query32	91	57	61	57
query33	456	290	290	290
query34	877	492	480	480
query35	850	753	731	731
query36	1066	941	927	927
query37	151	97	95	95
query38	3994	3863	3837	3837
query39	1474	1392	1371	1371
query40	206	121	119	119
query41	48	47	47	47
query42	116	94	97	94
query43	521	478	487	478
query44	1144	754	759	754
query45	198	169	168	168
query46	1100	774	756	756
query47	1883	1774	1821	1774
query48	376	312	307	307
query49	787	441	457	441
query50	840	427	440	427
query51	7254	6985	7127	6985
query52	99	89	90	89
query53	248	189	184	184
query54	578	459	462	459
query55	77	81	77	77
query56	292	278	264	264
query57	1220	1075	1085	1075
query58	229	236	245	236
query59	3014	2907	2756	2756
query60	305	277	276	276
query61	126	123	119	119
query62	763	633	658	633
query63	217	186	188	186
query64	2870	818	691	691
query65	3232	3159	3164	3159
query66	625	346	339	339
query67	15444	15385	15136	15136
query68	4451	562	550	550
query69	429	279	295	279
query70	1205	1072	1129	1072
query71	354	285	279	279
query72	6578	4123	3983	3983
query73	779	329	330	329
query74	9338	8859	8998	8859
query75	3372	2633	2703	2633
query76	1838	900	992	900
query77	565	359	344	344
query78	9669	9057	9014	9014
query79	1092	541	540	540
query80	879	528	514	514
query81	575	236	238	236
query82	246	157	148	148
query83	205	147	150	147
query84	260	73	73	73
query85	919	291	322	291
query86	416	306	307	306
query87	4459	4292	4425	4292
query88	3279	2328	2323	2323
query89	399	279	292	279
query90	1918	202	196	196
query91	119	101	101	101
query92	63	49	53	49
query93	1808	529	532	529
query94	850	289	276	276
query95	356	268	270	268
query96	601	273	269	269
query97	3172	3087	3054	3054
query98	215	203	202	202
query99	1583	1290	1273	1273
Total cold run time: 311036 ms
Total hot run time: 193713 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

ClickBench: Total hot run time: 32.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 330837eb0925d6c2480c7565a022df6b56a59c8c, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.49	0.48	0.48
query6	1.13	0.73	0.71
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.47	0.48
query10	0.55	0.54	0.55
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.58	0.58
query14	2.03	2.08	2.07
query15	0.88	0.83	0.82
query16	0.38	0.37	0.38
query17	1.05	0.98	1.03
query18	0.20	0.21	0.19
query19	1.83	1.82	1.74
query20	0.01	0.01	0.02
query21	15.40	0.68	0.67
query22	4.51	6.69	2.31
query23	18.26	1.26	1.23
query24	2.05	0.23	0.22
query25	0.16	0.09	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.31	1.02	0.99
query29	12.64	3.33	3.27
query30	0.24	0.06	0.05
query31	2.88	0.40	0.38
query32	3.26	0.49	0.47
query33	2.98	2.97	3.02
query34	17.16	4.42	4.44
query35	4.43	4.46	4.44
query36	0.66	0.48	0.47
query37	0.19	0.16	0.15
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.04
Total cold run time: 111.1 s
Total hot run time: 32.26 s

@Hastyshell Hastyshell added the area/schema-change Issues or PRs related to schema change label Aug 30, 2024
@Hastyshell Hastyshell force-pushed the fix-cloud-sc-proj-cols branch from 330837e to d778e76 Compare August 30, 2024 12:56
@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Aug 30, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

TPC-H: Total hot run time: 38042 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d778e761ff53231b15dd3e1f149456a2cb5bac87, data reload: false

------ Round 1 ----------------------------------
q1	18408	4410	4346	4346
q2	2021	182	172	172
q3	11845	963	1117	963
q4	10481	724	754	724
q5	7761	2889	2847	2847
q6	228	143	137	137
q7	960	611	591	591
q8	9526	2116	2074	2074
q9	7323	6594	6609	6594
q10	7108	2304	2240	2240
q11	478	251	244	244
q12	401	234	225	225
q13	18968	3150	3099	3099
q14	283	262	240	240
q15	519	515	490	490
q16	1374	520	541	520
q17	1358	706	677	677
q18	8110	6791	6791	6791
q19	1575	1099	1099	1099
q20	712	333	317	317
q21	3984	2736	2658	2658
q22	1111	994	1006	994
Total cold run time: 114534 ms
Total hot run time: 38042 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4344	4290	4287	4287
q2	377	280	276	276
q3	2899	2697	2694	2694
q4	1911	1686	1697	1686
q5	5687	5657	5704	5657
q6	220	133	131	131
q7	2245	1778	1791	1778
q8	3299	3495	3443	3443
q9	8827	8692	8743	8692
q10	3657	3407	3291	3291
q11	599	508	499	499
q12	830	682	670	670
q13	15279	3077	3246	3077
q14	332	279	290	279
q15	537	479	495	479
q16	619	593	580	580
q17	1824	1537	1511	1511
q18	8085	7772	8008	7772
q19	1733	1469	1658	1469
q20	2143	1905	1872	1872
q21	5797	5569	5593	5569
q22	1121	1044	1041	1041
Total cold run time: 72365 ms
Total hot run time: 56753 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

TPC-DS: Total hot run time: 192319 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d778e761ff53231b15dd3e1f149456a2cb5bac87, data reload: false

query1	1273	874	872	872
query2	6309	2013	1977	1977
query3	10578	4000	3795	3795
query4	60348	26280	23184	23184
query5	5605	495	489	489
query6	420	168	192	168
query7	5824	290	291	290
query8	282	207	206	206
query9	8851	2460	2472	2460
query10	464	270	264	264
query11	17428	15132	15662	15132
query12	154	105	104	104
query13	1505	411	389	389
query14	11049	6958	6775	6775
query15	226	184	179	179
query16	7546	473	486	473
query17	1181	588	559	559
query18	1955	300	285	285
query19	289	150	150	150
query20	115	117	114	114
query21	210	110	107	107
query22	4739	4604	4389	4389
query23	34438	33581	33546	33546
query24	5837	2831	2819	2819
query25	552	379	395	379
query26	693	159	154	154
query27	1770	288	272	272
query28	3731	2108	2091	2091
query29	690	404	416	404
query30	233	158	155	155
query31	937	753	777	753
query32	83	53	57	53
query33	423	287	273	273
query34	871	480	488	480
query35	824	707	701	701
query36	1057	914	925	914
query37	140	91	88	88
query38	3954	3916	3873	3873
query39	1419	1516	1399	1399
query40	211	122	117	117
query41	50	46	44	44
query42	117	100	99	99
query43	522	481	482	481
query44	1084	747	757	747
query45	205	172	162	162
query46	1091	771	752	752
query47	1918	1770	1832	1770
query48	367	339	285	285
query49	762	426	423	423
query50	800	419	410	410
query51	7212	7166	7041	7041
query52	102	87	95	87
query53	251	177	177	177
query54	567	455	451	451
query55	82	75	76	75
query56	268	253	257	253
query57	1192	1088	1084	1084
query58	219	219	226	219
query59	3134	2850	2848	2848
query60	291	268	268	268
query61	104	99	103	99
query62	751	669	652	652
query63	212	183	190	183
query64	2829	685	669	669
query65	3238	3186	3135	3135
query66	636	337	355	337
query67	15370	15149	15096	15096
query68	2878	581	583	581
query69	401	288	284	284
query70	1206	1138	1116	1116
query71	340	274	283	274
query72	5392	4083	3973	3973
query73	738	334	341	334
query74	9134	8848	8851	8848
query75	3333	2658	2744	2658
query76	1433	936	996	936
query77	562	329	331	329
query78	9601	9048	9109	9048
query79	1047	540	531	531
query80	698	511	493	493
query81	467	240	236	236
query82	250	151	144	144
query83	168	147	150	147
query84	261	74	74	74
query85	675	282	279	279
query86	300	274	296	274
query87	4415	4295	4269	4269
query88	2903	2305	2406	2305
query89	394	280	286	280
query90	2020	197	190	190
query91	121	101	99	99
query92	63	50	53	50
query93	1055	535	540	535
query94	706	297	364	297
query95	349	256	253	253
query96	587	260	261	260
query97	3170	3062	3056	3056
query98	211	204	200	200
query99	1525	1287	1290	1287
Total cold run time: 303991 ms
Total hot run time: 192319 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 30, 2024

ClickBench: Total hot run time: 32.14 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d778e761ff53231b15dd3e1f149456a2cb5bac87, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.07	0.07
query5	0.51	0.50	0.50
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.06	0.04	0.05
query9	0.56	0.48	0.48
query10	0.55	0.54	0.54
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.61	0.58	0.59
query14	2.04	2.07	2.08
query15	0.89	0.81	0.82
query16	0.38	0.37	0.40
query17	1.03	1.06	1.06
query18	0.22	0.20	0.20
query19	1.96	1.79	1.84
query20	0.01	0.01	0.01
query21	15.40	0.66	0.64
query22	4.36	7.36	2.06
query23	18.26	1.33	1.30
query24	2.06	0.22	0.22
query25	0.14	0.09	0.08
query26	0.28	0.17	0.18
query27	0.08	0.08	0.07
query28	13.26	1.02	1.00
query29	12.62	3.29	3.30
query30	0.25	0.06	0.06
query31	2.90	0.41	0.40
query32	3.23	0.48	0.47
query33	2.98	2.94	3.00
query34	17.16	4.36	4.39
query35	4.47	4.45	4.42
query36	0.67	0.48	0.47
query37	0.17	0.15	0.15
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.15	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.12 s
Total hot run time: 32.14 s

@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Sep 5, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 5, 2024

TPC-H: Total hot run time: 38064 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bf5b463931d1939fc17f047bf7f607cb816bb6e4, data reload: false

------ Round 1 ----------------------------------
q1	17609	4431	4300	4300
q2	2013	181	173	173
q3	11695	896	1125	896
q4	10519	748	667	667
q5	7713	2853	2787	2787
q6	230	138	138	138
q7	953	628	601	601
q8	9516	2083	2097	2083
q9	7251	6547	6554	6547
q10	7015	2198	2235	2198
q11	438	242	249	242
q12	407	222	227	222
q13	18607	3069	3098	3069
q14	281	237	230	230
q15	539	495	488	488
q16	598	510	511	510
q17	989	726	698	698
q18	7447	6854	6940	6854
q19	1396	1014	1077	1014
q20	678	332	324	324
q21	4442	3140	3029	3029
q22	1114	994	997	994
Total cold run time: 111450 ms
Total hot run time: 38064 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4388	4291	4292	4291
q2	376	273	273	273
q3	2912	2681	2702	2681
q4	1917	1643	1625	1625
q5	5672	5634	5749	5634
q6	233	132	133	132
q7	2216	1831	1829	1829
q8	3363	3420	3438	3420
q9	8843	8843	8930	8843
q10	3641	3352	3351	3351
q11	604	508	512	508
q12	812	661	677	661
q13	13966	3238	3228	3228
q14	328	303	284	284
q15	549	501	490	490
q16	630	601	599	599
q17	1841	1553	1550	1550
q18	8040	7874	7861	7861
q19	1727	1702	1496	1496
q20	2228	1882	1942	1882
q21	5850	5444	5465	5444
q22	1130	1088	1061	1061
Total cold run time: 71266 ms
Total hot run time: 57143 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 5, 2024

TeamCity be ut coverage result:
Function Coverage: 36.84% (9393/25497)
Line Coverage: 28.28% (77457/273917)
Region Coverage: 27.67% (39965/144439)
Branch Coverage: 24.31% (20333/83646)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bf5b463931d1939fc17f047bf7f607cb816bb6e4_bf5b463931d1939fc17f047bf7f607cb816bb6e4/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 5, 2024

TPC-DS: Total hot run time: 192930 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bf5b463931d1939fc17f047bf7f607cb816bb6e4, data reload: false

query1	1245	926	872	872
query2	6431	1956	1921	1921
query3	10616	4024	4001	4001
query4	59584	24199	23370	23370
query5	5320	501	494	494
query6	395	166	161	161
query7	5772	284	286	284
query8	279	203	210	203
query9	8820	2521	2490	2490
query10	472	270	253	253
query11	18161	14967	15314	14967
query12	152	104	104	104
query13	1588	392	384	384
query14	11093	6828	7039	6828
query15	251	178	189	178
query16	7561	506	451	451
query17	1149	564	564	564
query18	2046	288	292	288
query19	300	144	142	142
query20	120	106	117	106
query21	205	106	106	106
query22	4719	4459	4485	4459
query23	34568	33640	33463	33463
query24	5952	2867	2829	2829
query25	534	402	376	376
query26	688	154	149	149
query27	1791	282	282	282
query28	3693	2057	2044	2044
query29	679	409	432	409
query30	232	154	153	153
query31	952	773	765	765
query32	78	51	52	51
query33	492	285	276	276
query34	880	478	488	478
query35	842	738	710	710
query36	1065	946	927	927
query37	149	94	95	94
query38	4010	3917	3919	3917
query39	1468	1404	1388	1388
query40	202	119	116	116
query41	47	46	46	46
query42	118	95	95	95
query43	525	484	467	467
query44	1106	745	746	745
query45	201	170	171	170
query46	1105	741	767	741
query47	1951	1850	1821	1821
query48	377	310	314	310
query49	769	430	455	430
query50	834	416	405	405
query51	7089	6895	6950	6895
query52	101	86	89	86
query53	254	177	180	177
query54	573	478	467	467
query55	76	73	77	73
query56	285	275	256	256
query57	1220	1073	1071	1071
query58	241	242	239	239
query59	3033	2840	2810	2810
query60	296	281	281	281
query61	126	122	121	121
query62	770	660	661	660
query63	211	181	183	181
query64	2908	758	804	758
query65	3201	3164	3169	3164
query66	667	333	329	329
query67	15504	15307	15506	15307
query68	3450	582	573	573
query69	392	287	274	274
query70	1182	1109	1122	1109
query71	359	273	276	273
query72	6327	4012	4025	4012
query73	762	331	323	323
query74	9204	8996	9023	8996
query75	3338	2703	2714	2703
query76	1475	986	1020	986
query77	584	318	317	317
query78	9759	9792	9059	9059
query79	1094	547	522	522
query80	789	509	507	507
query81	551	239	235	235
query82	439	147	139	139
query83	166	146	146	146
query84	268	73	79	73
query85	833	337	284	284
query86	329	297	290	290
query87	4419	4190	4288	4190
query88	3037	2362	2325	2325
query89	392	288	280	280
query90	1877	184	181	181
query91	121	97	100	97
query92	62	50	47	47
query93	1117	529	531	529
query94	797	279	291	279
query95	343	252	243	243
query96	590	270	271	270
query97	3198	3060	3078	3060
query98	219	217	200	200
query99	1603	1258	1250	1250
Total cold run time: 307218 ms
Total hot run time: 192930 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 5, 2024

ClickBench: Total hot run time: 32.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf5b463931d1939fc17f047bf7f607cb816bb6e4, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.05	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.50	0.49	0.49
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.56	0.50	0.49
query10	0.54	0.53	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.58
query14	2.03	2.06	2.14
query15	0.93	0.82	0.82
query16	0.36	0.37	0.37
query17	1.07	1.04	1.04
query18	0.21	0.20	0.20
query19	1.85	1.80	1.77
query20	0.01	0.02	0.01
query21	15.44	0.66	0.65
query22	4.50	7.13	2.21
query23	18.31	1.39	1.20
query24	2.11	0.24	0.21
query25	0.15	0.08	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.27	1.03	1.00
query29	12.60	3.32	3.31
query30	0.24	0.05	0.05
query31	2.91	0.40	0.40
query32	3.22	0.48	0.48
query33	2.96	3.02	2.99
query34	17.06	4.37	4.39
query35	4.46	4.43	4.50
query36	0.66	0.48	0.50
query37	0.19	0.15	0.16
query38	0.16	0.14	0.14
query39	0.04	0.04	0.03
query40	0.16	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.19 s
Total hot run time: 32.29 s

dataroaring
dataroaring approved these changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1cde2d2 into apache:master Sep 5, 2024
gavinchou pushed a commit that referenced this pull request Sep 10, 2024
@Hastyshell @gavinchou
[fix](cloud-schema-change) Exclude merged dropped columns from projec…
a284feb 
…tion columns (#40187)

## Proposed changes

schema change in cloud mode used to merge dropped columns from delete
predicates to projection columns when reading data from base tablet,
resulted in failure when reading rowsets after columns dropped.
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@luwei16 luwei16 luwei16 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/schema-change Issues or PRs related to schema change dev/3.0.2-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hastyshell @doris-robot @gavinchou @luwei16 @dataroaring