[refactor](pipeline) Refactor pipeline execution#39982
Merged
Gabriel39 merged 4 commits intoapache:masterfrom Sep 6, 2024
Merged
[refactor](pipeline) Refactor pipeline execution#39982Gabriel39 merged 4 commits intoapache:masterfrom
Gabriel39 merged 4 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Status AnalyticSinkOperatorX::prepare(RuntimeState* state) { | ||
| Status AnalyticSinkOperatorX::open(RuntimeState* state) { |
Contributor
There was a problem hiding this comment.
warning: method 'open' can be made const [readability-make-member-function-const]
Suggested change
| Status AnalyticSinkOperatorX::open(RuntimeState* state) { | |
| Status AnalyticSinkOperatorX::open(RuntimeState* state) const { |
be/src/pipeline/exec/analytic_sink_operator.h:76:
- Status open(RuntimeState* state) override;
+ Status open(RuntimeState* state) const override;
TPC-H: Total hot run time: 37957 ms |
TPC-DS: Total hot run time: 186525 ms |
ClickBench: Total hot run time: 30.98 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37824 ms |
TPC-DS: Total hot run time: 192503 ms |
ClickBench: Total hot run time: 30.82 s |
Gabriel39
force-pushed
the
refactor_0827_1
branch
from
4bd8676 to
ef351e7
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38602 ms |
TPC-DS: Total hot run time: 192414 ms |
ClickBench: Total hot run time: 31.82 s |
BiteTheDDDDt
approved these changes
Sep 5, 2024
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
Sep 6, 2024
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Oct 11, 2024
Unify `prepare` and `open` in `Operator`.
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Oct 14, 2024
Unify `prepare` and `open` in `Operator`.
dataroaring
pushed a commit
that referenced
this pull request
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Unify
prepareandopeninOperator.