Skip to content

[opt](in expr) Optimize the IN expression by skipping constant columns.#39912

Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom
Mryange:opt-in
Sep 4, 2024
Merged

[opt](in expr) Optimize the IN expression by skipping constant columns.#39912
BiteTheDDDDt merged 1 commit intoapache:masterfrom
Mryange:opt-in

Conversation

@Mryange
Copy link
Copy Markdown
Contributor

@Mryange Mryange commented Aug 26, 2024

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 26, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 26, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Aug 27, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 27, 2024

TPC-H: Total hot run time: 38196 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a3ec6ab7f19ebebfcae7932193331b2311eb32cb, data reload: false

------ Round 1 ----------------------------------
q1	17963	4494	4400	4400
q2	2277	179	174	174
q3	10470	1180	1073	1073
q4	10137	710	805	710
q5	7754	2842	2845	2842
q6	230	134	138	134
q7	967	621	599	599
q8	9317	2085	2094	2085
q9	7643	6557	6552	6552
q10	7002	2250	2168	2168
q11	477	248	261	248
q12	402	226	226	226
q13	17756	3045	3019	3019
q14	278	238	241	238
q15	523	488	490	488
q16	497	389	387	387
q17	1007	692	742	692
q18	7375	6756	6917	6756
q19	1376	1046	1088	1046
q20	726	343	340	340
q21	3899	3016	3123	3016
q22	1123	1004	1003	1003
Total cold run time: 109199 ms
Total hot run time: 38196 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4353	4271	4250	4250
q2	372	275	272	272
q3	2884	2658	2589	2589
q4	1932	1607	1682	1607
q5	5381	5389	5410	5389
q6	221	131	128	128
q7	2106	1691	1750	1691
q8	3219	3353	3350	3350
q9	8413	8429	8422	8422
q10	3436	3215	3233	3215
q11	600	501	501	501
q12	777	628	625	625
q13	11841	3054	3066	3054
q14	300	278	275	275
q15	527	478	479	478
q16	483	412	412	412
q17	1805	1494	1473	1473
q18	7762	7491	7411	7411
q19	1680	1619	1546	1546
q20	2040	1789	1830	1789
q21	5587	5270	5243	5243
q22	1099	1041	1046	1041
Total cold run time: 66818 ms
Total hot run time: 54761 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 27, 2024

TPC-DS: Total hot run time: 188106 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a3ec6ab7f19ebebfcae7932193331b2311eb32cb, data reload: false

query1	915	380	371	371
query2	6455	2035	1973	1973
query3	6648	216	227	216
query4	33188	23175	23165	23165
query5	4276	516	475	475
query6	251	163	166	163
query7	4604	307	293	293
query8	255	212	221	212
query9	8449	2525	2504	2504
query10	449	278	295	278
query11	17783	15006	15281	15006
query12	158	100	100	100
query13	1620	398	384	384
query14	9763	7268	7006	7006
query15	263	167	165	165
query16	8052	458	477	458
query17	1553	569	543	543
query18	2081	300	282	282
query19	314	140	140	140
query20	114	108	111	108
query21	210	102	101	101
query22	4307	4137	4187	4137
query23	33955	33402	33528	33402
query24	11083	2884	2975	2884
query25	657	370	395	370
query26	1134	163	164	163
query27	2351	292	289	289
query28	7115	2070	2052	2052
query29	811	415	410	410
query30	305	152	146	146
query31	975	740	786	740
query32	100	56	59	56
query33	754	293	283	283
query34	969	484	502	484
query35	852	734	731	731
query36	1082	924	922	922
query37	162	87	82	82
query38	3955	3843	3867	3843
query39	1441	1391	1381	1381
query40	205	116	115	115
query41	50	41	44	41
query42	109	96	98	96
query43	522	454	488	454
query44	1191	763	753	753
query45	201	163	173	163
query46	1101	715	750	715
query47	1859	1819	1764	1764
query48	394	304	300	300
query49	1085	425	433	425
query50	813	419	431	419
query51	7159	7057	7259	7057
query52	97	88	89	88
query53	258	188	182	182
query54	850	465	463	463
query55	82	77	82	77
query56	278	263	259	259
query57	1156	1090	1072	1072
query58	243	216	249	216
query59	3040	2757	2821	2757
query60	302	271	268	268
query61	101	96	97	96
query62	827	663	663	663
query63	214	187	187	187
query64	4950	665	720	665
query65	3265	3124	3177	3124
query66	1430	355	358	355
query67	15622	15239	15408	15239
query68	3517	603	603	603
query69	400	284	276	276
query70	1188	1120	1117	1117
query71	340	278	275	275
query72	6350	3968	3970	3968
query73	754	346	338	338
query74	9088	8759	8904	8759
query75	3374	2721	2718	2718
query76	1852	1034	986	986
query77	462	323	325	323
query78	9626	9024	9067	9024
query79	1044	563	544	544
query80	673	492	499	492
query81	456	228	236	228
query82	240	157	139	139
query83	179	159	160	159
query84	236	145	78	78
query85	688	290	275	275
query86	302	297	300	297
query87	4394	4393	4259	4259
query88	2939	2406	2401	2401
query89	381	289	286	286
query90	1761	205	197	197
query91	121	118	101	101
query92	63	51	53	51
query93	1043	542	551	542
query94	722	287	304	287
query95	360	268	259	259
query96	583	279	274	274
query97	3196	3066	3079	3066
query98	225	198	209	198
query99	1497	1307	1255	1255
Total cold run time: 284867 ms
Total hot run time: 188106 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 27, 2024

ClickBench: Total hot run time: 30.54 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a3ec6ab7f19ebebfcae7932193331b2311eb32cb, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.04	0.05
query3	0.22	0.05	0.05
query4	1.67	0.09	0.08
query5	0.49	0.49	0.49
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.49	0.49
query10	0.54	0.55	0.53
query11	0.16	0.12	0.11
query12	0.16	0.12	0.12
query13	0.62	0.58	0.59
query14	0.76	0.78	0.80
query15	0.84	0.83	0.81
query16	0.36	0.37	0.38
query17	1.06	0.97	1.06
query18	0.23	0.20	0.21
query19	1.91	1.78	1.81
query20	0.01	0.01	0.01
query21	15.42	0.68	0.67
query22	4.58	7.07	1.69
query23	18.28	1.40	1.33
query24	2.10	0.22	0.22
query25	0.16	0.07	0.08
query26	0.27	0.17	0.18
query27	0.07	0.08	0.08
query28	13.27	1.03	0.99
query29	12.60	3.36	3.39
query30	0.24	0.06	0.05
query31	2.89	0.42	0.41
query32	3.22	0.48	0.49
query33	2.93	3.05	2.97
query34	17.10	4.36	4.43
query35	4.45	4.39	4.43
query36	0.66	0.48	0.49
query37	0.19	0.17	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.03
query40	0.16	0.13	0.13
query41	0.10	0.04	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.91 s
Total hot run time: 30.54 s

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Aug 28, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 28, 2024

TPC-H: Total hot run time: 37926 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 23d969b3f26b3665a33b7e020fb74d6479820661, data reload: false

------ Round 1 ----------------------------------
q1	17626	5078	4335	4335
q2	2011	186	181	181
q3	11674	943	1197	943
q4	10522	727	884	727
q5	7749	2824	2857	2824
q6	227	141	141	141
q7	960	620	603	603
q8	9330	2084	2041	2041
q9	7200	6519	6554	6519
q10	7017	2251	2244	2244
q11	435	236	237	236
q12	398	228	233	228
q13	18956	3040	3081	3040
q14	277	236	239	236
q15	517	482	484	482
q16	602	506	549	506
q17	977	634	718	634
q18	7318	6782	6802	6782
q19	1383	1040	1132	1040
q20	667	342	330	330
q21	3938	3088	2847	2847
q22	1108	1012	1007	1007
Total cold run time: 110892 ms
Total hot run time: 37926 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4371	4358	4297	4297
q2	370	277	280	277
q3	2916	2625	2698	2625
q4	1945	1651	1669	1651
q5	5670	5699	5790	5699
q6	232	134	138	134
q7	2242	1849	1823	1823
q8	3256	3437	3517	3437
q9	8915	8901	8843	8843
q10	3606	3432	3368	3368
q11	598	510	517	510
q12	893	699	685	685
q13	14143	3104	3270	3104
q14	324	285	285	285
q15	526	489	494	489
q16	642	571	589	571
q17	1826	1558	1504	1504
q18	8111	7793	7940	7793
q19	1736	1705	1601	1601
q20	2173	1954	1891	1891
q21	5856	5577	5501	5501
q22	1105	1054	1020	1020
Total cold run time: 71456 ms
Total hot run time: 57108 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 28, 2024

TPC-DS: Total hot run time: 192998 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 23d969b3f26b3665a33b7e020fb74d6479820661, data reload: false

query1	1227	891	847	847
query2	6317	2084	2004	2004
query3	10616	3916	3853	3853
query4	59632	23964	23400	23400
query5	5499	505	509	505
query6	424	168	179	168
query7	5865	299	307	299
query8	310	209	203	203
query9	9084	2522	2492	2492
query10	505	263	266	263
query11	18108	14983	15320	14983
query12	156	99	101	99
query13	1578	396	380	380
query14	11234	6764	7437	6764
query15	225	179	174	174
query16	7388	464	510	464
query17	1153	574	578	574
query18	1989	293	287	287
query19	285	145	156	145
query20	118	113	115	113
query21	202	108	102	102
query22	4503	4499	4489	4489
query23	34222	33470	33261	33261
query24	5909	2927	2860	2860
query25	526	387	384	384
query26	704	155	154	154
query27	1791	287	283	283
query28	3639	2125	2123	2123
query29	667	409	421	409
query30	241	162	161	161
query31	941	759	765	759
query32	83	52	57	52
query33	463	284	275	275
query34	881	487	485	485
query35	857	730	707	707
query36	1053	952	960	952
query37	149	91	90	90
query38	4005	3892	3890	3890
query39	1439	1368	1387	1368
query40	203	118	113	113
query41	46	47	50	47
query42	115	98	99	98
query43	529	477	484	477
query44	1109	743	755	743
query45	197	169	172	169
query46	1109	740	749	740
query47	1900	1831	1813	1813
query48	377	303	315	303
query49	779	447	455	447
query50	833	412	416	412
query51	7207	6960	6991	6960
query52	99	87	91	87
query53	258	180	184	180
query54	567	449	462	449
query55	81	78	79	78
query56	286	261	272	261
query57	1217	1097	1046	1046
query58	233	227	227	227
query59	3082	2910	2788	2788
query60	305	283	275	275
query61	127	122	122	122
query62	758	664	638	638
query63	218	190	191	190
query64	2905	761	735	735
query65	3207	3170	3170	3170
query66	679	348	349	348
query67	15501	15283	15289	15283
query68	3049	575	600	575
query69	418	282	279	279
query70	1219	1061	1083	1061
query71	383	290	281	281
query72	6420	4202	4304	4202
query73	749	342	344	342
query74	9098	8804	8831	8804
query75	3347	2663	2706	2663
query76	1481	1084	1059	1059
query77	564	338	323	323
query78	9926	9636	9072	9072
query79	1935	537	540	537
query80	1152	536	500	500
query81	562	236	234	234
query82	745	154	148	148
query83	265	150	154	150
query84	263	77	73	73
query85	969	300	285	285
query86	406	313	278	278
query87	4398	4239	4285	4239
query88	3313	2329	2332	2329
query89	387	290	285	285
query90	1874	194	195	194
query91	126	99	98	98
query92	65	55	54	54
query93	1711	536	532	532
query94	856	302	285	285
query95	361	263	268	263
query96	607	277	268	268
query97	3218	3095	3072	3072
query98	230	216	250	216
query99	1580	1317	1277	1277
Total cold run time: 309592 ms
Total hot run time: 192998 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 28, 2024

ClickBench: Total hot run time: 32.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 23d969b3f26b3665a33b7e020fb74d6479820661, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.66	0.10	0.08
query5	0.51	0.51	0.50
query6	1.14	0.73	0.73
query7	0.01	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.48	0.48
query10	0.54	0.54	0.53
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.58	0.59
query14	2.07	2.12	2.11
query15	0.84	0.81	0.82
query16	0.37	0.37	0.37
query17	1.05	1.05	1.06
query18	0.20	0.20	0.21
query19	1.95	1.85	1.91
query20	0.01	0.01	0.01
query21	15.41	0.67	0.67
query22	4.23	5.93	2.52
query23	18.30	1.27	1.25
query24	2.13	0.24	0.22
query25	0.16	0.10	0.08
query26	0.27	0.18	0.18
query27	0.07	0.07	0.08
query28	13.24	1.02	1.00
query29	12.64	3.31	3.29
query30	0.24	0.05	0.05
query31	2.89	0.40	0.40
query32	3.24	0.49	0.47
query33	2.94	2.97	3.01
query34	16.89	4.35	4.40
query35	4.39	4.40	4.44
query36	0.66	0.49	0.50
query37	0.19	0.16	0.16
query38	0.17	0.16	0.15
query39	0.04	0.04	0.04
query40	0.17	0.14	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.69 s
Total hot run time: 32.75 s

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Aug 28, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 28, 2024

TPC-H: Total hot run time: 38184 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f8c14d378284323347ef0d92e5fb35142e51e0e5, data reload: false

------ Round 1 ----------------------------------
q1	18175	4547	4324	4324
q2	2029	190	176	176
q3	11570	1010	1047	1010
q4	10493	737	740	737
q5	7784	2891	2844	2844
q6	232	141	139	139
q7	969	630	604	604
q8	9389	2114	2107	2107
q9	7229	6570	6559	6559
q10	6997	2210	2194	2194
q11	475	259	254	254
q12	395	238	239	238
q13	18726	3044	3067	3044
q14	286	232	227	227
q15	524	486	487	486
q16	589	537	513	513
q17	997	700	781	700
q18	7381	6749	7070	6749
q19	1387	1113	949	949
q20	664	336	329	329
q21	3999	3001	3007	3001
q22	1124	1000	1005	1000
Total cold run time: 111414 ms
Total hot run time: 38184 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4548	4329	4348	4329
q2	363	273	276	273
q3	2900	2611	2689	2611
q4	1904	1646	1659	1646
q5	5705	5651	5786	5651
q6	238	139	139	139
q7	2212	1839	1833	1833
q8	3277	3441	3476	3441
q9	8873	8817	8819	8817
q10	3572	3425	3397	3397
q11	620	511	512	511
q12	833	680	664	664
q13	14323	3253	3275	3253
q14	323	289	298	289
q15	541	501	495	495
q16	638	581	592	581
q17	1857	1571	1544	1544
q18	8233	7933	7833	7833
q19	1748	1596	1648	1596
q20	2178	1873	1912	1873
q21	5638	5464	5527	5464
q22	1153	1050	1042	1042
Total cold run time: 71677 ms
Total hot run time: 57282 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 28, 2024

TPC-DS: Total hot run time: 193117 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f8c14d378284323347ef0d92e5fb35142e51e0e5, data reload: false

query1	1273	900	855	855
query2	6406	1962	2079	1962
query3	10606	3896	4040	3896
query4	59459	23781	23235	23235
query5	5473	515	512	512
query6	402	157	159	157
query7	5767	292	295	292
query8	310	210	215	210
query9	8837	2528	2509	2509
query10	480	278	262	262
query11	17480	15274	15321	15274
query12	157	126	103	103
query13	1532	396	382	382
query14	10863	7449	7609	7449
query15	228	188	182	182
query16	7483	447	478	447
query17	1178	586	568	568
query18	2036	298	299	298
query19	284	154	145	145
query20	120	118	112	112
query21	203	105	104	104
query22	4486	4471	4548	4471
query23	34170	33736	33165	33165
query24	5914	2842	2842	2842
query25	534	377	387	377
query26	686	159	158	158
query27	1764	282	277	277
query28	3813	2117	2097	2097
query29	693	401	415	401
query30	229	153	153	153
query31	939	779	749	749
query32	79	53	56	53
query33	405	287	277	277
query34	848	509	479	479
query35	821	711	720	711
query36	1053	966	955	955
query37	156	94	98	94
query38	4016	3794	3821	3794
query39	1452	1400	1371	1371
query40	205	115	115	115
query41	46	44	48	44
query42	113	95	96	95
query43	513	473	481	473
query44	1106	745	752	745
query45	198	169	165	165
query46	1087	748	764	748
query47	1879	1775	1808	1775
query48	372	299	296	296
query49	759	420	427	420
query50	805	422	432	422
query51	7187	7113	7023	7023
query52	97	89	90	89
query53	250	177	181	177
query54	556	461	452	452
query55	81	78	78	78
query56	285	266	252	252
query57	1217	1090	1092	1090
query58	233	218	219	218
query59	3073	2971	2819	2819
query60	291	262	278	262
query61	98	100	99	99
query62	745	647	690	647
query63	210	189	191	189
query64	2772	665	633	633
query65	3256	3134	3182	3134
query66	697	357	359	357
query67	15291	15274	15147	15147
query68	2920	586	580	580
query69	408	288	296	288
query70	1101	1134	1117	1117
query71	337	279	281	279
query72	5455	4059	4007	4007
query73	744	336	339	336
query74	9052	8829	8883	8829
query75	3377	2698	2689	2689
query76	1481	1018	984	984
query77	544	329	319	319
query78	9643	9069	9008	9008
query79	1030	549	538	538
query80	678	497	501	497
query81	535	236	232	232
query82	240	144	152	144
query83	169	148	148	148
query84	257	84	73	73
query85	673	288	278	278
query86	305	305	296	296
query87	4354	4329	4282	4282
query88	2935	2343	2414	2343
query89	379	296	290	290
query90	1954	199	194	194
query91	124	101	100	100
query92	60	51	53	51
query93	1024	536	535	535
query94	714	295	293	293
query95	330	258	262	258
query96	596	279	266	266
query97	3189	3104	3064	3064
query98	228	208	207	207
query99	1513	1276	1250	1250
Total cold run time: 302406 ms
Total hot run time: 193117 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 28, 2024

ClickBench: Total hot run time: 32.24 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f8c14d378284323347ef0d92e5fb35142e51e0e5, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.05
query3	0.22	0.04	0.05
query4	1.68	0.08	0.09
query5	0.50	0.50	0.49
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.55	0.50	0.49
query10	0.53	0.55	0.55
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.58	0.59
query14	2.11	2.05	2.10
query15	0.83	0.82	0.82
query16	0.37	0.38	0.39
query17	1.00	0.99	1.03
query18	0.22	0.21	0.20
query19	1.82	1.72	1.76
query20	0.01	0.01	0.01
query21	15.41	0.68	0.67
query22	3.69	7.49	2.19
query23	18.30	1.38	1.24
query24	2.09	0.22	0.24
query25	0.14	0.08	0.08
query26	0.26	0.18	0.17
query27	0.09	0.07	0.08
query28	13.21	1.02	1.01
query29	12.65	3.35	3.38
query30	0.24	0.06	0.05
query31	2.89	0.40	0.41
query32	3.22	0.47	0.47
query33	2.97	3.01	2.95
query34	17.17	4.41	4.39
query35	4.46	4.38	4.46
query36	0.66	0.49	0.51
query37	0.19	0.17	0.15
query38	0.16	0.16	0.17
query39	0.05	0.04	0.04
query40	0.16	0.12	0.13
query41	0.10	0.05	0.05
query42	0.07	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 110.3 s
Total hot run time: 32.24 s

@Mryange Mryange changed the title [only draft now] opt in expr [opt](in expr) Optimize the IN expression by skipping constant columns. Aug 29, 2024
@Mryange Mryange marked this pull request as ready for review August 29, 2024 13:41
@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Aug 29, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 29, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 29, 2024

TPC-H: Total hot run time: 38959 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4c690aa62513fea7ec02dfc7390e0c2d15a941b1, data reload: false

------ Round 1 ----------------------------------
q1	18008	4597	4449	4449
q2	2947	186	183	183
q3	11019	1266	1205	1205
q4	10419	780	725	725
q5	7777	2978	2883	2883
q6	232	147	145	145
q7	983	623	632	623
q8	9410	2097	2070	2070
q9	7273	6539	6545	6539
q10	7004	2260	2229	2229
q11	450	255	255	255
q12	401	233	232	232
q13	18802	3063	3078	3063
q14	302	242	237	237
q15	526	487	499	487
q16	580	519	508	508
q17	983	757	718	718
q18	7463	6946	6879	6879
q19	1400	1059	1066	1059
q20	702	341	341	341
q21	3993	3161	3137	3137
q22	1132	992	1008	992
Total cold run time: 111806 ms
Total hot run time: 38959 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4379	4340	4270	4270
q2	380	281	272	272
q3	2913	2705	2707	2705
q4	1935	1641	1639	1639
q5	5488	5474	5447	5447
q6	225	132	134	132
q7	2199	1794	1768	1768
q8	3255	3390	3372	3372
q9	8515	8465	8411	8411
q10	3456	3195	3213	3195
q11	586	528	510	510
q12	814	641	622	622
q13	10543	3019	3030	3019
q14	304	281	282	281
q15	525	496	490	490
q16	593	551	589	551
q17	1827	1501	1500	1500
q18	7769	7425	7500	7425
q19	1694	1369	1357	1357
q20	2080	1825	1807	1807
q21	5600	5345	5236	5236
q22	1132	1028	1024	1024
Total cold run time: 66212 ms
Total hot run time: 55033 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 29, 2024

TPC-DS: Total hot run time: 189003 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4c690aa62513fea7ec02dfc7390e0c2d15a941b1, data reload: false

query1	920	384	367	367
query2	6442	2006	1902	1902
query3	6651	222	225	222
query4	30285	23341	23258	23258
query5	4161	501	508	501
query6	252	169	169	169
query7	4578	298	302	298
query8	251	217	223	217
query9	8541	2521	2509	2509
query10	452	273	286	273
query11	16708	15029	15164	15029
query12	159	104	103	103
query13	1672	378	376	376
query14	10365	7581	7625	7581
query15	279	176	184	176
query16	7789	492	429	429
query17	1616	552	570	552
query18	1538	292	285	285
query19	338	149	155	149
query20	118	112	113	112
query21	206	105	104	104
query22	4311	4066	4226	4066
query23	34393	33443	33247	33247
query24	11259	2900	2950	2900
query25	586	393	397	393
query26	1024	166	165	165
query27	2309	289	289	289
query28	7290	2147	2110	2110
query29	732	420	407	407
query30	311	173	157	157
query31	997	714	784	714
query32	100	60	61	60
query33	752	288	302	288
query34	954	497	515	497
query35	923	725	716	716
query36	1120	929	977	929
query37	153	95	93	93
query38	4020	3814	3853	3814
query39	1447	1384	1380	1380
query40	207	121	119	119
query41	45	46	46	46
query42	120	102	100	100
query43	518	482	482	482
query44	1262	764	762	762
query45	196	168	164	164
query46	1105	758	790	758
query47	1877	1808	1762	1762
query48	376	291	308	291
query49	1038	432	445	432
query50	822	425	429	425
query51	7295	7095	7082	7082
query52	99	91	89	89
query53	269	192	188	188
query54	971	468	457	457
query55	80	111	79	79
query56	283	266	273	266
query57	1202	1076	1070	1070
query58	248	237	263	237
query59	3050	2821	2913	2821
query60	303	273	282	273
query61	100	101	98	98
query62	843	676	682	676
query63	222	194	191	191
query64	4183	746	656	656
query65	3244	3213	3219	3213
query66	1099	335	341	335
query67	15692	15146	15235	15146
query68	3126	586	620	586
query69	405	279	282	279
query70	1112	1134	1135	1134
query71	362	280	284	280
query72	6366	4052	3999	3999
query73	759	334	343	334
query74	9183	8818	8699	8699
query75	3390	2689	2768	2689
query76	1895	978	937	937
query77	498	341	351	341
query78	9506	9040	9339	9040
query79	1064	573	575	573
query80	736	555	564	555
query81	511	251	248	248
query82	262	160	153	153
query83	186	161	160	160
query84	226	81	85	81
query85	759	352	347	347
query86	298	308	290	290
query87	4489	4236	4267	4236
query88	3387	2409	2374	2374
query89	398	306	301	301
query90	1829	212	212	212
query91	148	114	120	114
query92	69	62	58	58
query93	1074	558	542	542
query94	632	304	308	304
query95	368	280	280	280
query96	596	273	278	273
query97	3186	3076	3068	3068
query98	225	204	204	204
query99	1501	1257	1282	1257
Total cold run time: 281297 ms
Total hot run time: 189003 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Aug 29, 2024

ClickBench: Total hot run time: 31.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4c690aa62513fea7ec02dfc7390e0c2d15a941b1, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.07	0.08
query5	0.51	0.49	0.48
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.56	0.49	0.47
query10	0.54	0.53	0.54
query11	0.16	0.13	0.11
query12	0.16	0.12	0.13
query13	0.63	0.59	0.59
query14	2.08	2.05	2.04
query15	0.84	0.83	0.81
query16	0.37	0.37	0.39
query17	1.07	1.04	1.06
query18	0.21	0.20	0.20
query19	1.92	1.73	1.73
query20	0.02	0.01	0.01
query21	15.42	0.66	0.66
query22	4.06	7.58	1.59
query23	18.26	1.42	1.37
query24	2.10	0.23	0.22
query25	0.16	0.09	0.09
query26	0.26	0.18	0.17
query27	0.07	0.08	0.07
query28	13.21	1.02	1.01
query29	12.64	3.35	3.30
query30	0.24	0.06	0.05
query31	2.88	0.40	0.40
query32	3.26	0.48	0.48
query33	2.98	3.04	3.03
query34	17.00	4.43	4.35
query35	4.45	4.42	4.42
query36	0.66	0.47	0.48
query37	0.20	0.16	0.16
query38	0.16	0.15	0.16
query39	0.05	0.04	0.04
query40	0.15	0.12	0.12
query41	0.10	0.06	0.05
query42	0.06	0.05	0.06
query43	0.05	0.04	0.05
Total cold run time: 110.73 s
Total hot run time: 31.76 s

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Aug 29, 2024

run cloud_p0

@zclllyybb
Copy link
Copy Markdown
Contributor

zclllyybb commented Aug 30, 2024

please add performance result to PR content

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Sep 3, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

TeamCity be ut coverage result:
Function Coverage: 36.82% (9385/25487)
Line Coverage: 28.27% (77442/273898)
Region Coverage: 27.67% (39964/144418)
Branch Coverage: 24.32% (20336/83628)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5faaecf248634a73c4d94d1d5cb8cadc9fa75576_5faaecf248634a73c4d94d1d5cb8cadc9fa75576/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

TPC-H: Total hot run time: 38297 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5faaecf248634a73c4d94d1d5cb8cadc9fa75576, data reload: false

------ Round 1 ----------------------------------
q1	17613	4482	4423	4423
q2	2016	186	172	172
q3	11959	1004	1183	1004
q4	10502	780	776	776
q5	7722	2909	2751	2751
q6	232	144	143	143
q7	966	615	593	593
q8	9350	2137	2114	2114
q9	7071	6585	6566	6566
q10	7005	2273	2170	2170
q11	446	250	246	246
q12	400	230	231	230
q13	17766	3078	3107	3078
q14	281	242	238	238
q15	531	487	498	487
q16	592	515	504	504
q17	1001	668	675	668
q18	7286	6810	6896	6810
q19	1396	976	1037	976
q20	701	333	321	321
q21	3972	2992	3264	2992
q22	1144	1043	1035	1035
Total cold run time: 109952 ms
Total hot run time: 38297 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4444	4353	4291	4291
q2	387	280	269	269
q3	2917	2664	2668	2664
q4	1993	1701	1672	1672
q5	5696	5739	5801	5739
q6	232	141	142	141
q7	2197	1874	1852	1852
q8	3324	3453	3567	3453
q9	8867	8895	8871	8871
q10	3630	3378	3325	3325
q11	626	490	523	490
q12	844	686	656	656
q13	15219	3260	3274	3260
q14	338	297	286	286
q15	544	475	513	475
q16	654	595	567	567
q17	1883	1589	1527	1527
q18	8175	7953	7812	7812
q19	1756	1557	1687	1557
q20	2141	1895	1905	1895
q21	5793	5659	5367	5367
q22	1126	1066	1068	1066
Total cold run time: 72786 ms
Total hot run time: 57235 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

TPC-DS: Total hot run time: 193817 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5faaecf248634a73c4d94d1d5cb8cadc9fa75576, data reload: false

query1	1265	900	853	853
query2	6434	2100	2057	2057
query3	10761	4208	4149	4149
query4	59914	24047	23210	23210
query5	5215	500	497	497
query6	403	163	159	159
query7	5735	291	296	291
query8	293	218	218	218
query9	8643	2501	2491	2491
query10	465	281	264	264
query11	18299	15148	15411	15148
query12	170	118	118	118
query13	1551	402	404	402
query14	11155	7513	7339	7339
query15	229	167	171	167
query16	7255	466	465	465
query17	1110	584	574	574
query18	1967	295	289	289
query19	266	151	148	148
query20	120	112	114	112
query21	209	103	98	98
query22	4738	4611	4516	4516
query23	34458	33347	33466	33347
query24	5970	2935	2961	2935
query25	529	383	386	383
query26	668	159	158	158
query27	1732	284	279	279
query28	3796	2047	2028	2028
query29	659	412	415	412
query30	235	153	160	153
query31	940	761	775	761
query32	89	51	59	51
query33	423	287	290	287
query34	869	491	470	470
query35	891	715	728	715
query36	1112	944	935	935
query37	153	88	91	88
query38	3994	3881	3946	3881
query39	1451	1406	1406	1406
query40	200	155	113	113
query41	49	46	44	44
query42	122	95	95	95
query43	524	484	474	474
query44	1112	728	735	728
query45	197	165	167	165
query46	1087	780	801	780
query47	1939	1772	1808	1772
query48	371	307	287	287
query49	765	426	432	426
query50	808	444	427	427
query51	7020	6971	6834	6834
query52	100	88	86	86
query53	250	180	183	180
query54	588	454	463	454
query55	75	78	76	76
query56	293	250	253	250
query57	1168	1059	1054	1054
query58	222	227	241	227
query59	3071	2929	2714	2714
query60	295	273	272	272
query61	106	97	97	97
query62	770	637	668	637
query63	224	186	190	186
query64	2361	678	707	678
query65	3249	3165	3195	3165
query66	676	336	342	336
query67	15589	15335	15125	15125
query68	3028	587	568	568
query69	409	284	287	284
query70	1213	1104	1084	1084
query71	357	279	273	273
query72	5325	4167	4025	4025
query73	759	328	344	328
query74	9083	8928	8785	8785
query75	3372	2684	2677	2677
query76	1421	1018	994	994
query77	529	332	334	332
query78	9854	10324	9501	9501
query79	1064	554	534	534
query80	736	512	518	512
query81	525	243	230	230
query82	288	150	146	146
query83	174	146	151	146
query84	260	75	83	75
query85	721	359	360	359
query86	307	271	298	271
query87	4465	4291	4255	4255
query88	3062	2347	2335	2335
query89	385	288	295	288
query90	1874	195	190	190
query91	128	105	99	99
query92	61	49	51	49
query93	1059	525	539	525
query94	643	306	306	306
query95	318	254	255	254
query96	598	267	269	267
query97	3221	3102	3097	3097
query98	218	206	203	203
query99	1505	1289	1296	1289
Total cold run time: 304359 ms
Total hot run time: 193817 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

ClickBench: Total hot run time: 32.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5faaecf248634a73c4d94d1d5cb8cadc9fa75576, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.67	0.08	0.08
query5	0.49	0.51	0.49
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.49	0.49
query10	0.54	0.52	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	2.09	2.09	2.04
query15	0.89	0.82	0.82
query16	0.37	0.38	0.37
query17	1.05	1.04	1.03
query18	0.21	0.20	0.20
query19	1.95	1.87	1.89
query20	0.01	0.01	0.02
query21	15.39	0.67	0.68
query22	3.83	7.77	2.03
query23	18.29	1.43	1.32
query24	2.05	0.25	0.21
query25	0.14	0.08	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.20	1.03	1.00
query29	12.63	3.25	3.27
query30	0.24	0.06	0.05
query31	2.90	0.39	0.41
query32	3.26	0.48	0.47
query33	2.98	2.96	3.04
query34	17.01	4.40	4.47
query35	4.43	4.52	4.49
query36	0.67	0.47	0.48
query37	0.18	0.16	0.15
query38	0.15	0.15	0.15
query39	0.05	0.04	0.04
query40	0.17	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.4 s
Total hot run time: 32.28 s

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Sep 3, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

TPC-H: Total hot run time: 38248 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5faaecf248634a73c4d94d1d5cb8cadc9fa75576, data reload: false

------ Round 1 ----------------------------------
q1	17633	4507	4350	4350
q2	2020	177	175	175
q3	10472	1189	1086	1086
q4	10148	805	805	805
q5	7885	2844	2813	2813
q6	238	143	145	143
q7	975	621	609	609
q8	9383	2088	2038	2038
q9	7133	6571	6556	6556
q10	7014	2239	2172	2172
q11	465	231	239	231
q12	410	221	225	221
q13	17761	3094	3060	3060
q14	278	228	230	228
q15	522	499	484	484
q16	573	517	518	517
q17	970	685	751	685
q18	7350	6812	6718	6718
q19	1394	1013	1056	1013
q20	674	329	317	317
q21	3926	2987	3097	2987
q22	1111	1050	1040	1040
Total cold run time: 108335 ms
Total hot run time: 38248 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4425	4320	4312	4312
q2	379	280	276	276
q3	2935	2660	2700	2660
q4	2010	1629	1677	1629
q5	5388	5386	5408	5386
q6	243	133	130	130
q7	2098	1733	1777	1733
q8	3220	3367	3375	3367
q9	8462	8498	8449	8449
q10	3456	3200	3259	3200
q11	624	491	483	483
q12	806	617	615	615
q13	14698	3057	3056	3056
q14	311	274	267	267
q15	526	478	475	475
q16	599	582	564	564
q17	1793	1468	1478	1468
q18	7754	7397	7441	7397
q19	1673	1558	1592	1558
q20	2061	1823	1832	1823
q21	5335	5179	5321	5179
q22	1157	1042	1041	1041
Total cold run time: 69953 ms
Total hot run time: 55068 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

TeamCity be ut coverage result:
Function Coverage: 36.81% (9383/25487)
Line Coverage: 28.26% (77414/273898)
Region Coverage: 27.66% (39940/144418)
Branch Coverage: 24.30% (20323/83628)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5faaecf248634a73c4d94d1d5cb8cadc9fa75576_5faaecf248634a73c4d94d1d5cb8cadc9fa75576/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

TPC-DS: Total hot run time: 189081 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5faaecf248634a73c4d94d1d5cb8cadc9fa75576, data reload: false

query1	909	365	368	365
query2	6456	1928	1999	1928
query3	6654	210	214	210
query4	34583	23254	23223	23223
query5	4209	509	482	482
query6	269	161	186	161
query7	4591	291	287	287
query8	241	200	205	200
query9	8418	2480	2468	2468
query10	446	276	282	276
query11	16103	14921	15175	14921
query12	157	109	97	97
query13	1615	368	373	368
query14	10060	7573	7472	7472
query15	264	168	175	168
query16	7747	456	471	456
query17	1602	567	544	544
query18	1394	288	285	285
query19	238	147	143	143
query20	115	109	108	108
query21	210	108	101	101
query22	4435	4131	4160	4131
query23	34202	33983	34013	33983
query24	10986	2853	2841	2841
query25	647	375	382	375
query26	1250	152	154	152
query27	2637	279	276	276
query28	7303	2036	2027	2027
query29	842	428	413	413
query30	290	158	153	153
query31	979	775	795	775
query32	100	56	55	55
query33	753	285	285	285
query34	1000	482	502	482
query35	851	731	738	731
query36	1091	942	923	923
query37	167	98	92	92
query38	3977	3904	3937	3904
query39	1460	1429	1468	1429
query40	266	114	113	113
query41	49	50	51	50
query42	115	95	96	95
query43	525	493	474	474
query44	1216	754	741	741
query45	199	168	167	167
query46	1103	761	764	761
query47	1893	1830	1827	1827
query48	365	289	291	289
query49	1057	419	425	419
query50	801	417	404	404
query51	7004	6884	6991	6884
query52	97	87	86	86
query53	245	187	181	181
query54	903	454	450	450
query55	76	73	76	73
query56	278	261	250	250
query57	1203	1048	1055	1048
query58	256	249	233	233
query59	3072	2886	2740	2740
query60	293	267	272	267
query61	139	95	102	95
query62	798	660	672	660
query63	222	185	179	179
query64	5045	685	652	652
query65	3234	3204	3137	3137
query66	1071	366	345	345
query67	15803	15756	15476	15476
query68	3237	566	570	566
query69	391	287	283	283
query70	1117	1109	1052	1052
query71	342	276	283	276
query72	6280	3988	3885	3885
query73	746	331	326	326
query74	9256	8763	8840	8763
query75	3416	2691	2667	2667
query76	1976	989	1027	989
query77	484	341	322	322
query78	10587	9239	9649	9239
query79	1000	541	546	541
query80	688	505	502	502
query81	490	237	232	232
query82	241	152	141	141
query83	174	164	152	152
query84	225	77	79	77
query85	761	360	359	359
query86	302	302	304	302
query87	4403	4382	4268	4268
query88	3123	2310	2336	2310
query89	376	285	284	284
query90	1897	196	193	193
query91	128	103	100	100
query92	59	52	49	49
query93	1040	530	522	522
query94	667	291	288	288
query95	345	258	252	252
query96	587	279	264	264
query97	3194	3089	3046	3046
query98	225	205	198	198
query99	1471	1281	1247	1247
Total cold run time: 285807 ms
Total hot run time: 189081 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Sep 3, 2024

ClickBench: Total hot run time: 32.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5faaecf248634a73c4d94d1d5cb8cadc9fa75576, data reload: false

query1	0.05	0.05	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.52	0.48	0.50
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.49	0.49
query10	0.56	0.55	0.54
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	2.05	2.05	2.05
query15	0.88	0.81	0.82
query16	0.38	0.38	0.37
query17	1.03	1.08	1.01
query18	0.20	0.19	0.21
query19	1.86	1.71	1.83
query20	0.01	0.01	0.01
query21	15.40	0.67	0.67
query22	4.08	6.81	2.11
query23	18.25	1.36	1.28
query24	2.13	0.24	0.22
query25	0.15	0.08	0.08
query26	0.26	0.19	0.17
query27	0.08	0.07	0.07
query28	13.20	1.00	1.00
query29	12.65	3.29	3.25
query30	0.24	0.06	0.05
query31	2.88	0.40	0.39
query32	3.27	0.50	0.48
query33	2.94	3.06	3.03
query34	16.98	4.53	4.44
query35	4.46	4.49	4.47
query36	0.67	0.47	0.48
query37	0.19	0.16	0.15
query38	0.16	0.15	0.14
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.57 s
Total hot run time: 32.23 s

HappenLee
HappenLee approved these changes Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2024

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 5eab877 into apache:master Sep 4, 2024
Mryange added a commit to Mryange/doris that referenced this pull request Sep 18, 2024
@Mryange
[opt](in expr) Optimize the IN expression by skipping constant column…
716c839 
…s. (apache#39912)

Optimize the IN expression by skipping constant columns
@Mryange Mryange mentioned this pull request Sep 18, 2024
Merged
HappenLee pushed a commit that referenced this pull request Sep 18, 2024
@Mryange
[opt](in expr) Optimize the IN expression by skipping constant column… (
a6a008a 
#40917)

…s. (#39912)
#39912

Optimize the IN expression by skipping constant columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mryange @doris-robot @zclllyybb @BiteTheDDDDt @HappenLee