Skip to content

[cherry-pick](branch-21) fix partition-topn calculate partition input rows have error (#39100) #39281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Aug 13, 2024
+2 −2
Merged

[cherry-pick](branch-21) fix partition-topn calculate partition input rows have error (#39100) #39281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/pipeline/exec/partition_sort_sink_operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ Status PartitionSortSinkOperatorX::sink(RuntimeState* state, vectorized::Block*
SCOPED_TIMER(local_state.exec_time_counter());
if (current_rows > 0) {
COUNTER_UPDATE(local_state.rows_input_counter(), (int64_t)input_block->rows());
local_state.child_input_rows = local_state.child_input_rows + current_rows;
if (UNLIKELY(_partition_exprs_num == 0)) {
if (UNLIKELY(local_state._value_places.empty())) {
local_state._value_places.push_back(_pool->add(new vectorized::PartitionBlocks(
Expand All @@ -129,6 +128,7 @@ Status PartitionSortSinkOperatorX::sink(RuntimeState* state, vectorized::Block*
RETURN_IF_ERROR(_split_block_by_partition(input_block, local_state, eos));
RETURN_IF_CANCELLED(state);
input_block->clear_column_data();
local_state.child_input_rows = local_state.child_input_rows + current_rows;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/exec/vpartition_sort_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ Status VPartitionSortNode::sink(RuntimeState* state, vectorized::Block* input_bl
SCOPED_TIMER(_exec_timer);
auto current_rows = input_block->rows();
if (current_rows > 0) {
child_input_rows = child_input_rows + current_rows;
if (UNLIKELY(_partition_exprs_num == 0)) {
if (UNLIKELY(_value_places.empty())) {
_value_places.push_back(_pool->add(
Expand All @@ -250,6 +249,7 @@ Status VPartitionSortNode::sink(RuntimeState* state, vectorized::Block* input_bl
RETURN_IF_ERROR(_split_block_by_partition(input_block, eos));
RETURN_IF_CANCELLED(state);
input_block->clear_column_data();
child_input_rows = child_input_rows + current_rows;
}
}
}
Expand Down