[improve](ip)improve data type ip for rowstore and trycatch in segment_flusher#39258
Merged
eldenmoon merged 5 commits intoapache:masterfrom Aug 14, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TPC-H: Total hot run time: 39462 ms |
TPC-DS: Total hot run time: 200999 ms |
ClickBench: Total hot run time: 30.73 s |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
run buildall |
|
|
||
| void DataTypeIPv6SerDe::read_one_cell_from_jsonb(IColumn& column, const JsonbValue* arg) const { | ||
| IPv6 val = 0; | ||
| const auto *str_value = static_cast<const JsonbStringVal*>(arg); |
Contributor
There was a problem hiding this comment.
warning: 'auto str_value' can be declared as 'const auto *str_value' [readability-qualified-auto]
Suggested change
| const auto *str_value = static_cast<const JsonbStringVal*>(arg); | |
| const auto *str_value = static_cast<const JsonbStringVal*>(arg); |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eldenmoon
reviewed
Aug 13, 2024
eldenmoon
reviewed
Aug 13, 2024
eldenmoon
reviewed
Aug 13, 2024
eldenmoon
reviewed
Aug 13, 2024
eldenmoon
reviewed
Aug 13, 2024
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eldenmoon
reviewed
Aug 13, 2024
TPC-H: Total hot run time: 39443 ms |
TPC-DS: Total hot run time: 203514 ms |
ClickBench: Total hot run time: 30.88 s |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39682 ms |
TPC-DS: Total hot run time: 189765 ms |
ClickBench: Total hot run time: 30.67 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…t_flusher (apache#39258) before we not support ipv6 with rowstore, and can make coredump like this: ``` terminate called after throwing an instance of 'doris::Exception' what(): [E3] write_one_cell_to_jsonb with type IPv6 *** Query id: e5e020df4ea04a70-95a27c948db5a518 *** *** is nereids: 0 *** *** tablet id: 9008975 *** *** Aborted at 1723184823 (unix time) try "date -d @1723184823" if you are using GNU date *** *** Current BE git commitID: a2baaf3 *** *** SIGABRT unknown detail explain (@0x29f794) received by PID 2750356 (TID 2752049 OR 0x7f6064dec640) from PID 2750356; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421 1# 0x00007F6499586520 in /lib/x86_64-linux-gnu/libc.so.6 2# pthread_kill at ./nptl/pthread_kill.c:89 3# raise at ../sysdeps/posix/raise.c:27 4# abort at ./stdlib/abort.c:81 5# __gnu_cxx::__verbose_terminate_handler() [clone .cold] at ../../../../libstdc++-v3/libsupc++/vterminate.cc:75 6# __cxxabiv1::__terminate(void (*)()) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48 7# 0x00005610407949C1 in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 8# 0x0000561040794B14 in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 9# doris::vectorized::DataTypeNumberSerDe<unsigned __int128>::write_one_cell_to_jsonb(doris::vectorized::IColumn const&, doris::JsonbWriterT<doris::JsonbOutStream>&, doris::vectorized::Arena*, int, int) const in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 10# doris::vectorized::JsonbSerializeUtil::block_to_jsonb(doris::TabletSchema const&, doris::vectorized::Block const&, doris::vectorized::ColumnStr<unsigned int>&, int, std::vector<std::shared_ptr<doris::vectorized::DataTypeSerDe>, std::allocator<std::shared_ptr<doris::vectorized::DataTypeSerDe> > > const&, std::unordered_set<int, std::hash<int>, std::equal_to<int>, std::allocator<int> > const&) at /home/zcp/repo_center/doris_master/doris/be/src/vec/jsonb/serialize.cpp:57 11# doris::segment_v2::VerticalSegmentWriter::_serialize_block_to_row_column(doris::vectorized::Block&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:302 12# doris::segment_v2::VerticalSegmentWriter::write_batch() at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:839 13# doris::SegmentFlusher::_add_rows(std::unique_ptr<doris::segment_v2::VerticalSegmentWriter, std::default_delete<doris::segment_v2::VerticalSegmentWriter> >&, doris::vectorized::Block const*, unsigned long, unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_creator.cpp:130 14# doris::SegmentFlusher::flush_single_block(doris::vectorized::Block const*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_creator.cpp:73 15# doris::SegmentCreator::flush_single_block(doris::vectorized::Block const*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_creator.cpp:395 16# doris::BetaRowsetWriterV2::flush_memtable(doris::vectorized::Block*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/beta_rowset_writer_v2.cpp:101 17# doris::FlushToken::_do_flush_memtable(doris::MemTable*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/memtable_flush_executor.cpp:148 18# doris::FlushToken::_flush_memtable(std::unique_ptr<doris::MemTable, std::default_delete<doris::MemTable> >, int, long) in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 19# doris::MemtableFlushTask::run() at /home/zcp/repo_center/doris_master/doris/be/src/olap/memtable_flush_executor.cpp:63 20# doris::ThreadPool::dispatch_thread() in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 21# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:499 22# start_thread at ./nptl/pthread_create.c:442 23# 0x00007F649966A850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83 ```
yiguolei
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Proposed changes backport: #39258 Issue Number: close #xxx <!--Describe your changes.-->
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
…t_flusher (#39258) before we not support ipv6 with rowstore, and can make coredump like this: ``` terminate called after throwing an instance of 'doris::Exception' what(): [E3] write_one_cell_to_jsonb with type IPv6 *** Query id: e5e020df4ea04a70-95a27c948db5a518 *** *** is nereids: 0 *** *** tablet id: 9008975 *** *** Aborted at 1723184823 (unix time) try "date -d @1723184823" if you are using GNU date *** *** Current BE git commitID: a2baaf3 *** *** SIGABRT unknown detail explain (@0x29f794) received by PID 2750356 (TID 2752049 OR 0x7f6064dec640) from PID 2750356; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421 1# 0x00007F6499586520 in /lib/x86_64-linux-gnu/libc.so.6 2# pthread_kill at ./nptl/pthread_kill.c:89 3# raise at ../sysdeps/posix/raise.c:27 4# abort at ./stdlib/abort.c:81 5# __gnu_cxx::__verbose_terminate_handler() [clone .cold] at ../../../../libstdc++-v3/libsupc++/vterminate.cc:75 6# __cxxabiv1::__terminate(void (*)()) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48 7# 0x00005610407949C1 in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 8# 0x0000561040794B14 in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 9# doris::vectorized::DataTypeNumberSerDe<unsigned __int128>::write_one_cell_to_jsonb(doris::vectorized::IColumn const&, doris::JsonbWriterT<doris::JsonbOutStream>&, doris::vectorized::Arena*, int, int) const in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 10# doris::vectorized::JsonbSerializeUtil::block_to_jsonb(doris::TabletSchema const&, doris::vectorized::Block const&, doris::vectorized::ColumnStr<unsigned int>&, int, std::vector<std::shared_ptr<doris::vectorized::DataTypeSerDe>, std::allocator<std::shared_ptr<doris::vectorized::DataTypeSerDe> > > const&, std::unordered_set<int, std::hash<int>, std::equal_to<int>, std::allocator<int> > const&) at /home/zcp/repo_center/doris_master/doris/be/src/vec/jsonb/serialize.cpp:57 11# doris::segment_v2::VerticalSegmentWriter::_serialize_block_to_row_column(doris::vectorized::Block&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:302 12# doris::segment_v2::VerticalSegmentWriter::write_batch() at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:839 13# doris::SegmentFlusher::_add_rows(std::unique_ptr<doris::segment_v2::VerticalSegmentWriter, std::default_delete<doris::segment_v2::VerticalSegmentWriter> >&, doris::vectorized::Block const*, unsigned long, unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_creator.cpp:130 14# doris::SegmentFlusher::flush_single_block(doris::vectorized::Block const*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_creator.cpp:73 15# doris::SegmentCreator::flush_single_block(doris::vectorized::Block const*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/segment_creator.cpp:395 16# doris::BetaRowsetWriterV2::flush_memtable(doris::vectorized::Block*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/rowset/beta_rowset_writer_v2.cpp:101 17# doris::FlushToken::_do_flush_memtable(doris::MemTable*, int, long*) at /home/zcp/repo_center/doris_master/doris/be/src/olap/memtable_flush_executor.cpp:148 18# doris::FlushToken::_flush_memtable(std::unique_ptr<doris::MemTable, std::default_delete<doris::MemTable> >, int, long) in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 19# doris::MemtableFlushTask::run() at /home/zcp/repo_center/doris_master/doris/be/src/olap/memtable_flush_executor.cpp:63 20# doris::ThreadPool::dispatch_thread() in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be 21# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:499 22# start_thread at ./nptl/pthread_create.c:442 23# 0x00007F649966A850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83 ```
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
before we not support ipv6 with rowstore, and can make coredump like this:
Issue Number: close #xxx