[Improment]Add workload group resource usage#39177
Merged
yiguolei merged 2 commits intoapache:masterfrom Aug 12, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yiguolei
reviewed
Aug 10, 2024
| {"BE_ID", TYPE_BIGINT, sizeof(int64_t), false}, | ||
| {"WORKLOAD_GROUP_ID", TYPE_BIGINT, sizeof(int64_t), false}, | ||
| {"MEMORY_USAGE_BYTES", TYPE_BIGINT, sizeof(int64_t), false}, | ||
| {"CPU_USAGE", TYPE_VARCHAR, sizeof(StringRef), false}, |
Contributor
There was a problem hiding this comment.
这个可能不行，不行就把百分号去掉。否则用户没法排序
yiguolei
reviewed
Aug 10, 2024
yiguolei
reviewed
Aug 10, 2024
| } | ||
| } | ||
| SCOPED_RAW_TIMER(&_write_memtable_time); | ||
| ThreadCpuStopWatch cpu_time_stop_watch; |
Contributor
There was a problem hiding this comment.
我觉得这个得加到async result writer 那个线程那里，这样所有的都被cover 住了
yiguolei
reviewed
Aug 10, 2024
| builder().column("BE_ID", ScalarType.createType(PrimitiveType.BIGINT)) | ||
| .column("WORKLOAD_GROUP_ID", ScalarType.createType(PrimitiveType.BIGINT)) | ||
| .column("MEMORY_USAGE_BYTES", ScalarType.createType(PrimitiveType.BIGINT)) | ||
| .column("CPU_USAGE", ScalarType.createVarchar(256)) |
Contributor
There was a problem hiding this comment.
要不把这列的类型定义为整数，这样用户可以排序。
然后把列名改成CPU_USAGE(%)这样
yiguolei
reviewed
Aug 10, 2024
yiguolei
reviewed
Aug 10, 2024
yiguolei
reviewed
Aug 10, 2024
| _next_io_time_micros += ret < 1 ? static_cast<int64_t>(1) : static_cast<int64_t>(ret); | ||
| } | ||
| _next_io_time_micros += ret < 1 ? static_cast<int64_t>(1) : static_cast<int64_t>(ret); | ||
| (*_io_adder) << io_bytes; |
Contributor
There was a problem hiding this comment.
这里我感觉local 的也统计了，那么之前的就没必要再那个宏里修改了，直接都用这里的统计
wangbo
force-pushed
the
0809_wg_monitor
branch
from
01770f9 to
01a500a
Compare
wangbo
force-pushed
the
0809_wg_monitor
branch
from
185b865 to
8d689c7
Compare
wangbo
force-pushed
the
0809_wg_monitor
branch
2 times, most recently
from
7725bb5 to
f3f42f0
Compare
wangbo
force-pushed
the
0809_wg_monitor
branch
from
f3f42f0 to
3bffef3
Compare
yiguolei
approved these changes
Aug 10, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
TPC-H: Total hot run time: 39938 ms |
TPC-DS: Total hot run time: 204326 ms |
ClickBench: Total hot run time: 30.93 s |
zclllyybb
approved these changes
Aug 11, 2024
Contributor
zclllyybb
left a comment
zclllyybb
left a comment
There was a problem hiding this comment.
LGTM. please add apache/doris-website's pr link in your pr content.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
## Proposed changes ``` mysql [information_schema]>select BE_ID,WORKLOAD_GROUP_ID,CPU_USAGE,LOCAL_SCAN_BYTES_PER_SECOND/1024/1024 as scan_io_mb, MEMORY_USAGE_BYTES/1024/1024 mem_mb from workload_group_resource_usage; +-------+-------------------+-----------+--------------------+-------------------+ | BE_ID | WORKLOAD_GROUP_ID | CPU_USAGE | scan_io_mb | mem_mb | +-------+-------------------+-----------+--------------------+-------------------+ | 10005 | 62053 | 61.41% | 1516.4589414596558 | 27970.84313774109 | | 10005 | 1 | 0.00% | 0 | 0 | +-------+-------------------+-----------+--------------------+-------------------+ ```
dataroaring
pushed a commit
that referenced
this pull request
Aug 17, 2024
## Proposed changes ``` mysql [information_schema]>select BE_ID,WORKLOAD_GROUP_ID,CPU_USAGE,LOCAL_SCAN_BYTES_PER_SECOND/1024/1024 as scan_io_mb, MEMORY_USAGE_BYTES/1024/1024 mem_mb from workload_group_resource_usage; +-------+-------------------+-----------+--------------------+-------------------+ | BE_ID | WORKLOAD_GROUP_ID | CPU_USAGE | scan_io_mb | mem_mb | +-------+-------------------+-----------+--------------------+-------------------+ | 10005 | 62053 | 61.41% | 1516.4589414596558 | 27970.84313774109 | | 10005 | 1 | 0.00% | 0 | 0 | +-------+-------------------+-----------+--------------------+-------------------+ ```
wangbo
added a commit
to wangbo/incubator-doris
that referenced
this pull request
Aug 23, 2024
``` mysql [information_schema]>select BE_ID,WORKLOAD_GROUP_ID,CPU_USAGE,LOCAL_SCAN_BYTES_PER_SECOND/1024/1024 as scan_io_mb, MEMORY_USAGE_BYTES/1024/1024 mem_mb from workload_group_resource_usage; +-------+-------------------+-----------+--------------------+-------------------+ | BE_ID | WORKLOAD_GROUP_ID | CPU_USAGE | scan_io_mb | mem_mb | +-------+-------------------+-----------+--------------------+-------------------+ | 10005 | 62053 | 61.41% | 1516.4589414596558 | 27970.84313774109 | | 10005 | 1 | 0.00% | 0 | 0 | +-------+-------------------+-----------+--------------------+-------------------+ ```
wangbo
added a commit
to wangbo/incubator-doris
that referenced
this pull request
Aug 23, 2024
``` mysql [information_schema]>select BE_ID,WORKLOAD_GROUP_ID,CPU_USAGE,LOCAL_SCAN_BYTES_PER_SECOND/1024/1024 as scan_io_mb, MEMORY_USAGE_BYTES/1024/1024 mem_mb from workload_group_resource_usage; +-------+-------------------+-----------+--------------------+-------------------+ | BE_ID | WORKLOAD_GROUP_ID | CPU_USAGE | scan_io_mb | mem_mb | +-------+-------------------+-----------+--------------------+-------------------+ | 10005 | 62053 | 61.41% | 1516.4589414596558 | 27970.84313774109 | | 10005 | 1 | 0.00% | 0 | 0 | +-------+-------------------+-----------+--------------------+-------------------+ ```
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes