Skip to content

[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closure #39155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BiteTheDDDDt merged 4 commits into from
Aug 13, 2024
Merged

[Bug](brpc) fix sync_filter_size/apply_filterv2 has wrong closure #39155

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c22f574
do not create iobuf on RuntimeFilterMergeControllerEntity::merge
BiteTheDDDDt Aug 9, 2024
d3be74d
update
BiteTheDDDDt Aug 12, 2024
5662845
update
BiteTheDDDDt Aug 12, 2024
577651d
update
BiteTheDDDDt Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions be/src/runtime/runtime_filter_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ Status RuntimeFilterMergeControllerEntity::send_filter_size(const PSendFilterSiz
closure->request_->set_filter_size(cnt_val->global_size);

stub->sync_filter_size(closure->cntl_.get(), closure->request_.get(),
closure->response_.get(), brpc::DoNothing());
closure->response_.get(), closure.get());
closure.release();
}
}
Expand Down Expand Up @@ -425,7 +425,11 @@ Status RuntimeFilterMergeControllerEntity::merge(const PMergeFilterRequest* requ
}

if (data != nullptr && len > 0) {
request_attachment.append(data, len);
void* allocated = malloc(len);
memcpy(allocated, data, len);
// control the memory by doris self to avoid using brpc's thread local storage
// because the memory of tls will not be released
request_attachment.append_user_data(allocated, len, [](void* ptr) { free(ptr); });
has_attachment = true;
}

Expand Down Expand Up @@ -459,7 +463,7 @@ Status RuntimeFilterMergeControllerEntity::merge(const PMergeFilterRequest* requ
continue;
}
stub->apply_filterv2(closure->cntl_.get(), closure->request_.get(),
closure->response_.get(), brpc::DoNothing());
closure->response_.get(), closure.get());
closure.release();
}
}
Expand Down