Skip to content

[fix](schema-change) Fix wrong intput column for cast validity check (#38894)#39107

Merged
dataroaring merged 1 commit intoapache:branch-2.1from
Hastyshell:fix-nullable-validity-check-2.1
Aug 8, 2024
Merged

[fix](schema-change) Fix wrong intput column for cast validity check (#38894)#39107
dataroaring merged 1 commit intoapache:branch-2.1from
Hastyshell:fix-nullable-validity-check-2.1

Conversation

@Hastyshell
Copy link
Copy Markdown
Collaborator

@Hastyshell Hastyshell commented Aug 8, 2024

Proposed changes

pick #38894

  1. Use column idx of ref block instead of new block to indicate the ref column.
  2. Rename some variables to clarify their meanings.
  3. Clarify some log msg.
  4. Add a minimal case to verify the change.

…pache#38894)

1. Use column idx of ref block instead of new block to indicate the ref
column.
2. Rename some variables to clarify their meanings.
3. Clarify some log msg.
4. Add a minimal case to verify the change.
@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Hastyshell
Copy link
Copy Markdown
Collaborator Author

run buildall

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/src/olap/schema_change.cpp
@Hastyshell
Copy link
Copy Markdown
Collaborator Author

run buildall

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.35% (9261/25474)
Line Coverage: 27.83% (75699/271960)
Region Coverage: 26.69% (38950/145911)
Branch Coverage: 23.41% (19761/84408)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dd34564bf7cd22bd26a934b8b8f93cb3ccaf43ac_dd34564bf7cd22bd26a934b8b8f93cb3ccaf43ac/report/index.html

@dataroaring dataroaring merged commit f8f5be7 into apache:branch-2.1 Aug 8, 2024
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants