[fix](move-memtable) fix bvar g_load_stream_file_writer_cnt#39075
Merged
liaoxin01 merged 2 commits intoapache:masterfrom Aug 9, 2024
Merged
[fix](move-memtable) fix bvar g_load_stream_file_writer_cnt#39075liaoxin01 merged 2 commits intoapache:masterfrom
liaoxin01 merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39833 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40812 ms |
TPC-H: Total hot run time: 39441 ms |
TPC-DS: Total hot run time: 204314 ms |
ClickBench: Total hot run time: 30.57 s |
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
Previously the bvar `g_load_stream_file_writer_cnt` is not accurate when error happens. Some `FileWriters` are not supposed to be closed manually. All `FileWriter` in `LoadStreamWriter` is managed by `std::unique_ptr`. A `FileWriter` should be able to close itself and cleanup storage state on its deconstructor. This PR changes the bvar `g_load_stream_file_writer_cnt` to track deconstruction of `FileWriter`, instead of tracking `FileWriter` close.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…9075) Previously the bvar `g_load_stream_file_writer_cnt` is not accurate when error happens. Some `FileWriters` are not supposed to be closed manually. All `FileWriter` in `LoadStreamWriter` is managed by `std::unique_ptr`. A `FileWriter` should be able to close itself and cleanup storage state on its deconstructor. This PR changes the bvar `g_load_stream_file_writer_cnt` to track deconstruction of `FileWriter`, instead of tracking `FileWriter` close.
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
Previously the bvar `g_load_stream_file_writer_cnt` is not accurate when error happens. Some `FileWriters` are not supposed to be closed manually. All `FileWriter` in `LoadStreamWriter` is managed by `std::unique_ptr`. A `FileWriter` should be able to close itself and cleanup storage state on its deconstructor. This PR changes the bvar `g_load_stream_file_writer_cnt` to track deconstruction of `FileWriter`, instead of tracking `FileWriter` close.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Sep 19, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Sep 19, 2024
yiguolei
pushed a commit
that referenced
this pull request
Sep 20, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously the bvar
g_load_stream_file_writer_cntis not accurate when error happens.Some
FileWritersare not supposed to be closed manually.All
FileWriterinLoadStreamWriteris managed bystd::unique_ptr.A
FileWritershould be able to close itself and cleanup storage state on its deconstructor.This PR changes the bvar
g_load_stream_file_writer_cntto track deconstruction ofFileWriter,instead of tracking
FileWriterclose.