[Fix](merge-on-write) Fix UBSan error cause by member call on null pointer by bobhan1 · Pull Request #39066 · apache/doris

bobhan1 · 2024-08-08T00:54:18Z

Proposed changes

fix member call on null pointer in #38331

doris-robot · 2024-08-08T00:54:23Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

bobhan1 · 2024-08-08T00:54:35Z

run buildall

github-actions · 2024-08-08T01:01:29Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-08T01:33:20Z

TPC-H: Total hot run time: 39195 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6037b6f07c005f90f2b202e45289b79aaee79244, data reload: false

------ Round 1 ----------------------------------
q1	17619	4366	4273	4273
q2	2011	180	175	175
q3	10486	1133	1000	1000
q4	10149	699	685	685
q5	7510	2487	2481	2481
q6	217	139	143	139
q7	968	597	597	597
q8	9219	1900	1902	1900
q9	8814	6533	6562	6533
q10	7069	2224	2169	2169
q11	463	240	252	240
q12	475	233	237	233
q13	17872	2965	2961	2961
q14	284	238	233	233
q15	519	484	482	482
q16	507	385	391	385
q17	950	636	704	636
q18	8003	7452	7375	7375
q19	6857	1046	1039	1039
q20	927	343	343	343
q21	5321	4302	4450	4302
q22	1129	1014	1015	1014
Total cold run time: 117369 ms
Total hot run time: 39195 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4505	4275	4305	4275
q2	395	278	262	262
q3	2849	2667	2730	2667
q4	1960	1811	1773	1773
q5	5667	5514	5470	5470
q6	220	132	132	132
q7	2127	1753	1799	1753
q8	3308	3446	3463	3446
q9	8823	8818	8897	8818
q10	3530	3357	3253	3253
q11	599	494	505	494
q12	826	680	651	651
q13	16302	3224	3469	3224
q14	345	286	310	286
q15	538	503	512	503
q16	510	448	457	448
q17	1840	1567	1561	1561
q18	8426	10130	8505	8505
q19	1777	1696	1668	1668
q20	2066	1869	1948	1869
q21	8690	5423	5490	5423
q22	1104	1022	1016	1016
Total cold run time: 76407 ms
Total hot run time: 57497 ms

bobhan1 · 2024-08-08T02:42:57Z

run buildall

github-actions · 2024-08-08T02:48:02Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-08T02:48:03Z

PR approved by anyone and no changes requested.

github-actions · 2024-08-08T02:49:10Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-08T04:14:21Z

TPC-H: Total hot run time: 40016 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a5734e0f6ecfc7d4da791b17a18f542d13c69c6, data reload: false

------ Round 1 ----------------------------------
q1	17622	4383	4331	4331
q2	2021	182	181	181
q3	10496	1213	1120	1120
q4	10154	693	699	693
q5	7493	2601	2576	2576
q6	227	137	140	137
q7	985	613	621	613
q8	9228	1943	1959	1943
q9	8832	6617	6565	6565
q10	7063	2220	2246	2220
q11	452	242	245	242
q12	484	223	228	223
q13	17771	3006	2996	2996
q14	278	238	237	237
q15	522	485	490	485
q16	498	395	385	385
q17	995	650	720	650
q18	8026	7381	7390	7381
q19	6131	1024	975	975
q20	664	329	333	329
q21	5884	4725	4796	4725
q22	1112	1012	1009	1009
Total cold run time: 116938 ms
Total hot run time: 40016 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4516	4304	4279	4279
q2	386	262	285	262
q3	2856	2656	2786	2656
q4	2032	1789	1755	1755
q5	5589	5568	5517	5517
q6	222	133	134	133
q7	2211	1797	1806	1797
q8	3287	3522	3476	3476
q9	8833	8840	8802	8802
q10	3558	3191	3213	3191
q11	597	528	514	514
q12	830	659	615	615
q13	16043	3156	3188	3156
q14	343	283	293	283
q15	549	485	506	485
q16	502	446	460	446
q17	1857	1582	1520	1520
q18	8138	7948	7991	7948
q19	1759	1534	1533	1533
q20	2929	1879	1858	1858
q21	7963	5527	5132	5132
q22	1158	1025	1061	1025
Total cold run time: 76158 ms
Total hot run time: 56383 ms

bobhan1 · 2024-08-08T06:15:51Z

run p1

bobhan1 · 2024-08-08T06:15:57Z

run cloud_p1

bobhan1 · 2024-08-08T06:17:03Z

run performance

dataroaring

LGTM

… in RocksDB in case of BE restart after a partial update has commited #38331" (#39035) picks #38331 and #39066

doris-robot · 2024-08-08T07:03:42Z

TPC-H: Total hot run time: 39520 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a5734e0f6ecfc7d4da791b17a18f542d13c69c6, data reload: false

------ Round 1 ----------------------------------
q1	17633	4949	4277	4277
q2	2021	186	193	186
q3	10460	1139	1117	1117
q4	10156	781	779	779
q5	7488	2517	2491	2491
q6	226	138	140	138
q7	956	598	597	597
q8	9224	1870	1884	1870
q9	8718	6536	6565	6536
q10	7089	2141	2225	2141
q11	465	241	255	241
q12	465	226	226	226
q13	17772	3019	2962	2962
q14	282	242	231	231
q15	529	478	477	477
q16	485	388	387	387
q17	951	639	736	639
q18	8214	7388	7400	7388
q19	6459	1076	1065	1065
q20	708	337	338	337
q21	5398	4442	4540	4442
q22	1099	993	1021	993
Total cold run time: 116798 ms
Total hot run time: 39520 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4511	4274	4305	4274
q2	370	268	263	263
q3	2827	2663	2656	2656
q4	2012	1771	1687	1687
q5	5596	5488	5431	5431
q6	217	138	135	135
q7	2119	1792	1776	1776
q8	3303	3415	3445	3415
q9	8687	8742	8783	8742
q10	3507	3287	3214	3214
q11	585	486	518	486
q12	795	649	629	629
q13	16132	3223	3209	3209
q14	303	290	291	290
q15	532	506	487	487
q16	494	435	431	431
q17	1800	1501	1527	1501
q18	7958	8016	7773	7773
q19	1721	1560	1515	1515
q20	2156	1908	1854	1854
q21	10193	5341	5228	5228
q22	1103	1026	1025	1025
Total cold run time: 76921 ms
Total hot run time: 56021 ms

bobhan1 · 2024-08-08T07:44:42Z

run performance

doris-robot · 2024-08-08T08:03:58Z

TPC-H: Total hot run time: 39808 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a5734e0f6ecfc7d4da791b17a18f542d13c69c6, data reload: false

------ Round 1 ----------------------------------
q1	5173	4418	4290	4290
q2	1514	176	183	176
q3	8771	1111	1096	1096
q4	10485	831	738	738
q5	7521	2489	2515	2489
q6	225	137	139	137
q7	963	593	591	591
q8	9215	1921	1908	1908
q9	8695	6573	6552	6552
q10	7031	2255	2213	2213
q11	445	247	248	247
q12	393	226	227	226
q13	18906	3006	3007	3006
q14	273	239	243	239
q15	544	494	490	490
q16	503	412	395	395
q17	987	675	729	675
q18	8226	7496	7430	7430
q19	4666	1045	1004	1004
q20	642	327	336	327
q21	5215	4695	4555	4555
q22	1123	1043	1024	1024
Total cold run time: 101516 ms
Total hot run time: 39808 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4491	4264	4217	4217
q2	377	262	275	262
q3	2839	2580	2562	2562
q4	1878	1588	1575	1575
q5	5271	5302	5294	5294
q6	215	133	130	130
q7	2040	1643	1656	1643
q8	3198	3334	3357	3334
q9	8467	8382	8408	8382
q10	3396	3105	3093	3093
q11	588	505	514	505
q12	769	589	590	589
q13	16837	3006	2954	2954
q14	314	259	263	259
q15	522	470	477	470
q16	490	425	417	417
q17	1792	1481	1496	1481
q18	7649	7370	7315	7315
q19	1686	1554	1552	1552
q20	1988	1777	1791	1777
q21	5347	5066	4935	4935
q22	1102	1022	1016	1016
Total cold run time: 71256 ms
Total hot run time: 53762 ms

doris-robot · 2024-08-08T08:16:35Z

TPC-DS: Total hot run time: 200707 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7a5734e0f6ecfc7d4da791b17a18f542d13c69c6, data reload: false

query1	949	404	391	391
query2	6461	1975	1916	1916
query3	6648	212	217	212
query4	34031	23438	22959	22959
query5	4183	475	486	475
query6	305	190	182	182
query7	4582	299	296	296
query8	245	197	203	197
query9	8624	2382	2356	2356
query10	923	926	874	874
query11	17763	14948	15091	14948
query12	144	96	96	96
query13	1636	403	366	366
query14	10189	7743	6182	6182
query15	352	339	314	314
query16	7712	505	520	505
query17	1732	565	538	538
query18	2062	377	371	371
query19	248	191	206	191
query20	114	103	102	102
query21	202	100	103	100
query22	4269	4188	3952	3952
query23	33805	33298	33297	33297
query24	11083	2849	2985	2849
query25	586	370	364	364
query26	942	150	145	145
query27	2294	285	279	279
query28	7227	1999	2000	1999
query29	808	412	397	397
query30	301	149	147	147
query31	961	743	748	743
query32	89	53	53	53
query33	748	285	280	280
query34	979	479	481	479
query35	993	862	841	841
query36	1075	928	902	902
query37	139	78	77	77
query38	4197	4147	4068	4068
query39	1448	1388	1404	1388
query40	190	112	113	112
query41	46	43	44	43
query42	117	94	99	94
query43	515	481	477	477
query44	1270	738	758	738
query45	392	384	395	384
query46	1142	792	774	774
query47	1848	1746	1781	1746
query48	379	300	294	294
query49	1050	411	424	411
query50	813	412	402	402
query51	6862	6731	6705	6705
query52	107	94	93	93
query53	258	183	187	183
query54	967	445	449	445
query55	78	74	74	74
query56	310	242	251	242
query57	1107	1077	1059	1059
query58	234	226	231	226
query59	3057	2685	2811	2685
query60	314	264	252	252
query61	100	97	94	94
query62	828	642	662	642
query63	210	184	188	184
query64	9351	2448	2030	2030
query65	3171	3117	3143	3117
query66	794	338	338	338
query67	15213	14766	14829	14766
query68	4567	553	558	553
query69	421	361	427	361
query70	1132	1130	1117	1117
query71	412	282	278	278
query72	18305	16352	17390	16352
query73	757	330	327	327
query74	9008	8813	8724	8724
query75	3400	2661	2700	2661
query76	2727	969	974	969
query77	484	329	331	329
query78	9999	9492	8973	8973
query79	2132	517	516	516
query80	2193	504	494	494
query81	621	280	228	228
query82	713	141	133	133
query83	290	142	145	142
query84	266	79	79	79
query85	2110	330	287	287
query86	468	305	296	296
query87	4706	4516	4425	4425
query88	3965	2509	2497	2497
query89	384	281	279	279
query90	1879	199	201	199
query91	138	119	115	115
query92	74	50	51	50
query93	2196	533	521	521
query94	844	293	295	293
query95	355	269	265	265
query96	610	278	283	278
query97	3231	3085	3065	3065
query98	226	199	193	193
query99	1712	1267	1268	1267
Total cold run time: 312097 ms
Total hot run time: 200707 ms

doris-robot · 2024-08-08T08:22:07Z

ClickBench: Total hot run time: 30.73 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7a5734e0f6ecfc7d4da791b17a18f542d13c69c6, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.03	0.04
query3	0.23	0.05	0.05
query4	1.66	0.10	0.10
query5	0.50	0.49	0.50
query6	1.14	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.55	0.50	0.50
query10	0.54	0.54	0.54
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.59	0.60	0.58
query14	0.76	0.77	0.78
query15	0.89	0.82	0.82
query16	0.37	0.37	0.38
query17	0.99	1.03	1.04
query18	0.22	0.21	0.22
query19	1.77	1.83	1.71
query20	0.02	0.01	0.01
query21	15.38	0.74	0.66
query22	4.51	6.90	1.98
query23	18.29	1.33	1.24
query24	2.10	0.22	0.21
query25	0.15	0.08	0.08
query26	0.31	0.20	0.21
query27	0.46	0.22	0.22
query28	13.29	1.02	1.00
query29	12.59	3.29	3.29
query30	0.25	0.06	0.05
query31	2.88	0.39	0.38
query32	3.28	0.48	0.46
query33	2.91	2.96	2.90
query34	16.94	4.36	4.35
query35	4.44	4.38	4.44
query36	0.66	0.47	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.05	0.04
Total cold run time: 109.91 s
Total hot run time: 30.73 s

… in RocksDB in case of BE restart after a partial update has commited #38331" (#39078) picks #38331 and #39066

…inter (#39066) fix member call on null pointer in #38331

…inter (apache#39066) fix member call on null pointer in apache#38331

…inter (#39066) fix member call on null pointer in #38331

… in RocksDB in case of BE restart after a partial update has commited apache#38331" (apache#39078) picks apache#38331 and apache#39066

github-actions bot added the doing label Aug 8, 2024

yiguolei reviewed Aug 8, 2024

View reviewed changes

Comment thread be/src/olap/txn_manager.cpp

fix

7a5734e

bobhan1 force-pushed the fix-ubsan-nullptr branch from 6037b6f to 7a5734e Compare August 8, 2024 02:42

bobhan1 requested a review from yiguolei August 8, 2024 02:43

zhannngchen approved these changes Aug 8, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2024

github-actions bot added the reviewed label Aug 8, 2024

dataroaring approved these changes Aug 8, 2024

View reviewed changes

zhannngchen pushed a commit that referenced this pull request Aug 8, 2024

[branch-2.1] Picks "[Fix](partial update) Persist partial_update_info…

1fbfb81

… in RocksDB in case of BE restart after a partial update has commited #38331" (#39035) picks #38331 and #39066

zhannngchen merged commit 7ead170 into apache:master Aug 8, 2024

dataroaring pushed a commit that referenced this pull request Aug 9, 2024

[branch-2.0] Picks "[Fix](partial update) Persist partial_update_info…

bf11d48

… in RocksDB in case of BE restart after a partial update has commited #38331" (#39078) picks #38331 and #39066

dataroaring added dev/2.0.15-merged dev/2.1.6-merged dev/3.0.x labels Aug 9, 2024

dataroaring pushed a commit that referenced this pull request Aug 11, 2024

[Fix](merge-on-write) Fix UBSan error cause by member call on null po…

4104b0e

…inter (#39066) fix member call on null pointer in #38331

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Aug 12, 2024

wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024

[Fix](merge-on-write) Fix UBSan error cause by member call on null po…

0e9e99c

…inter (apache#39066) fix member call on null pointer in apache#38331

dataroaring pushed a commit that referenced this pull request Aug 16, 2024

[Fix](merge-on-write) Fix UBSan error cause by member call on null po…

5ebb564

…inter (#39066) fix member call on null pointer in #38331

Conversation

bobhan1 commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

bobhan1 commented Aug 8, 2024

Uh oh!

github-actions bot commented Aug 8, 2024

Uh oh!

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

bobhan1 commented Aug 8, 2024

Uh oh!

github-actions bot commented Aug 8, 2024

Uh oh!

github-actions bot commented Aug 8, 2024

Uh oh!

github-actions bot commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

bobhan1 commented Aug 8, 2024

Uh oh!

bobhan1 commented Aug 8, 2024

Uh oh!

bobhan1 commented Aug 8, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

bobhan1 commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bobhan1 commented Aug 8, 2024 •

edited

Loading