[opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe by sollhui · Pull Request #38960 · apache/doris

sollhui · 2024-08-06T09:28:09Z

At present, the memory allocation of ByteBuffer is done through new char[capacity_]. Now, it is uniformly allocated by Allocator for the following purposes:

Better memory statistics
Better support for memory limit check

doris-robot · 2024-08-06T09:28:14Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

sollhui · 2024-08-06T09:28:18Z

run buildall

github-actions · 2024-08-06T09:34:56Z

clang-tidy review says "All clean, LGTM! 👍"

xinyiZzz

LGTM

github-actions · 2024-08-06T10:05:27Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-08-06T10:05:29Z

PR approved by anyone and no changes requested.

doris-robot · 2024-08-06T10:08:22Z

TPC-H: Total hot run time: 41429 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 25178c7eace53ea689b79ded5b167fcdb3d45104, data reload: false

------ Round 1 ----------------------------------
q1	17708	4076	4044	4044
q2	2022	200	194	194
q3	10469	1193	1341	1193
q4	10185	835	891	835
q5	7623	2994	2959	2959
q6	219	139	137	137
q7	1057	618	607	607
q8	9433	1884	1942	1884
q9	8443	6629	6570	6570
q10	8741	3814	3851	3814
q11	438	255	251	251
q12	409	228	238	228
q13	17758	2945	2924	2924
q14	272	249	245	245
q15	523	479	502	479
q16	534	384	381	381
q17	976	896	920	896
q18	7983	7259	7308	7259
q19	1397	1220	1220	1220
q20	560	339	331	331
q21	5324	4699	4729	4699
q22	353	279	287	279
Total cold run time: 112427 ms
Total hot run time: 41429 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4068	3995	4016	3995
q2	327	226	217	217
q3	2970	2976	3095	2976
q4	1990	2035	1981	1981
q5	5568	5499	5435	5435
q6	224	140	135	135
q7	2150	1783	1838	1783
q8	3306	3343	3339	3339
q9	8650	8592	8775	8592
q10	3909	4093	3906	3906
q11	589	468	462	462
q12	791	601	610	601
q13	16442	3094	3091	3091
q14	302	271	284	271
q15	532	481	484	481
q16	464	425	410	410
q17	1748	1725	1729	1725
q18	8184	7785	7739	7739
q19	2962	1761	1749	1749
q20	2012	1842	1854	1842
q21	5602	5450	5280	5280
q22	521	476	458	458
Total cold run time: 73311 ms
Total hot run time: 56468 ms

doris-robot · 2024-08-06T10:18:59Z

TPC-DS: Total hot run time: 168884 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 25178c7eace53ea689b79ded5b167fcdb3d45104, data reload: false

query1	918	375	367	367
query2	6485	1691	1690	1690
query3	6666	208	222	208
query4	20196	17556	17511	17511
query5	3646	506	506	506
query6	263	169	168	168
query7	4590	306	307	306
query8	255	206	195	195
query9	8533	2368	2356	2356
query10	436	271	274	271
query11	10546	10121	9993	9993
query12	119	92	89	89
query13	1632	394	385	385
query14	8245	6328	7244	6328
query15	220	165	166	165
query16	6980	440	479	440
query17	980	587	557	557
query18	1931	283	284	283
query19	203	153	150	150
query20	91	88	96	88
query21	205	101	106	101
query22	4262	4050	4134	4050
query23	33627	33917	33267	33267
query24	9482	3013	3048	3013
query25	680	412	413	412
query26	1496	149	153	149
query27	3049	278	290	278
query28	7644	2020	2025	2020
query29	1095	438	448	438
query30	244	213	149	149
query31	932	780	774	774
query32	100	55	60	55
query33	677	340	336	336
query34	953	482	500	482
query35	902	755	759	755
query36	1070	874	893	874
query37	210	81	88	81
query38	2896	2814	2787	2787
query39	889	809	808	808
query40	249	112	111	111
query41	47	44	43	43
query42	117	97	95	95
query43	465	430	457	430
query44	1187	732	737	732
query45	207	171	175	171
query46	1076	798	781	781
query47	1874	1739	1741	1739
query48	354	297	290	290
query49	900	429	426	426
query50	888	432	426	426
query51	6803	6740	6659	6659
query52	103	98	89	89
query53	254	188	186	186
query54	599	464	461	461
query55	75	70	73	70
query56	270	253	253	253
query57	1137	1032	1020	1020
query58	291	267	266	266
query59	2653	2368	2365	2365
query60	286	272	279	272
query61	99	121	94	94
query62	883	649	662	649
query63	209	176	182	176
query64	5749	1894	1858	1858
query65	3153	3081	3085	3081
query66	1038	333	330	330
query67	15079	14879	14748	14748
query68	4375	574	577	574
query69	614	374	315	315
query70	1094	1076	1066	1066
query71	382	285	281	281
query72	7085	2723	2478	2478
query73	772	328	334	328
query74	6063	5651	5701	5651
query75	3366	2750	2739	2739
query76	2147	1236	1269	1236
query77	427	307	314	307
query78	9470	8953	8783	8783
query79	1756	534	529	529
query80	905	513	507	507
query81	590	228	218	218
query82	631	130	132	130
query83	257	171	166	166
query84	263	81	79	79
query85	1260	318	304	304
query86	468	287	311	287
query87	3278	3156	3150	3150
query88	3849	2418	2415	2415
query89	375	294	289	289
query90	1719	191	198	191
query91	128	101	100	100
query92	59	53	50	50
query93	2019	621	619	619
query94	824	296	297	296
query95	388	273	280	273
query96	608	283	288	283
query97	3298	3075	3043	3043
query98	220	210	203	203
query99	1620	1340	1288	1288
Total cold run time: 259703 ms
Total hot run time: 168884 ms

doris-robot · 2024-08-06T10:24:29Z

ClickBench: Total hot run time: 30 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 25178c7eace53ea689b79ded5b167fcdb3d45104, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.06
query4	1.68	0.06	0.06
query5	0.48	0.48	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.57	0.53	0.53
query10	0.57	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.59
query14	0.77	0.81	0.79
query15	0.89	0.87	0.86
query16	0.35	0.36	0.35
query17	1.02	1.02	1.02
query18	0.21	0.21	0.22
query19	1.89	1.75	1.73
query20	0.01	0.00	0.01
query21	15.39	0.74	0.64
query22	4.07	7.64	1.37
query23	17.89	1.30	1.22
query24	2.26	0.22	0.22
query25	0.18	0.08	0.08
query26	0.32	0.21	0.22
query27	0.46	0.23	0.24
query28	13.15	1.01	0.98
query29	12.64	3.29	3.28
query30	0.26	0.06	0.06
query31	2.86	0.41	0.41
query32	3.25	0.48	0.49
query33	2.93	2.90	3.00
query34	15.44	4.24	4.26
query35	4.31	4.29	4.29
query36	0.68	0.48	0.48
query37	0.19	0.16	0.16
query38	0.17	0.15	0.15
query39	0.04	0.04	0.03
query40	0.16	0.14	0.13
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 107.77 s
Total hot run time: 30 s

sollhui · 2024-08-06T11:03:51Z

run buildall

github-actions · 2024-08-06T11:10:13Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-06T11:45:57Z

TPC-H: Total hot run time: 41825 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e4f3355db3ec2747ffb5e0b8c00d875f6aab7f1a, data reload: false

------ Round 1 ----------------------------------
q1	17698	4103	4060	4060
q2	2019	203	198	198
q3	10456	1335	1345	1335
q4	10157	844	930	844
q5	7575	2930	2976	2930
q6	218	140	138	138
q7	1067	614	621	614
q8	9428	1954	1961	1954
q9	8791	6633	6633	6633
q10	8759	3844	3822	3822
q11	430	261	259	259
q12	430	234	228	228
q13	17765	2921	2939	2921
q14	276	248	244	244
q15	528	494	492	492
q16	526	397	392	392
q17	986	961	930	930
q18	8005	7300	7219	7219
q19	2354	1217	1211	1211
q20	561	335	341	335
q21	5243	4779	4796	4779
q22	363	292	287	287
Total cold run time: 113635 ms
Total hot run time: 41825 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4098	4184	4034	4034
q2	329	216	216	216
q3	2990	3051	3132	3051
q4	1989	2030	1944	1944
q5	5610	5457	5455	5455
q6	220	133	130	130
q7	2152	1813	1810	1810
q8	3318	3362	3374	3362
q9	8630	8644	8759	8644
q10	3949	4053	3926	3926
q11	557	464	470	464
q12	780	635	593	593
q13	16296	3102	3136	3102
q14	301	277	290	277
q15	541	488	487	487
q16	453	408	417	408
q17	1796	1750	1748	1748
q18	8273	7717	7672	7672
q19	1736	1702	1728	1702
q20	2071	1861	1827	1827
q21	5704	5475	5438	5438
q22	535	448	476	448
Total cold run time: 72328 ms
Total hot run time: 56738 ms

doris-robot · 2024-08-06T11:56:37Z

TPC-DS: Total hot run time: 169861 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e4f3355db3ec2747ffb5e0b8c00d875f6aab7f1a, data reload: false

query1	910	366	372	366
query2	6459	1703	1759	1703
query3	6667	207	227	207
query4	19113	17445	17276	17276
query5	3644	502	519	502
query6	271	169	167	167
query7	4596	293	290	290
query8	279	187	190	187
query9	8520	2386	2341	2341
query10	429	287	263	263
query11	10656	10201	10210	10201
query12	125	89	89	89
query13	1639	376	370	370
query14	9314	7089	7885	7089
query15	213	162	158	158
query16	6956	434	485	434
query17	966	562	562	562
query18	1892	286	288	286
query19	192	149	143	143
query20	91	87	85	85
query21	205	109	104	104
query22	4346	3953	4062	3953
query23	33896	33699	33554	33554
query24	10111	3107	3067	3067
query25	702	415	418	415
query26	1627	150	158	150
query27	2885	282	290	282
query28	7198	2059	2010	2010
query29	1209	450	436	436
query30	239	156	151	151
query31	973	786	775	775
query32	101	56	58	56
query33	686	329	332	329
query34	967	482	525	482
query35	880	778	759	759
query36	1061	904	902	902
query37	271	81	82	81
query38	2905	2788	2811	2788
query39	901	820	827	820
query40	283	116	110	110
query41	45	48	44	44
query42	126	100	98	98
query43	464	426	441	426
query44	1194	721	739	721
query45	211	177	174	174
query46	1073	852	788	788
query47	1843	1751	1761	1751
query48	364	289	308	289
query49	1016	427	419	419
query50	908	430	439	430
query51	6758	6701	6619	6619
query52	94	95	87	87
query53	257	181	181	181
query54	600	457	454	454
query55	74	74	74	74
query56	269	244	259	244
query57	1113	1042	1045	1042
query58	266	274	274	274
query59	2627	2443	2421	2421
query60	300	283	270	270
query61	102	98	101	98
query62	890	644	654	644
query63	218	184	174	174
query64	5667	1881	1886	1881
query65	3197	3085	3089	3085
query66	1275	330	329	329
query67	15294	14837	14790	14790
query68	4322	556	570	556
query69	634	369	324	324
query70	1063	1064	1096	1064
query71	432	284	283	283
query72	7558	2680	2537	2537
query73	767	330	328	328
query74	6035	5690	5616	5616
query75	3397	2714	2724	2714
query76	2905	1191	1290	1191
query77	563	306	315	306
query78	9401	8833	8915	8833
query79	2171	529	533	529
query80	939	513	502	502
query81	564	226	227	226
query82	869	130	134	130
query83	256	169	168	168
query84	278	84	79	79
query85	1232	320	319	319
query86	453	304	297	297
query87	3296	3124	3195	3124
query88	2928	2384	2395	2384
query89	380	281	291	281
query90	1794	191	188	188
query91	127	104	107	104
query92	63	48	54	48
query93	1832	625	622	622
query94	789	297	303	297
query95	390	277	273	273
query96	601	286	280	280
query97	3212	3054	3062	3054
query98	231	201	197	197
query99	1565	1277	1257	1257
Total cold run time: 261670 ms
Total hot run time: 169861 ms

doris-robot · 2024-08-06T12:02:07Z

ClickBench: Total hot run time: 30.24 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e4f3355db3ec2747ffb5e0b8c00d875f6aab7f1a, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.04
query4	1.68	0.06	0.06
query5	0.49	0.48	0.47
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.58	0.52	0.51
query10	0.55	0.56	0.58
query11	0.16	0.12	0.12
query12	0.14	0.12	0.13
query13	0.60	0.60	0.60
query14	0.77	0.78	0.80
query15	0.93	0.85	0.84
query16	0.35	0.35	0.38
query17	0.98	0.99	1.00
query18	0.23	0.21	0.22
query19	1.82	1.77	1.73
query20	0.01	0.02	0.01
query21	15.41	0.73	0.65
query22	4.03	7.31	1.57
query23	18.18	1.29	1.31
query24	2.25	0.22	0.22
query25	0.19	0.09	0.08
query26	0.33	0.22	0.22
query27	0.46	0.23	0.24
query28	13.18	0.99	0.96
query29	12.54	3.32	3.31
query30	0.26	0.06	0.06
query31	2.88	0.40	0.40
query32	3.24	0.50	0.48
query33	2.91	2.98	2.96
query34	15.44	4.21	4.27
query35	4.25	4.29	4.29
query36	0.68	0.48	0.49
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.12	0.14
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 107.81 s
Total hot run time: 30.24 s

sollhui · 2024-08-06T12:16:42Z

run buildall

github-actions

clang-tidy made some suggestions

doris-robot · 2024-08-06T12:39:34Z

TPC-H: Total hot run time: 41622 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit df75d02bfd70f83f919051299cb29d7a7aa774d7, data reload: false

------ Round 1 ----------------------------------
q1	18050	4295	4162	4162
q2	2129	227	204	204
q3	10672	1266	1342	1266
q4	10167	834	874	834
q5	7607	2955	2946	2946
q6	223	135	136	135
q7	1061	634	616	616
q8	9448	1816	1935	1816
q9	8360	6572	6575	6572
q10	8690	3815	3851	3815
q11	430	254	248	248
q12	403	227	230	227
q13	17770	2969	2909	2909
q14	274	236	243	236
q15	521	481	506	481
q16	494	400	388	388
q17	951	952	930	930
q18	8048	7365	7261	7261
q19	1392	1217	1203	1203
q20	583	318	340	318
q21	5288	4769	4788	4769
q22	353	291	286	286
Total cold run time: 112914 ms
Total hot run time: 41622 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4010	4011	4008	4008
q2	324	223	220	220
q3	2975	2984	3002	2984
q4	1883	1871	1839	1839
q5	5199	5238	5226	5226
q6	213	128	128	128
q7	2025	1680	1697	1680
q8	3175	3270	3231	3231
q9	8299	8211	8262	8211
q10	3756	3859	3801	3801
q11	541	460	445	445
q12	717	564	530	530
q13	12886	2939	2962	2939
q14	279	254	258	254
q15	516	477	483	477
q16	470	400	397	397
q17	1723	1693	1684	1684
q18	7718	7347	7144	7144
q19	1679	1665	1670	1665
q20	1955	1745	1742	1742
q21	5390	5175	5241	5175
q22	524	451	445	445
Total cold run time: 66257 ms
Total hot run time: 54225 ms

doris-robot · 2024-08-06T12:50:13Z

TPC-DS: Total hot run time: 168590 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit df75d02bfd70f83f919051299cb29d7a7aa774d7, data reload: false

query1	917	373	380	373
query2	6483	1706	1727	1706
query3	6666	219	221	219
query4	20274	17675	17433	17433
query5	4285	532	550	532
query6	285	182	193	182
query7	4624	304	291	291
query8	267	198	197	197
query9	8535	2379	2370	2370
query10	463	287	272	272
query11	10430	9977	9935	9935
query12	142	87	90	87
query13	1640	383	372	372
query14	9099	6854	6906	6854
query15	217	163	161	161
query16	7112	473	437	437
query17	947	546	536	536
query18	1902	278	280	278
query19	196	145	139	139
query20	94	85	86	85
query21	205	102	101	101
query22	4308	4102	4023	4023
query23	33691	32770	32694	32694
query24	10335	3094	3053	3053
query25	674	397	381	381
query26	1781	150	152	150
query27	2907	277	280	277
query28	6948	1982	1977	1977
query29	1348	410	406	406
query30	288	150	152	150
query31	928	751	759	751
query32	99	56	55	55
query33	706	310	347	310
query34	908	469	476	469
query35	849	748	737	737
query36	997	876	849	849
query37	284	82	79	79
query38	2858	2792	2765	2765
query39	882	821	812	812
query40	285	113	116	113
query41	49	44	45	44
query42	123	103	105	103
query43	487	415	424	415
query44	1155	720	733	720
query45	209	179	178	178
query46	1089	830	797	797
query47	1796	1701	1715	1701
query48	360	300	287	287
query49	1196	435	430	430
query50	908	441	428	428
query51	6880	6754	6729	6729
query52	103	91	98	91
query53	257	187	182	182
query54	678	448	473	448
query55	81	75	74	74
query56	285	251	282	251
query57	1155	1030	1057	1030
query58	286	272	282	272
query59	2682	2464	2407	2407
query60	298	279	287	279
query61	98	96	116	96
query62	915	663	636	636
query63	219	193	183	183
query64	5919	1908	1879	1879
query65	3181	3123	3087	3087
query66	1454	342	337	337
query67	15329	14668	14860	14668
query68	4314	568	563	563
query69	442	314	294	294
query70	1125	1121	1085	1085
query71	386	279	280	279
query72	7092	2731	2506	2506
query73	765	331	333	331
query74	5985	5612	5622	5612
query75	3399	2763	2826	2763
query76	2436	1198	1286	1198
query77	443	308	318	308
query78	9502	8949	8900	8900
query79	1784	528	538	528
query80	1222	514	503	503
query81	579	228	229	228
query82	1149	137	138	137
query83	253	178	180	178
query84	282	82	79	79
query85	1299	316	304	304
query86	415	329	296	296
query87	3251	3130	3074	3074
query88	2912	2443	2441	2441
query89	402	293	298	293
query90	1808	194	199	194
query91	129	105	103	103
query92	63	54	51	51
query93	1474	622	615	615
query94	915	305	297	297
query95	385	350	267	267
query96	609	283	286	283
query97	3237	3055	3074	3055
query98	207	200	197	197
query99	1636	1291	1265	1265
Total cold run time: 262951 ms
Total hot run time: 168590 ms

doris-robot · 2024-08-06T12:55:42Z

ClickBench: Total hot run time: 29.84 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit df75d02bfd70f83f919051299cb29d7a7aa774d7, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.69	0.07	0.07
query5	0.48	0.49	0.49
query6	1.16	0.71	0.72
query7	0.02	0.01	0.02
query8	0.04	0.05	0.04
query9	0.56	0.50	0.52
query10	0.57	0.57	0.56
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.77	0.80	0.79
query15	0.90	0.85	0.85
query16	0.35	0.36	0.34
query17	0.98	1.02	0.98
query18	0.22	0.21	0.22
query19	1.88	1.71	1.73
query20	0.01	0.00	0.00
query21	15.43	0.74	0.65
query22	4.78	6.47	1.20
query23	17.94	1.38	1.34
query24	2.23	0.23	0.21
query25	0.18	0.08	0.08
query26	0.32	0.22	0.22
query27	0.45	0.23	0.23
query28	13.21	1.00	0.96
query29	12.60	3.30	3.29
query30	0.25	0.06	0.05
query31	2.87	0.41	0.40
query32	3.25	0.50	0.48
query33	2.94	2.90	2.94
query34	15.44	4.28	4.26
query35	4.27	4.27	4.30
query36	0.67	0.48	0.48
query37	0.18	0.16	0.17
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.17	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.05
Total cold run time: 108.47 s
Total hot run time: 29.84 s

sollhui · 2024-08-06T13:23:42Z

run buildall

github-actions · 2024-08-06T13:30:20Z

clang-tidy review says "All clean, LGTM! 👍"

sollhui · 2024-08-06T16:10:03Z

run buildall

github-actions · 2024-08-06T16:16:44Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-08-06T16:33:01Z

TPC-H: Total hot run time: 41470 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a59dfb7dbd60dc1181c7034e9286546816fdb672, data reload: false

------ Round 1 ----------------------------------
q1	17606	4163	4061	4061
q2	2012	199	199	199
q3	10454	1242	1334	1242
q4	10178	815	950	815
q5	7759	3050	3017	3017
q6	227	142	143	142
q7	1070	640	634	634
q8	9814	1885	1955	1885
q9	8470	6576	6597	6576
q10	8703	3844	3812	3812
q11	426	246	256	246
q12	409	232	230	230
q13	17753	2935	2915	2915
q14	272	246	245	245
q15	537	482	494	482
q16	490	398	393	393
q17	963	918	932	918
q18	8036	7314	7151	7151
q19	1394	1199	1224	1199
q20	562	322	351	322
q21	5386	4725	4705	4705
q22	353	288	281	281
Total cold run time: 112874 ms
Total hot run time: 41470 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4055	4015	4016	4015
q2	333	224	222	222
q3	3004	3022	2998	2998
q4	1872	1845	1850	1845
q5	5205	5206	5219	5206
q6	215	131	134	131
q7	2048	1694	1678	1678
q8	3210	3239	3251	3239
q9	8354	8255	8293	8255
q10	3721	3795	3826	3795
q11	538	453	446	446
q12	700	574	558	558
q13	14242	2940	2914	2914
q14	289	251	256	251
q15	520	488	475	475
q16	444	394	396	394
q17	1717	1691	1692	1691
q18	7776	7359	7274	7274
q19	1660	1675	1655	1655
q20	1982	1779	1757	1757
q21	5410	5320	5075	5075
q22	529	459	453	453
Total cold run time: 67824 ms
Total hot run time: 54327 ms

sollhui · 2024-08-08T09:25:22Z

run buildall

doris-robot · 2024-08-08T10:08:29Z

TPC-H: Total hot run time: 39161 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17fa2c3d18ca1516d71e7afab802a9a8bd291503, data reload: false

------ Round 1 ----------------------------------
q1	17621	4339	4248	4248
q2	2020	176	185	176
q3	10479	1128	1180	1128
q4	10132	750	723	723
q5	7496	2541	2525	2525
q6	220	136	138	136
q7	973	584	583	583
q8	9211	1903	1923	1903
q9	8753	6554	6504	6504
q10	7026	2153	2167	2153
q11	449	238	244	238
q12	464	218	219	218
q13	17754	2994	2955	2955
q14	275	243	246	243
q15	514	480	494	480
q16	509	389	377	377
q17	957	720	727	720
q18	7955	7441	7315	7315
q19	3504	1086	1005	1005
q20	652	326	328	326
q21	5208	4339	4220	4220
q22	1129	993	985	985
Total cold run time: 113301 ms
Total hot run time: 39161 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4376	4249	4244	4244
q2	368	273	271	271
q3	2833	2587	2539	2539
q4	1885	1720	1696	1696
q5	5529	5609	5486	5486
q6	224	136	131	131
q7	2139	1754	1705	1705
q8	3217	3443	3385	3385
q9	8779	8719	8776	8719
q10	3547	3278	3293	3278
q11	608	502	493	493
q12	827	611	604	604
q13	17064	3147	3150	3147
q14	330	299	285	285
q15	530	485	503	485
q16	498	436	447	436
q17	1820	1556	1524	1524
q18	8097	7902	7773	7773
q19	3692	1691	1559	1559
q20	2148	1925	1888	1888
q21	5546	5300	5190	5190
q22	1113	1018	1077	1018
Total cold run time: 75170 ms
Total hot run time: 55856 ms

doris-robot · 2024-08-08T10:21:21Z

TPC-DS: Total hot run time: 202548 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17fa2c3d18ca1516d71e7afab802a9a8bd291503, data reload: false

query1	972	422	381	381
query2	6433	2055	1931	1931
query3	6633	206	218	206
query4	33566	23178	23006	23006
query5	3608	475	495	475
query6	262	175	194	175
query7	4574	290	292	290
query8	247	205	202	202
query9	8613	2394	2365	2365
query10	964	900	919	900
query11	17855	14906	14969	14906
query12	134	99	97	97
query13	1656	393	388	388
query14	10556	7499	7701	7499
query15	404	325	331	325
query16	7678	446	450	446
query17	1483	585	590	585
query18	2055	412	411	411
query19	267	207	221	207
query20	120	110	115	110
query21	208	115	108	108
query22	4537	4465	4348	4348
query23	34163	33581	33669	33581
query24	9838	3082	2950	2950
query25	568	388	383	383
query26	699	149	152	149
query27	2121	280	290	280
query28	5908	2029	2024	2024
query29	802	415	415	415
query30	258	156	152	152
query31	962	770	747	747
query32	98	54	56	54
query33	619	289	286	286
query34	846	475	480	475
query35	940	846	805	805
query36	1071	928	917	917
query37	136	81	80	80
query38	4273	4141	4140	4140
query39	1435	1378	1393	1378
query40	209	121	196	121
query41	45	44	42	42
query42	118	95	93	93
query43	527	480	483	480
query44	1134	732	731	731
query45	413	381	368	368
query46	1115	777	774	774
query47	1824	1803	1750	1750
query48	384	308	307	307
query49	846	416	436	416
query50	796	406	403	403
query51	6838	6684	6671	6671
query52	100	86	87	86
query53	252	183	180	180
query54	769	442	438	438
query55	74	75	75	75
query56	253	248	238	238
query57	1108	1060	1056	1056
query58	214	226	222	222
query59	3101	2939	2725	2725
query60	285	257	257	257
query61	94	93	93	93
query62	761	646	624	624
query63	209	177	179	177
query64	9242	2425	1946	1946
query65	3197	3104	3125	3104
query66	741	326	326	326
query67	15475	14943	14731	14731
query68	6287	545	550	545
query69	450	375	399	375
query70	1192	1111	1093	1093
query71	547	264	264	264
query72	19831	16117	16552	16117
query73	823	326	331	326
query74	9143	8715	8669	8669
query75	4392	2648	2652	2648
query76	4111	1008	981	981
query77	797	310	306	306
query78	13063	9538	8967	8967
query79	11338	555	526	526
query80	939	494	499	494
query81	588	222	223	222
query82	431	136	132	132
query83	297	147	142	142
query84	270	82	77	77
query85	698	301	296	296
query86	462	272	295	272
query87	4628	4517	4598	4517
query88	5623	2518	2497	2497
query89	412	277	290	277
query90	1948	199	195	195
query91	145	120	125	120
query92	59	51	52	51
query93	3799	536	532	532
query94	914	285	258	258
query95	351	267	309	267
query96	604	275	284	275
query97	3227	3077	3057	3057
query98	230	204	202	202
query99	1535	1273	1237	1237
Total cold run time: 326820 ms
Total hot run time: 202548 ms

doris-robot · 2024-08-08T10:26:53Z

ClickBench: Total hot run time: 30.91 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17fa2c3d18ca1516d71e7afab802a9a8bd291503, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.66	0.09	0.10
query5	0.51	0.49	0.49
query6	1.12	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.48	0.48
query10	0.54	0.53	0.53
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.62	0.59
query14	0.74	0.78	0.78
query15	0.84	0.81	0.80
query16	0.36	0.36	0.37
query17	0.97	0.95	0.95
query18	0.22	0.21	0.21
query19	1.77	1.69	1.67
query20	0.01	0.01	0.01
query21	15.39	0.75	0.65
query22	4.07	7.35	2.39
query23	18.31	1.37	1.25
query24	2.04	0.23	0.23
query25	0.15	0.09	0.07
query26	0.30	0.20	0.21
query27	0.46	0.22	0.23
query28	13.32	1.02	1.00
query29	12.61	3.31	3.26
query30	0.24	0.05	0.04
query31	2.88	0.38	0.38
query32	3.30	0.48	0.47
query33	2.90	2.90	2.87
query34	17.10	4.35	4.46
query35	4.40	4.40	4.42
query36	0.66	0.46	0.46
query37	0.18	0.15	0.15
query38	0.15	0.16	0.15
query39	0.04	0.04	0.03
query40	0.15	0.13	0.12
query41	0.09	0.04	0.05
query42	0.07	0.06	0.04
query43	0.05	0.04	0.04
Total cold run time: 109.48 s
Total hot run time: 30.91 s

xinyiZzz

LGTM

github-actions · 2024-08-08T14:41:47Z

PR approved by at least one committer and no changes requested.

dataroaring

LGTM

… exception safe (apache#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check

… exception safe (#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check

… exception safe (apache#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check

) fix allocate size improper in append_and_flush introduced by #38960

… exception safe (apache#38960) At present, the memory allocation of `ByteBuffer` is done through `new char[capacity_]`. Now, it is uniformly allocated by `Allocator` for the following purposes: 1. Better memory statistics 2. Better support for memory limit check

…ns is equal to 0 (#40850) pick #38960 #39908 #40043 #40092 #40016 #40439 --------- Co-authored-by: hui lai <1353307710@qq.com> Co-authored-by: yiguolei <676222867@qq.com>

) (#41133) pick (#40613) fix allocate size improper in append_and_flush introduced by #38960

) fix allocate size improper in append_and_flush introduced by #38960

github-actions Bot added the doing label Aug 6, 2024

xinyiZzz previously approved these changes Aug 6, 2024

View reviewed changes

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 6, 2024

github-actions Bot added the reviewed label Aug 6, 2024

sollhui marked this pull request as draft August 6, 2024 10:49

sollhui dismissed xinyiZzz’s stale review via e4f3355 August 6, 2024 11:03

github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Aug 6, 2024

github-actions Bot reviewed Aug 6, 2024

View reviewed changes

Comment thread be/src/util/byte_buffer.h

xinyiZzz approved these changes Aug 8, 2024

View reviewed changes

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2024

dataroaring approved these changes Aug 11, 2024

View reviewed changes

dataroaring added dev/2.1.x dev/3.0.x labels Aug 11, 2024

liaoxin01 approved these changes Aug 12, 2024

View reviewed changes

xinyiZzz merged commit 86246f7 into apache:master Aug 12, 2024

dataroaring added dev/3.0.2-merged and removed dev/3.0.x labels Aug 17, 2024

sollhui mentioned this pull request Aug 18, 2024

[opt](bytebuffer) allocate ByteBuffer memory by Allocator and make it exception safe (#38960) #39524

Closed

yiguolei mentioned this pull request Sep 9, 2024

pick exception handle logic to 2.1 #40547

Closed

xinyiZzz mentioned this pull request Sep 9, 2024

[branch-2.1](memory) Pick query memory tracker value is equal to 0 and exception handle #40564

Closed

sollhui mentioned this pull request Sep 10, 2024

[fix](bytebuffer) fix allocate size improper in append_and_flush #40613

Merged

liaoxin01 pushed a commit that referenced this pull request Sep 11, 2024

[fix](bytebuffer) fix allocate size improper in append_and_flush (#40613

e65d559

) fix allocate size improper in append_and_flush introduced by #38960

xinyiZzz mentioned this pull request Sep 14, 2024

[branch-2.1](memory) When Load ends, check memory tracker value returns is equal to 0 #40850

Merged

liaoxin01 added dev/2.1.7-merged and removed dev/2.1.x labels Sep 19, 2024

sollhui mentioned this pull request Sep 23, 2024

[fix](bytebuffer) fix allocate size improper in append_and_flush (#40613) #41133

Merged

yiguolei pushed a commit that referenced this pull request Sep 24, 2024

[fix](bytebuffer) fix allocate size improper in append_and_flush (#40613

d7659ff

) (#41133) pick (#40613) fix allocate size improper in append_and_flush introduced by #38960

dataroaring pushed a commit that referenced this pull request Oct 9, 2024

[fix](bytebuffer) fix allocate size improper in append_and_flush (#40613

92a0b00

) fix allocate size improper in append_and_flush introduced by #38960

Conversation

sollhui commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

sollhui commented Aug 6, 2024

Uh oh!

github-actions Bot commented Aug 6, 2024

Uh oh!

xinyiZzz left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 6, 2024

Uh oh!

github-actions Bot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

sollhui commented Aug 6, 2024

Uh oh!

github-actions Bot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

sollhui commented Aug 6, 2024

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

sollhui commented Aug 6, 2024

Uh oh!

github-actions Bot commented Aug 6, 2024

Uh oh!

sollhui commented Aug 6, 2024

Uh oh!

github-actions Bot commented Aug 6, 2024

Uh oh!

doris-robot commented Aug 6, 2024

Uh oh!

sollhui commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

doris-robot commented Aug 8, 2024

Uh oh!

xinyiZzz left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 8, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sollhui commented Aug 6, 2024 •

edited

Loading