[fix](function) Fix wrong nullable processing for convert_tz#38764
Merged
zhangstar333 merged 1 commit intoapache:masterfrom Aug 5, 2024
Merged
[fix](function) Fix wrong nullable processing for convert_tz#38764zhangstar333 merged 1 commit intoapache:masterfrom
zhangstar333 merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Mryange
approved these changes
Aug 2, 2024
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 42172 ms |
TPC-DS: Total hot run time: 168978 ms |
ClickBench: Total hot run time: 30.08 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
dataroaring
pushed a commit
that referenced
this pull request
Aug 6, 2024
## Proposed changes Issue Number: close #xxx This pr make `convert_tz` use default nullity processing logic rather than `update_null_map` manually to get correct result. The bug of `update_null_map` will be fixed by #38787 before: ```sql mysql> select convert_tz(dt, '+00:00', IF(property_value IS NULL, '+00:00', property_value)) from cvt_tz; +--------------------------------------------------------------------------------+ | convert_tz(dt, '+00:00', if(property_value IS NULL, '+00:00', property_value)) | +--------------------------------------------------------------------------------+ | 2024-04-18 23:20:00 | | | | | | 2024-04-18 23:20:00 | | | | | | 2024-04-18 23:20:00 | | | | 2024-04-18 23:20:00 | | | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | | | | | 2024-04-18 23:20:00 | | | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | | | 2024-04-18 23:20:00 | +--------------------------------------------------------------------------------+ ``` after: ```sql mysql> select convert_tz(dt, '+00:00', IF(property_value IS NULL, '+00:00', property_value)) from cvt_tz; +--------------------------------------------------------------------------------+ | convert_tz(dt, '+00:00', if(property_value IS NULL, '+00:00', property_value)) | +--------------------------------------------------------------------------------+ | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | | 2024-04-18 23:20:00 | +--------------------------------------------------------------------------------+ ```
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
This pr make
convert_tzuse default nullity processing logic rather thanupdate_null_mapmanually to get correct result. The bug ofupdate_null_mapwill be fixed by #38787before:
after: