[fix](compaction) disable cumu delete rowset from performing ordered data compaction#38742
Merged
dataroaring merged 2 commits intoapache:masterfrom Aug 4, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Aug 1, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run ShellCheck |
TPC-H: Total hot run time: 41720 ms |
TPC-DS: Total hot run time: 167921 ms |
ClickBench: Total hot run time: 29.83 s |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41436 ms |
TPC-DS: Total hot run time: 170374 ms |
ClickBench: Total hot run time: 30.44 s |
dataroaring
pushed a commit
that referenced
this pull request
Aug 4, 2024
…data compaction (#38742) ## problem When enable_delete_when_cumu_compaction = true, multiple delete rowsets may be merged into an empty data rowset through ordered data compaction, causing the delete predicate to be lost.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
When enable_delete_when_cumu_compaction = true, multiple delete rowsets may be merged into an empty data rowset through ordered data compaction, causing the delete predicate to be lost.