[improvement](file cache) Try to read from remote storage when opening segment with CachedRemoteFileReader#38645
Merged
gavinchou merged 4 commits intoapache:masterfrom Aug 6, 2024
Conversation
…g segment with CachedRemoteFileReader We may encounter the error "Bad segment" file in some rare cases that the file cache may not hold the correct segment files. We should try to read the remote original segment files to increase robustness.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 41256 ms |
TPC-DS: Total hot run time: 170071 ms |
ClickBench: Total hot run time: 29.75 s |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
platoneko
previously approved these changes
Aug 1, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41580 ms |
TPC-DS: Total hot run time: 169508 ms |
ClickBench: Total hot run time: 29.81 s |
282a513 to
c8a5823
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41598 ms |
TPC-DS: Total hot run time: 168954 ms |
ClickBench: Total hot run time: 29.99 s |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
TPC-H: Total hot run time: 41402 ms |
TPC-DS: Total hot run time: 168959 ms |
ClickBench: Total hot run time: 29.85 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 7, 2024
…g segment with CachedRemoteFileReader (#38645) We may encounter the error "Bad segment" file in some rare cases where the file cache may not hold the correct segment files. We should read the remote original segment files to increase robustness.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may encounter the error "Bad segment" file in some rare cases where the file cache may not hold the correct segment files. We should read the remote original segment files to increase robustness.