[fix](SSL) Correctly close SSL connections#38587
Merged
dataroaring merged 1 commit intoapache:masterfrom Jul 31, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Yukang-Lian
approved these changes
Jul 31, 2024
Collaborator
Author
|
run buildall |
Contributor
|
PR approved by anyone and no changes requested. |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run feut |
TPC-H: Total hot run time: 41763 ms |
TPC-DS: Total hot run time: 169204 ms |
ClickBench: Total hot run time: 29.96 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Aug 1, 2024
## Proposed changes Issue Number: close apache#38590 If SSL connection closed, a specified packet will sent to indicate the closing of connection. The SSL engine will be shut down and output an empty unwrapped result. Therefore, handle this case correctly to avoid buffer overflow by breaking the reading flow and do the cleanup stuff initiatively.
dataroaring
pushed a commit
that referenced
this pull request
Aug 1, 2024
## Proposed changes Issue Number: close #38590 If SSL connection closed, a specified packet will sent to indicate the closing of connection. The SSL engine will be shut down and output an empty unwrapped result. Therefore, handle this case correctly to avoid buffer overflow by breaking the reading flow and do the cleanup stuff initiatively.
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 9, 2024
## Proposed changes Issue Number: close apache#38590 If SSL connection closed, a specified packet will sent to indicate the closing of connection. The SSL engine will be shut down and output an empty unwrapped result. Therefore, handle this case correctly to avoid buffer overflow by breaking the reading flow and do the cleanup stuff initiatively.
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
## Proposed changes Issue Number: close #38590 If SSL connection closed, a specified packet will sent to indicate the closing of connection. The SSL engine will be shut down and output an empty unwrapped result. Therefore, handle this case correctly to avoid buffer overflow by breaking the reading flow and do the cleanup stuff initiatively.
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Aug 14, 2024
This reverts commit a03a1c2.
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Proposed changes Issue Number: close #38590 If SSL connection closed, a specified packet will sent to indicate the closing of connection. The SSL engine will be shut down and output an empty unwrapped result. Therefore, handle this case correctly to avoid buffer overflow by breaking the reading flow and do the cleanup stuff initiatively.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #38590
If SSL connection closed, a specified packet will sent to indicate the closing of connection. The SSL engine will be shut down and output an empty unwrapped result.
Therefore, handle this case correctly to avoid buffer overflow by breaking the reading flow and do the cleanup stuff initiatively.