(cloud-merge) Fix the coredump because of change_cache_type to origin_type#38518
Merged
gavinchou merged 2 commits intoapache:masterfrom Jul 31, 2024
Merged
(cloud-merge) Fix the coredump because of change_cache_type to origin_type#38518gavinchou merged 2 commits intoapache:masterfrom
gavinchou merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| fs::create_directories(cache_base_path); | ||
| auto sp = SyncPoint::get_instance(); | ||
| sp->set_call_back("FileBlock::change_cache_type", [](auto&& args) { |
Contributor
There was a problem hiding this comment.
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
Suggested change
| sp->set_call_back("FileBlock::change_cache_type", [](auto&& args) { | |
| h);auto * |
| } | ||
|
|
||
| TEST_F(BlockFileCacheTest, change_cache_type2) { | ||
| if (fs::exists(cache_base_path)) { |
Contributor
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
^Additional context
be/test/io/cache/block_file_cache_test.cpp:4395: 86 lines including whitespace and comments (threshold 80)
^| } | ||
| fs::create_directories(cache_base_path); | ||
| auto sp = SyncPoint::get_instance(); | ||
| sp->set_call_back("FileBlock::change_cache_type", [](auto&& args) { |
Contributor
There was a problem hiding this comment.
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
Suggested change
| sp->set_call_back("FileBlock::change_cache_type", [](auto&& args) { | |
| h);auto * |
| fs::remove_all(cache_base_path); | ||
| } | ||
| fs::create_directories(cache_base_path); | ||
| auto sp = SyncPoint::get_instance(); |
Contributor
There was a problem hiding this comment.
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
Suggested change
| auto sp = SyncPoint::get_instance(); | |
| h);auto * |
| } | ||
| } | ||
|
|
||
| TEST_F(BlockFileCacheTest, change_cache_type2) { |
Contributor
There was a problem hiding this comment.
warning: function 'TEST_F' exceeds recommended size/complexity thresholds [readability-function-size]
^Additional context
be/test/io/cache/block_file_cache_test.cpp:4394: 86 lines including whitespace and comments (threshold 80)
^| fs::remove_all(cache_base_path); | ||
| } | ||
| fs::create_directories(cache_base_path); | ||
| auto sp = SyncPoint::get_instance(); |
Contributor
There was a problem hiding this comment.
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
Suggested change
| auto sp = SyncPoint::get_instance(); | |
| h);auto * |
TPC-H: Total hot run time: 41802 ms |
TPC-DS: Total hot run time: 169618 ms |
ClickBench: Total hot run time: 30.7 s |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run cloud_p1 |
gavinchou
approved these changes
Jul 30, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Lchangliang
force-pushed
the
dev-0725-coredump
branch
from
ff8b957 to
8dfbaa2
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41733 ms |
TPC-DS: Total hot run time: 168317 ms |
ClickBench: Total hot run time: 30.18 s |
Contributor
Author
|
run p0 |
dataroaring
pushed a commit
that referenced
this pull request
Aug 2, 2024
…_type (#38518) When call method `change_cache_type_by_mgr`, if the cache_type is same as change_type, it will return true directly and execute the next codes and break the old assumptions.
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 9, 2024
…_type (apache#38518) When call method `change_cache_type_by_mgr`, if the cache_type is same as change_type, it will return true directly and execute the next codes and break the old assumptions.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When call method
change_cache_type_by_mgr, if the cache_type is same as change_type, it will return true directly and execute the next codes and break the old assumptions.