[fix](mtmv) Choose a valid partition column when there are both valid and invalid expressions#38367
Merged
morrySnow merged 4 commits intoapache:masterfrom Jul 31, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
Will add regression tests later |
Member
|
Could you add some tests for this fix? Partition track test is all in |
Member
|
run buildall |
TPC-H: Total hot run time: 39528 ms |
TPC-DS: Total hot run time: 173764 ms |
ClickBench: Total hot run time: 30.8 s |
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39849 ms |
TPC-DS: Total hot run time: 173656 ms |
ClickBench: Total hot run time: 30.86 s |
added 3 commits
July 29, 2024 22:36
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41513 ms |
TPC-DS: Total hot run time: 168628 ms |
ClickBench: Total hot run time: 29.81 s |
Contributor
Author
|
@seawinde hello, this PR is ready, do you have time to take a look? |
seawinde
reviewed
Jul 30, 2024
seawinde
reviewed
Jul 30, 2024
Contributor
Author
|
run buildall |
Member
|
LGTM! |
seawinde
approved these changes
Jul 30, 2024
TPC-H: Total hot run time: 41595 ms |
TPC-DS: Total hot run time: 169330 ms |
ClickBench: Total hot run time: 30.24 s |
Contributor
Author
|
run feut |
Contributor
|
run cloud_p0 |
morrySnow
approved these changes
Jul 31, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
liutang123
added a commit
to liutang123/doris
that referenced
this pull request
Aug 1, 2024
… and invalid expressions (apache#38367) Choose a partition column when there are both valid and invalid expressions.
dataroaring
pushed a commit
that referenced
this pull request
Aug 2, 2024
… and invalid expressions (#38367) Choose a partition column when there are both valid and invalid expressions.
feiniaofeiafei
pushed a commit
to feiniaofeiafei/doris
that referenced
this pull request
Aug 9, 2024
… and invalid expressions (apache#38367) Choose a partition column when there are both valid and invalid expressions.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Choose a partition column when there are both valid and invalid expressions.
Issue Number: close #38366