[fix](nerieds) avoid redundant enumeration same LogicalProject in memo#38317
Merged
morrySnow merged 1 commit intoapache:masterfrom Jul 29, 2024
Merged
[fix](nerieds) avoid redundant enumeration same LogicalProject in memo#38317morrySnow merged 1 commit intoapache:masterfrom
morrySnow merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39443 ms |
TPC-DS: Total hot run time: 171186 ms |
ClickBench: Total hot run time: 30.92 s |
morrySnow
force-pushed
the
exploration_space
branch
from
5749ce5 to
99517db
Compare
Contributor
Author
|
run buildall |
morrySnow
force-pushed
the
exploration_space
branch
from
99517db to
49b2ee9
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39914 ms |
TPC-DS: Total hot run time: 170295 ms |
ClickBench: Total hot run time: 30.29 s |
morrySnow
force-pushed
the
exploration_space
branch
from
49b2ee9 to
7cd492a
Compare
Contributor
Author
|
run buildall |
morrySnow
changed the title
morrySnow
changed the title
morrySnow
force-pushed
the
exploration_space
branch
2 times, most recently
from
960d886 to
2c32bd4
Compare
morrySnow
force-pushed
the
exploration_space
branch
from
2c32bd4 to
eea4e2e
Compare
Contributor
Author
|
run buildall |
xzj7019
reviewed
Jul 26, 2024
| @@ -98,7 +98,7 @@ public Rule build() { | |||
| newTopHashConjuncts.forEach(expr -> topUsedExprIds.addAll(expr.getInputSlotExprIds())); | |||
| newTopOtherConjuncts.forEach(expr -> topUsedExprIds.addAll(expr.getInputSlotExprIds())); | |||
| Plan left = CBOUtils.newProject(topUsedExprIds, newBottomJoin); | |||
Contributor
There was a problem hiding this comment.
why not apply this for both sides? Means left side's new project is a must?
Contributor
Author
There was a problem hiding this comment.
we need a project between join and join
TPC-H: Total hot run time: 40687 ms |
TPC-DS: Total hot run time: 170460 ms |
ClickBench: Total hot run time: 31.7 s |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run cloud_p0 |
xzj7019
reviewed
Jul 29, 2024
| GroupExpressionMatching groupExpressionMatching | ||
| = new GroupExpressionMatching(rule.getPattern(), groupExpression); | ||
| for (Plan plan : groupExpressionMatching) { | ||
| if (rule.isExploration() |
Contributor
There was a problem hiding this comment.
if the checking is moved here, can the logic in getJoinRules be removed?
Contributor
Author
There was a problem hiding this comment.
no, in OptimizeGroupExpressionJob we could avoid generate ApplyRuleJob at all. so remove it will generate many useless job to slow down planning
xzj7019
approved these changes
Jul 29, 2024
Contributor
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Jul 29, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jul 29, 2024
#38317) 1. use set to compare project 2. use map to store enforcer 3. avoid genarate useless project under bottom join when do join reorder
Closed
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Nov 12, 2024
apache#38317) 1. use set to compare project 2. use map to store enforcer 3. avoid genarate useless project under bottom join when do join reorder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.