Skip to content

[Fix](inverted index) skip index compaction for inverted index V2 #38209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airborne12 merged 2 commits into from
Jul 23, 2024
Merged

[Fix](inverted index) skip index compaction for inverted index V2 #38209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d2df7
[Fix](inverted index) skip index compaction for inverted index V2
airborne12 Jul 22, 2024
d322c54
disable test_index_compaction_failure_injection
airborne12 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions be/src/olap/compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,9 @@ Status CompactionMixin::construct_output_rowset_writer(RowsetWriterContext& ctx)
if (config::inverted_index_compaction_enable &&
(((_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
_tablet->enable_unique_key_merge_on_write()) ||
_tablet->keys_type() == KeysType::DUP_KEYS))) {
_tablet->keys_type() == KeysType::DUP_KEYS)) &&
_cur_tablet_schema->get_inverted_index_storage_format() ==
InvertedIndexStorageFormatPB::V1) {
construct_skip_inverted_index(ctx);
}
ctx.version = _output_version;
Expand Down Expand Up @@ -1199,7 +1201,9 @@ Status CloudCompactionMixin::construct_output_rowset_writer(RowsetWriterContext&
if (config::inverted_index_compaction_enable &&
(((_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
_tablet->enable_unique_key_merge_on_write()) ||
_tablet->keys_type() == KeysType::DUP_KEYS))) {
_tablet->keys_type() == KeysType::DUP_KEYS)) &&
_cur_tablet_schema->get_inverted_index_storage_format() ==
InvertedIndexStorageFormatPB::V1) {
construct_skip_inverted_index(ctx);
}

Expand Down
1 change: 1 addition & 0 deletions regression-test/pipeline/cloud_p0/conf/regression-conf-custom.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ excludeSuites = "000_the_start_sentinel_do_not_touch," + // keep this line as th
"test_show_transaction," + // not supported yet
"test_spark_load," +
"test_index_lowercase_fault_injection," +
"test_index_compaction_failure_injection," +
"test_partial_update_2pc_schema_change," + // mow 2pc
"test_query_sys_rowsets," + // rowsets sys table
"test_unique_table_debug_data," + // disable auto compaction
Expand Down
1 change: 1 addition & 0 deletions regression-test/pipeline/p0/conf/regression-conf.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ excludeSuites = "000_the_start_sentinel_do_not_touch," + // keep this line as th
"test_spark_load," +
"test_broker_load_func," +
"test_stream_stub_fault_injection," +
"test_index_compaction_failure_injection," +
"zzz_the_end_sentinel_do_not_touch" // keep this line as the last line

// this directories will not be executed
Expand Down