[Fix](JobManager)Release the lock immediately after modifying job metadata to avoid holding the lock for an extended period.#38162
Merged
CalvinKirs merged 3 commits intoapache:masterfrom Jul 23, 2024
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 39899 ms |
TPC-DS: Total hot run time: 174144 ms |
ClickBench: Total hot run time: 30.91 s |
…adata to avoid holding the lock for an extended period.
yiguolei
force-pushed
the
master-job-lock
branch
from
1ab1d57 to
a5960cf
Compare
Contributor
|
run buildall |
yiguolei
previously approved these changes
Jul 19, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39693 ms |
TPC-DS: Total hot run time: 173791 ms |
ClickBench: Total hot run time: 30.58 s |
…adata to avoid holding the lock for an extended period.
…-lock # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/job/manager/JobManager.java
github-actions
bot
removed
the
approved
Member
Author
|
run buildall |
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jul 20, 2024
…adata to avoid holding the lock for an extended period.apache#38162
TPC-H: Total hot run time: 39981 ms |
TPC-DS: Total hot run time: 174487 ms |
ClickBench: Total hot run time: 30.74 s |
zddr
approved these changes
Jul 22, 2024
JNSimba
approved these changes
Jul 22, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Member
Author
|
run cloud_p0 |
1 similar comment
Member
Author
|
run cloud_p0 |
dataroaring
pushed a commit
that referenced
this pull request
Jul 24, 2024
…adata to avoid holding the lock for an extended period. (#38162) ## Proposed changes When deleting a job in MV, a DB lock is held. However, due to the larger lock granularity of the Job Manager, this may prevent obtaining the lock. This issue arises because during the creation of a job, immediately scheduled tasks need to perform their initial scheduling and compensate for tasks within the time window. To alleviate this issue, we are attempting to reduce the lock granularity. <!--Describe your changes.-->
morningman
added
dev/2.1.6-merged
dev/2.1.5-merged
and removed
dev/2.1.5-merged
dev/2.1.6-merged
labels
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When deleting a job in MV, a DB lock is held. However, due to the larger lock granularity of the Job Manager, this may prevent obtaining the lock. This issue arises because during the creation of a job, immediately scheduled tasks need to perform their initial scheduling and compensate for tasks within the time window. To alleviate this issue, we are attempting to reduce the lock granularity.