[fix](core) fix closure use after release by Mryange · Pull Request #38087 · apache/doris

Mryange · 2024-07-18T09:51:43Z

Proposed changes

*** SIGSEGV address not mapped to object (@0x8) received by PID 3465895 (TID 3467451 OR 0x7f383371d700) from PID 8; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_release/doris/be/src/common/signal_handler.h:421
 1# 0x00007F3B62FFEB50 in /lib64/libc.so.6
 2# doris::PInternalServiceImpl::_response_pull_slave_rowset(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, long, long, long, long, bool) at /home/zcp/repo_center/doris_release/doris/be/src/service/internal_service.cpp:1922
 3# doris::PInternalServiceImpl::request_slave_tablet_pull_rowset(google::protobuf::RpcController*, doris::PTabletWriteSlaveRequest const*, doris::PTabletWriteSlaveResult*, google::protobuf::Closure*)::$_0::operator()() const at /home/zcp/repo_center/doris_release/doris/be/src/service/internal_service.cpp:1878
 4# doris::WorkThreadPool<false>::work_thread(int) at /home/zcp/repo_center/doris_release/doris/be/src/util/work_thread_pool.hpp:159
 5# execute_native_thread_routine at ../../../../../libstdc++-v3/src/c++11/thread.cc:84
 6# start_thread in /lib64/libpthread.so.0
 7# __clone in /lib64/libc.so.6

doris-robot · 2024-07-18T09:51:49Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Mryange · 2024-07-18T09:51:51Z

run buildall

github-actions · 2024-07-18T09:57:32Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-07-18T10:26:28Z

TPC-H: Total hot run time: 40143 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 623fa740684986b449c479c41896ba90de61aae1, data reload: false

------ Round 1 ----------------------------------
q1	17639	4456	4262	4262
q2	2024	193	189	189
q3	11109	1237	1128	1128
q4	10547	794	784	784
q5	7883	2695	2695	2695
q6	221	140	143	140
q7	987	626	618	618
q8	9342	2135	2154	2135
q9	9037	6701	6698	6698
q10	9120	3746	3801	3746
q11	471	243	248	243
q12	400	228	225	225
q13	19089	2970	2985	2970
q14	274	232	241	232
q15	530	467	482	467
q16	496	382	377	377
q17	989	656	703	656
q18	8056	7689	7491	7491
q19	1595	1289	1447	1289
q20	700	340	338	338
q21	5117	3169	3901	3169
q22	354	293	291	291
Total cold run time: 115980 ms
Total hot run time: 40143 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4281	4207	4225	4207
q2	390	279	284	279
q3	3053	2774	2713	2713
q4	1870	1603	1609	1603
q5	5308	5317	5315	5315
q6	218	133	133	133
q7	2117	1745	1747	1745
q8	3224	3393	3321	3321
q9	8351	8388	8370	8370
q10	3887	3706	3780	3706
q11	632	477	480	477
q12	785	605	599	599
q13	17442	2961	3012	2961
q14	317	279	289	279
q15	533	475	481	475
q16	466	406	419	406
q17	1776	1499	1475	1475
q18	7726	7748	7299	7299
q19	1680	1502	1407	1407
q20	2016	1787	1774	1774
q21	4924	4664	4670	4664
q22	566	511	504	504
Total cold run time: 71562 ms
Total hot run time: 53712 ms

doris-robot · 2024-07-18T10:37:42Z

TPC-DS: Total hot run time: 173638 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 623fa740684986b449c479c41896ba90de61aae1, data reload: false

query1	922	367	363	363
query2	6475	1917	1889	1889
query3	6656	206	221	206
query4	24348	17426	17126	17126
query5	4187	493	489	489
query6	286	185	185	185
query7	4603	303	300	300
query8	245	202	193	193
query9	8426	2518	2508	2508
query10	454	292	282	282
query11	11461	10034	10067	10034
query12	133	84	83	83
query13	1641	403	361	361
query14	9596	7758	7605	7605
query15	227	176	165	165
query16	7849	312	309	309
query17	1832	552	522	522
query18	1796	285	275	275
query19	210	152	150	150
query20	94	83	81	81
query21	213	126	124	124
query22	4481	4128	3921	3921
query23	33655	33209	33085	33085
query24	12024	2885	2848	2848
query25	660	367	368	367
query26	1746	148	149	148
query27	3053	275	272	272
query28	7631	2044	2064	2044
query29	1103	644	601	601
query30	288	151	146	146
query31	1005	730	760	730
query32	96	52	57	52
query33	765	297	300	297
query34	994	496	493	493
query35	699	576	579	576
query36	1110	944	946	944
query37	282	78	81	78
query38	2883	2800	2751	2751
query39	880	817	828	817
query40	277	119	116	116
query41	50	45	43	43
query42	118	97	101	97
query43	508	472	472	472
query44	1232	724	734	724
query45	194	163	158	158
query46	1102	734	730	730
query47	1847	1775	1770	1770
query48	384	295	294	294
query49	1193	447	409	409
query50	788	398	412	398
query51	6939	6847	6788	6788
query52	108	94	91	91
query53	360	285	298	285
query54	1069	460	452	452
query55	77	75	77	75
query56	299	263	270	263
query57	1178	1056	1064	1056
query58	265	234	254	234
query59	2822	2625	2608	2608
query60	300	271	280	271
query61	96	96	92	92
query62	836	627	667	627
query63	322	296	293	293
query64	10540	2192	1691	1691
query65	3161	3098	3110	3098
query66	1353	336	325	325
query67	15233	15023	15034	15023
query68	4489	554	545	545
query69	478	327	335	327
query70	1169	1123	1146	1123
query71	408	275	290	275
query72	7179	5851	5743	5743
query73	767	331	337	331
query74	6062	5633	5622	5622
query75	3466	2689	2706	2689
query76	2862	953	957	953
query77	451	307	313	307
query78	11696	9360	9949	9360
query79	3391	532	544	532
query80	1938	499	511	499
query81	597	226	222	222
query82	703	144	141	141
query83	310	179	173	173
query84	282	96	97	96
query85	1259	373	352	352
query86	502	324	315	315
query87	3287	3137	3104	3104
query88	4383	2503	2482	2482
query89	496	392	390	390
query90	2054	196	201	196
query91	147	113	112	112
query92	73	51	54	51
query93	3265	530	521	521
query94	1379	230	226	226
query95	433	335	338	335
query96	595	284	282	282
query97	3198	2991	3053	2991
query98	223	206	197	197
query99	1789	1243	1250	1243
Total cold run time: 286991 ms
Total hot run time: 173638 ms

doris-robot · 2024-07-18T10:43:14Z

ClickBench: Total hot run time: 30.6 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 623fa740684986b449c479c41896ba90de61aae1, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.49	0.49
query6	1.13	0.72	0.71
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.55	0.48	0.49
query10	0.55	0.53	0.53
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.59
query14	0.77	0.79	0.80
query15	0.85	0.82	0.80
query16	0.37	0.37	0.37
query17	1.01	0.94	1.02
query18	0.23	0.22	0.22
query19	1.80	1.67	1.72
query20	0.01	0.01	0.02
query21	15.41	0.72	0.64
query22	4.02	7.58	2.05
query23	18.30	1.30	1.30
query24	2.10	0.23	0.24
query25	0.14	0.08	0.08
query26	0.30	0.21	0.22
query27	0.46	0.23	0.24
query28	13.24	1.02	1.01
query29	12.68	3.29	3.26
query30	0.25	0.06	0.06
query31	2.84	0.39	0.38
query32	3.30	0.48	0.48
query33	2.84	2.92	2.86
query34	16.88	4.33	4.37
query35	4.44	4.53	4.38
query36	0.65	0.45	0.48
query37	0.18	0.16	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.15	0.13	0.11
query41	0.09	0.04	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.32 s
Total hot run time: 30.6 s

Mryange · 2024-07-18T11:08:54Z

run buildall

github-actions · 2024-07-18T11:14:38Z

clang-tidy review says "All clean, LGTM! 👍"

Mryange · 2024-07-18T11:27:35Z

run buildall

github-actions · 2024-07-18T11:33:18Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-07-18T12:00:25Z

TPC-H: Total hot run time: 40217 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 92a3e2e1533de20c5a36c712eb257e524da155b8, data reload: false

------ Round 1 ----------------------------------
q1	17986	4594	4361	4361
q2	2470	195	194	194
q3	11125	1253	1047	1047
q4	10551	746	913	746
q5	7632	2787	2691	2691
q6	227	145	141	141
q7	980	618	623	618
q8	9292	2129	2127	2127
q9	8662	6585	6602	6585
q10	8782	3780	3772	3772
q11	467	244	250	244
q12	412	231	227	227
q13	18774	2967	3019	2967
q14	275	232	228	228
q15	538	499	482	482
q16	498	392	375	375
q17	985	717	732	717
q18	8041	7484	7464	7464
q19	6046	1446	1474	1446
q20	672	334	339	334
q21	4942	3164	3264	3164
q22	351	291	287	287
Total cold run time: 119708 ms
Total hot run time: 40217 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4419	4396	4259	4259
q2	375	274	275	274
q3	2964	2795	2750	2750
q4	1905	1615	1613	1613
q5	5305	5325	5304	5304
q6	217	130	135	130
q7	2103	1725	1771	1725
q8	3188	3350	3322	3322
q9	8499	8404	8513	8404
q10	3911	3763	3674	3674
q11	583	491	469	469
q12	759	591	589	589
q13	16339	2950	2977	2950
q14	301	274	268	268
q15	516	466	466	466
q16	471	412	423	412
q17	1785	1470	1487	1470
q18	7648	7586	7341	7341
q19	1654	1546	1676	1546
q20	1993	1803	1795	1795
q21	4980	4718	4739	4718
q22	596	521	500	500
Total cold run time: 70511 ms
Total hot run time: 53979 ms

doris-robot · 2024-07-18T12:12:02Z

TPC-DS: Total hot run time: 172640 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 92a3e2e1533de20c5a36c712eb257e524da155b8, data reload: false

query1	914	369	367	367
query2	6446	1931	1815	1815
query3	6664	205	214	205
query4	28326	17357	17291	17291
query5	4232	477	485	477
query6	276	175	185	175
query7	4582	284	283	283
query8	240	199	186	186
query9	8694	2496	2487	2487
query10	441	309	283	283
query11	11651	9935	9979	9935
query12	127	84	87	84
query13	1654	370	370	370
query14	10200	7339	7544	7339
query15	221	172	169	169
query16	7839	330	325	325
query17	1804	567	548	548
query18	1914	286	293	286
query19	195	152	153	152
query20	95	81	84	81
query21	208	130	125	125
query22	4459	4037	4021	4021
query23	33747	33359	33066	33066
query24	12042	2920	2854	2854
query25	674	388	385	385
query26	1753	159	152	152
query27	2834	275	281	275
query28	7700	2053	2042	2042
query29	1067	653	647	647
query30	287	145	148	145
query31	966	743	777	743
query32	97	54	57	54
query33	792	322	313	313
query34	910	496	507	496
query35	737	587	567	567
query36	1103	960	947	947
query37	200	83	83	83
query38	2922	2766	2764	2764
query39	860	823	839	823
query40	278	124	118	118
query41	54	46	46	46
query42	125	99	100	99
query43	504	469	471	469
query44	1209	726	723	723
query45	193	163	166	163
query46	1098	744	721	721
query47	1845	1763	1822	1763
query48	374	302	293	293
query49	1222	431	420	420
query50	775	413	401	401
query51	6846	6858	6756	6756
query52	100	93	93	93
query53	372	298	291	291
query54	958	455	464	455
query55	77	73	77	73
query56	317	289	301	289
query57	1162	1052	1042	1042
query58	274	260	255	255
query59	2888	2631	2839	2631
query60	429	275	302	275
query61	98	95	114	95
query62	836	631	661	631
query63	319	288	282	282
query64	10439	2189	1704	1704
query65	3198	3105	3104	3104
query66	1367	334	331	331
query67	15721	14920	14978	14920
query68	8989	558	564	558
query69	743	436	354	354
query70	1323	1168	1146	1146
query71	521	273	276	273
query72	8627	5521	5767	5521
query73	2208	330	333	330
query74	6202	5666	5609	5609
query75	5180	2684	2718	2684
query76	5421	959	886	886
query77	757	307	292	292
query78	9883	8932	8927	8927
query79	10088	523	535	523
query80	1047	469	469	469
query81	575	228	220	220
query82	503	138	133	133
query83	342	208	166	166
query84	278	83	86	83
query85	1163	308	285	285
query86	399	319	324	319
query87	3333	3083	3148	3083
query88	4316	2482	2470	2470
query89	546	374	370	370
query90	2016	197	195	195
query91	132	99	97	97
query92	62	47	49	47
query93	6852	515	514	514
query94	1313	216	211	211
query95	406	320	318	318
query96	617	272	269	269
query97	3167	3022	3030	3022
query98	213	200	199	199
query99	1696	1291	1264	1264
Total cold run time: 311869 ms
Total hot run time: 172640 ms

doris-robot · 2024-07-18T12:17:32Z

ClickBench: Total hot run time: 30.78 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 92a3e2e1533de20c5a36c712eb257e524da155b8, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.05	0.05
query4	1.69	0.07	0.07
query5	0.49	0.49	0.49
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.55	0.49	0.49
query10	0.55	0.54	0.53
query11	0.15	0.11	0.12
query12	0.15	0.12	0.13
query13	0.58	0.57	0.58
query14	0.76	0.78	0.76
query15	0.84	0.82	0.81
query16	0.36	0.37	0.36
query17	1.01	1.04	1.02
query18	0.23	0.21	0.21
query19	1.79	1.70	1.71
query20	0.02	0.01	0.01
query21	15.50	0.72	0.66
query22	4.55	7.01	2.11
query23	18.33	1.36	1.27
query24	2.16	0.22	0.22
query25	0.15	0.09	0.09
query26	0.30	0.21	0.20
query27	0.45	0.24	0.23
query28	13.23	1.02	0.99
query29	12.63	3.34	3.33
query30	0.26	0.06	0.06
query31	2.87	0.39	0.38
query32	3.28	0.47	0.47
query33	2.83	2.91	2.90
query34	16.79	4.29	4.32
query35	4.40	4.43	4.42
query36	0.65	0.46	0.49
query37	0.18	0.16	0.16
query38	0.17	0.14	0.15
query39	0.05	0.04	0.03
query40	0.15	0.11	0.13
query41	0.09	0.05	0.06
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.86 s
Total hot run time: 30.78 s

github-actions · 2024-07-18T12:28:50Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-07-18T12:28:52Z

PR approved by anyone and no changes requested.

zclllyybb

LGTM

Mryange · 2024-07-18T14:14:07Z

run external

Mryange · 2024-07-18T14:14:17Z

run cloud_p0

## Proposed changes #38087

@0x8

## Proposed changes ``` *** SIGSEGV address not mapped to object (@0x8) received by PID 3465895 (TID 3467451 OR 0x7f383371d700) from PID 8; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_release/doris/be/src/common/signal_handler.h:421 1# 0x00007F3B62FFEB50 in /lib64/libc.so.6 2# doris::PInternalServiceImpl::_response_pull_slave_rowset(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, long, long, long, long, bool) at /home/zcp/repo_center/doris_release/doris/be/src/service/internal_service.cpp:1922 3# doris::PInternalServiceImpl::request_slave_tablet_pull_rowset(google::protobuf::RpcController*, doris::PTabletWriteSlaveRequest const*, doris::PTabletWriteSlaveResult*, google::protobuf::Closure*)::$_0::operator()() const at /home/zcp/repo_center/doris_release/doris/be/src/service/internal_service.cpp:1878 4# doris::WorkThreadPool<false>::work_thread(int) at /home/zcp/repo_center/doris_release/doris/be/src/util/work_thread_pool.hpp:159 5# execute_native_thread_routine at ../../../../../libstdc++-v3/src/c++11/thread.cc:84 6# start_thread in /lib64/libpthread.so.0 7# __clone in /lib64/libc.so.6 ```

HappenLee added dev/2.1.x dev/3.0.x labels Jul 18, 2024

Mryange force-pushed the closure-fix branch from 623fa74 to 11b9837 Compare July 18, 2024 11:08

fix

92a3e2e

Mryange force-pushed the closure-fix branch from 11b9837 to 92a3e2e Compare July 18, 2024 11:27

yiguolei approved these changes Jul 18, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2024

github-actions bot added the reviewed label Jul 18, 2024

Mryange mentioned this pull request Jul 18, 2024

[fix](core) fix closure use after release #38087 #38094

Merged

zclllyybb approved these changes Jul 18, 2024

View reviewed changes

yiguolei pushed a commit that referenced this pull request Jul 18, 2024

[fix](core) fix closure use after release #38087 (#38094)

294157d

## Proposed changes #38087

yiguolei added dev/2.1.5-merged and removed dev/2.1.x labels Jul 18, 2024

yiguolei approved these changes Jul 18, 2024

View reviewed changes

yiguolei merged commit 4901836 into apache:master Jul 18, 2024

dataroaring added dev/3.0.1-merged and removed dev/3.0.x labels Jul 25, 2024

gavinchou mentioned this pull request Aug 19, 2024

Release Note 3.0.1 #39570

Closed

Conversation

Mryange commented Jul 18, 2024

Proposed changes

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

Mryange commented Jul 18, 2024

Uh oh!

github-actions bot commented Jul 18, 2024

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

Mryange commented Jul 18, 2024

Uh oh!

github-actions bot commented Jul 18, 2024

Uh oh!

Mryange commented Jul 18, 2024

Uh oh!

github-actions bot commented Jul 18, 2024

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

doris-robot commented Jul 18, 2024

Uh oh!

github-actions bot commented Jul 18, 2024

Uh oh!

github-actions bot commented Jul 18, 2024

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

Mryange commented Jul 18, 2024

Uh oh!

Mryange commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants