[fix](move-memtable) multi replica tables should tolerate minority failures#38003
Merged
liaoxin01 merged 6 commits intoapache:masterfrom Aug 8, 2024
Merged
[fix](move-memtable) multi replica tables should tolerate minority failures#38003liaoxin01 merged 6 commits intoapache:masterfrom
liaoxin01 merged 6 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39987 ms |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40164 ms |
TPC-DS: Total hot run time: 173918 ms |
ClickBench: Total hot run time: 30.55 s |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39787 ms |
TPC-DS: Total hot run time: 173924 ms |
ClickBench: Total hot run time: 30.63 s |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39944 ms |
TPC-DS: Total hot run time: 173034 ms |
ClickBench: Total hot run time: 30.69 s |
Member
Author
|
run buildall |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-DS: Total hot run time: 169763 ms |
ClickBench: Total hot run time: 29.9 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…ilures (#38003) Load job for multi replica tables shouldn't fail immediately on any single replica errors. Errors should be recorded and reported for individual replica of tablets, and checked on commit info.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
…ilures (apache#38003) Load job for multi replica tables shouldn't fail immediately on any single replica errors. Errors should be recorded and reported for individual replica of tablets, and checked on commit info.
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…ilures (#38003) Load job for multi replica tables shouldn't fail immediately on any single replica errors. Errors should be recorded and reported for individual replica of tablets, and checked on commit info.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Sep 6, 2024
…ilures (apache#38003) Load job for multi replica tables shouldn't fail immediately on any single replica errors. Errors should be recorded and reported for individual replica of tablets, and checked on commit info.
Closed
Closed
16 tasks
liaoxin01
pushed a commit
that referenced
this pull request
Nov 21, 2024
…44344) Problem Summary: #38003 introduced a problem where the last sink node could report success even when close wait timeout, which may cause data loss. Previously we made that change hoping to tolerate minority replica failure in this step. However, it turns out the last sink node could miss tablet reports from downstreams in case of close wait failure. This PR fixes the problem by return the close_wait error immediately. The most common error in close wait is timeout, and it should not be fault tolerant on a replica basis anyways.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…44344) Problem Summary: #38003 introduced a problem where the last sink node could report success even when close wait timeout, which may cause data loss. Previously we made that change hoping to tolerate minority replica failure in this step. However, it turns out the last sink node could miss tablet reports from downstreams in case of close wait failure. This PR fixes the problem by return the close_wait error immediately. The most common error in close wait is timeout, and it should not be fault tolerant on a replica basis anyways.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…44344) Problem Summary: #38003 introduced a problem where the last sink node could report success even when close wait timeout, which may cause data loss. Previously we made that change hoping to tolerate minority replica failure in this step. However, it turns out the last sink node could miss tablet reports from downstreams in case of close wait failure. This PR fixes the problem by return the close_wait error immediately. The most common error in close wait is timeout, and it should not be fault tolerant on a replica basis anyways.
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Nov 22, 2024
…pache#44344) Problem Summary: apache#38003 introduced a problem where the last sink node could report success even when close wait timeout, which may cause data loss. Previously we made that change hoping to tolerate minority replica failure in this step. However, it turns out the last sink node could miss tablet reports from downstreams in case of close wait failure. This PR fixes the problem by return the close_wait error immediately. The most common error in close wait is timeout, and it should not be fault tolerant on a replica basis anyways.
morningman
pushed a commit
that referenced
this pull request
Nov 25, 2024
…44344) Problem Summary: #38003 introduced a problem where the last sink node could report success even when close wait timeout, which may cause data loss. Previously we made that change hoping to tolerate minority replica failure in this step. However, it turns out the last sink node could miss tablet reports from downstreams in case of close wait failure. This PR fixes the problem by return the close_wait error immediately. The most common error in close wait is timeout, and it should not be fault tolerant on a replica basis anyways.
yiguolei
pushed a commit
that referenced
this pull request
Nov 25, 2024
…44344) Problem Summary: #38003 introduced a problem where the last sink node could report success even when close wait timeout, which may cause data loss. Previously we made that change hoping to tolerate minority replica failure in this step. However, it turns out the last sink node could miss tablet reports from downstreams in case of close wait failure. This PR fixes the problem by return the close_wait error immediately. The most common error in close wait is timeout, and it should not be fault tolerant on a replica basis anyways.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Load job for multi replica tables shouldn't fail immediately on any single replica errors.
Errors should be recorded and reported for individual replica of tablets, and checked on commit info.