[bug](delete) fix delete random distributed tbl#37985
Merged
dataroaring merged 2 commits intoapache:masterfrom Jul 24, 2024
Merged
[bug](delete) fix delete random distributed tbl#37985dataroaring merged 2 commits intoapache:masterfrom
dataroaring merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39822 ms |
TPC-DS: Total hot run time: 174371 ms |
ClickBench: Total hot run time: 30.69 s |
Contributor
Author
done |
TPC-H: Total hot run time: 39806 ms |
TPC-DS: Total hot run time: 172758 ms |
ClickBench: Total hot run time: 31.43 s |
morrySnow
approved these changes
Jul 18, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Proposed changes Bug description: In PR #33630, Doris supports auto aggregation for random distributed table, but it not only effects query statements, so if we delete from a random distributed table, will get an error because of unexpectedly rewriting. ``` CREATE TABLE `test_tbl` ( `k` INT NULL, `v` BIGINT SUM NULL ) ENGINE=OLAP AGGREGATE KEY(`k`) DISTRIBUTED BY RANDOM BUCKETS AUTO; mysql > delete from test_tbl where k=1; ERROR 1105 (HY000): errCode = 2, detailMessage = Where clause only supports compound predicate, binary predicate, is_null predicate or in predicate. ``` fix: Check whether it is a query statement before rewriting.
Closed
yiguolei
pushed a commit
that referenced
this pull request
Aug 23, 2024
## Proposed changes cherry-pick #37985 <!--Describe your changes.-->
starocean999
pushed a commit
that referenced
this pull request
Aug 27, 2024
## Proposed changes After pr #37985, explain will not be rewritten for querying random distributed table, so remove explain action in regression test case. <!--Describe your changes.-->
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
## Proposed changes After pr #37985, explain will not be rewritten for querying random distributed table, so remove explain action in regression test case. <!--Describe your changes.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Bug description:
In PR #33630, Doris supports auto aggregation for random distributed table, but it not only effects query statements, so if we delete from a random distributed table, will get an error because of unexpectedly rewriting.
fix:
Check whether it is a query statement before rewriting.